• Andrei's avatar
    MDEV-28310 Missing binlog data for INSERT .. ON DUPLICATE KEY UPDATE · a5dc12ee
    Andrei authored
    MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
    
    MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
    on two or more unique key table left a flaw. The fixes checked the
    safety condition per each inserted record with the idea to catch a user-created
    value to an autoincrement column and when that succeeds the autoincrement column
    would become the source of unsafety too.
    It was not expected that after a duplicate error the next record's
    write_set may become different and the unsafe decision for that
    specific record will be computed to screw the Query's binlogging
    state and when @@binlog_format is MIXED nothing gets bin-logged.
    
    This case has been already fixed in 10.5.2 by 91ab42a8 that
    relocated/optimized THD::decide_logging_format_low() out of the record insert
    loop. The safety decision is computed once and at the right time.
    Pertinent parts of the commit are cherry-picked.
    
    Also a spurious warning about unsafety is removed when MIXED
    @@binlog_format; original MDEV-17614 test result corrected.
    The original test of MDEV-17614 is extended and made more readable.
    a5dc12ee
sql_insert.cc 156 KB