• Shishir Jaiswal's avatar
    Bug #20802751 - SEGMENTATION FAILURE WHEN RUNNING · bf681d6b
    Shishir Jaiswal authored
                    MYSQLADMIN -U ROOT -P
    
    DESCRIPTION
    ===========
    Crash occurs when no command is given while executing
    mysqladmin utility.
    
    ANALYSIS
    ========
    In mask_password() the final write to array 'temp_argv'
    is done without checking if corresponding index 'argc'
    is valid (non-negative) or not. In case its negative
    (would happen when this function is called with 'argc'=0),
    it may cause a SEGFAULT. Logically in such a case,
    mask_password() should not have been called as it would do
    no valid thing.
    
    FIX
    ===
    mask_password() is now called after checking 'argc'. This
    function is now called only when 'argc' is positive
    otherwise the process terminates
    bf681d6b
mysqladmin.cc 41.8 KB