• Alexey Kopytov's avatar
    Bug #42849: innodb crash with varying time_zone on partitioned · c08e6c88
    Alexey Kopytov authored
                timestamp primary key 
     
    Since TIMESTAMP values are adjusted by the current time zone  
    settings in both numeric and string contexts, using any 
    expressions involving TIMESTAMP values as a  
    (sub)partitioning function leads to undeterministic behavior of  
    partitioned tables. The effect may vary depending on a storage  
    engine, it can be either incorrect data being retrieved or  
    stored, or an assertion failure. The root cause of this is the  
    fact that the calculated partition ID may differ from a  
    previously calculated ID for the same data due to timezone  
    adjustments of the partitioning expression value. 
     
    Fixed by disabling any expressions involving TIMESTAMP values  
    to be used in partitioning functions with the follwing two 
    exceptions: 
     
    1. Creating or altering into a partitioned table that violates 
    the above rule is not allowed, but opening existing such tables 
    results in a warning rather than an error so that such tables 
    could be fixed. 
     
    2. UNIX_TIMESTAMP() is the only way to get a 
    timezone-independent value from a TIMESTAMP column, because it 
    returns the internal representation (a time_t value) of a 
    TIMESTAMP argument verbatim. So UNIX_TIMESTAMP(timestamp_column)
    is allowed and should be used to fix existing tables if one 
    wants to use TIMESTAMP columns with partitioning.
    
    mysql-test/r/partition_bug18198.result:
      Corrected the error.
    mysql-test/r/partition_error.result:
      Corrected error texts.
      Added test cases for bug #42849.
    mysql-test/t/partition_bug18198.test:
      Corrected error code.
    mysql-test/t/partition_error.test:
      Corrected error codes.
      Added test cases for bug #42849.
    sql/item.h:
      Added is_timezone_dependent_processor() to Item.
    sql/item_func.h:
      Added has_timestamp_args() and the implementation of
      is_timezone_dependent_processor() for Item_func.
    sql/item_timefunc.h:
      Added is_timezone_dependent_processor() to 
      Item_func_unix_timestamp.
    sql/share/errmsg.txt:
      Renamed ER_CONST_EXPR_IN_PARTITION_FUNC_ERROR to
      ER_WRONG_EXPR_IN_PARTITION_FUNC_ERROR to better reflect the
      meaning. Adjusted the error message.
    sql/sql_partition.cc:
      Modified fix_fields_part_func() to walk through partitioning
      expression tree with is_timezone_dependent_processor() and issue
      a warning/error if it depends on the timezone settings.
      
      Changed fix_fields_part_func() to a static function since it is
      not used anywhere except sql_partition.cc
    sql/sql_partition.h:
      Removed the unneeded declaration of fix_fields_part_func()
      since it is now a static function.
    sql/sql_yacc.yy:
      ER_CONST_EXPR_IN_PARTITION_FUNC_ERROR ->
      ER_WRONG_EXPR_IN_PARTITION_FUNC_ERROR.
    c08e6c88
item_timefunc.h 28.3 KB