• Nikita Malyavin's avatar
    MDEV-30984 Online ALTER table is denied with non-informative error messages · c382de72
    Nikita Malyavin authored
    Group all the checks in online_alter_check_supported().
    
    There is now two groups of checks:
    1. A technical availability of online, that is checked before open_tables,
    and affects table_list->lock_type. It's supposed to be safe to make it
    TL_READ even if COPY algorithm will fall back to not-online, since MDL is
    SHARED_UPGRADEABLE anyway.
    2. An 'online' availability for a COPY algorithm. It can be done as late as
    just before the copy_data_between_tables call. The lock_type influence is
    disclosed above, so the only other place it affects is
    Alter_info::supports_lock, where `online` flag is only used to decide
    whether to report the error at the inplace preparation stage. We'd want to
    make that at the last resort, which is COPY preparation, if no algorithm is
    chosen by the user. So it's event better now.
    
    Some changes are required to the autoinc support detection, as the check
    now happens after mysql_prepare_alter_table:
    * alter_info->drop_list is empty
    * instead, dropped columns are in tmp_set
    * alter_info->create_list now has every field that's in the new table.
    * the column definition's change.str will be nonnull whether the column
      remains in the new table (vs whether it was changed, as before).
      But it also has `field` field set.
    * IF EXISTS doesn't have to be dealt anymore
    
    This infers that the changes are now checked in more detail: a field's
    definition shouldn't be changed, vs a field shouldn't be mentioned in
    the CHANGE list, as it was before. This is reflected by the line 193 test.
    c382de72
sql_class.h 253 KB