• Brandon Nesterenko's avatar
    MDEV-32628: Cryptic ERROR message & inconsistent behavior on incorrect SHOW BINLOG EVENTS FROM ... · c42aadc3
    Brandon Nesterenko authored
    Calling SHOW BINLOG EVENTS FROM <offset> with an invalid offset
    writes error messages into the server log about invalid reads. The
    read errors that occur from this command should only be relayed back
    to the user though, and not written into the server log. This is
    because they are read-only and have no impact on server operation,
    and the client only need be informed to correct the parameter.
    
    This patch fixes this by omitting binary log read errors from the
    server when the invocation happens from SHOW BINLOG EVENTS.
    Additionally, redundant error messages are omitted when calling the
    string based read_log_event from the IO_Cache based read_log_event,
    as the later already will report the error of the former.
    
    Reviewed By:
    ============
    Kristian Nielsen <knielsen@knielsen-hq.org>
    Andrei Elkin <andrei.elkin@mariadb.com>
    c42aadc3
log_event.cc 479 KB