• unknown's avatar
    Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement. · cf2188ca
    unknown authored
    1.) Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
    Used the new option in create_table_from_items().
    It is necessary to prevent the SELECT table from being reopend.
    It would get new storage assigned for its fields, while the
    SELECT part of the command would still use the old (freed) storage.
    2.) Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
    against a global read lock. This prevents a deadlock in
    CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
    and avoids the creation of new tables during a global read lock.
    3.) Replaced set_protect_against_global_read_lock() and
    unset_protect_against_global_read_lock() by
    wait_if_global_read_lock() and start_waiting_global_read_lock()
    in the INSERT DELAYED handling.
    
    
    mysql-test/r/create.result:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Added test results.
    mysql-test/t/create.test:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Added tests which do not require concurrency.
    sql/lock.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
      Changed the parameter list.
      Removed two unnecessary functions. Their functionality is included in
      wait_if_global_read_lock() and start_waiting_global_read_lock().
    sql/mysql_priv.h:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Changed the declaration of mysql_lock_tables().
      Added definitions for the new options.
    sql/sql_acl.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Adjusted mysql_lock_tables() calls to the new argument list.
    sql/sql_base.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Adjusted mysql_lock_tables() calls to the new argument list.
    sql/sql_handler.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Adjusted mysql_lock_tables() calls to the new argument list.
    sql/sql_insert.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Replaced set_protect_against_global_read_lock() and
      unset_protect_against_global_read_lock() by
      wait_if_global_read_lock() and start_waiting_global_read_lock()
      in the INSERT DELAYED handling.
      Adjusted mysql_lock_tables() calls to the new argument list.
    sql/sql_parse.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
      against a global read lock. This prevents a deadlock in
      CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
      and avoids the creation of new tables during a global read lock.
    sql/sql_table.cc:
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
      Adjusted mysql_lock_tables() calls to the new argument list.
      Used the new option in create_table_from_items().
    cf2188ca
lock.cc 24.9 KB