• unknown's avatar
    BUG#29020 (Event results not correctly replicated to slave in RBR): · f56d77da
    unknown authored
    The bug allow multiple executing transactions working with non-transactional
    to interfere with each others by interleaving the events of different trans-
    actions.
    
    Bug is fixed by writing non-transactional events to the transaction cache and
    flushing the cache to the binary log at statement commit. To mimic the behavior
    of normal statement-based replication, we flush the transaction cache in row-
    based mode when there is no committed statements in the transaction cache,
    which means we are committing the first one. This means that it will be written
    to the binary log as a "mini-transaction" with just the rows for the statement.
    
    Note that the changes here does not take effect when building the server with
    HAVE_TRANSACTIONS set to false, but it is not clear if this was possible before
    this patch either.
    
    For row-based logging, we also have that when AUTOCOMMIT=1, the code now always
    generates a BEGIN/COMMIT pair for single statements, or BEGIN/ROLLBACK pair in the
    case of non-transactional changes in a statement that was rolled back. Note that
    for the case where changes to a non-transactional table causes a rollback due
    to error, the statement will now be logged with a BEGIN/ROLLBACK pair, even
    though some changes has been committed to the non-transactional table.
    
    
    mysql-test/extra/rpl_tests/rpl_row_delayed_ins.test:
      Removing SHOW BINLOG EVENTS causing test to be non-deterministic.
    mysql-test/r/ctype_cp932_binlog_row.result:
      Result change.
    mysql-test/suite/binlog/r/binlog_base64_flag.result:
      Result change.
    mysql-test/suite/binlog/r/binlog_multi_engine.result:
      Result file change.
    mysql-test/suite/binlog/r/binlog_row_binlog.result:
      Result file change.
    mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result:
      Result file change.
    mysql-test/suite/binlog/r/binlog_row_insert_select.result:
      Result file change.
    mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
      Result file change.
    mysql-test/suite/binlog/r/binlog_stm_binlog.result:
      Result file change.
    mysql-test/suite/binlog/t/binlog_base64_flag.test:
      Removing table that will be used in test to prevent failing if preceeding
      tests forgot to drop the table.
    mysql-test/suite/rpl/r/rpl_rbr_to_sbr.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_create_table.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_delayed_ins.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_flsh_tbls.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_inexist_tbl.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_log.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_log_innodb.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_row_until.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_slave_skip.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_switch_stm_row_mixed.result:
      Result file change.
    mysql-test/suite/rpl/r/rpl_truncate_2myisam.result:
      Result file change.
    mysql-test/suite/rpl/t/rpl_row_create_table.test:
      Binlog position change.
    mysql-test/suite/rpl/t/rpl_row_flsh_tbls.test:
      Binlog position change.
    mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
      Binlog position change. Added stop position to mysqlbinlog argments to prevent
      extreneous output.
    mysql-test/suite/rpl/t/rpl_row_until.test:
      Binlog position change.
    mysql-test/suite/rpl/t/rpl_slave_skip.test:
      Binlog position change.
    mysql-test/suite/rpl/t/rpl_switch_stm_row_mixed.test:
      Removing extreneous SHOW BINLOG EVENTS causing test to be non-deterministic.
    mysql-test/suite/rpl_ndb/r/rpl_ndb_log.result:
      Result change.
    sql/log.cc:
      Adding variable at_least_one_stmt to denote that there is at least one
      statement committed to the transaction cache (but there might be more).
      
      Removing duplicate checks from binlog_end_trans(). The transaction cache
      should always be committed or rolled back when this function is called.
      
      Correcting conditions for binlog_rollback() and binlog_commit() and removing
      the previous "invisible commit" in favor of always using explicit commits
      in the binary log.
    sql/log_event.cc:
      Marking table map event to be cached. Removing Muted_query_log_event from code.
    sql/log_event.h:
      Removing unused class Muted_query_log_event.
    sql/sql_insert.cc:
      Adding missing call to ha_autocommit_or_rollback() for delayed thread. Marking
      CREATE-SELECT statements as transactional, since they don't need to be logged.
    f56d77da
binlog_multi_engine.result 5 KB