Commit 0f0e514f authored by unknown's avatar unknown

Fixes for WL#1724 required by the third code review.


sql/item.cc:
  Document actual behavior.
sql/opt_range.cc:
  - Added a test for range predicates comparing incomparable argumens
  - Removed TRP_GROUP_MIN_MAX class members that are not used.
  - Uncommented CPU cost
  - More standard function return values
sql/sql_select.cc:
  Remove unnecessary test.
parent 4f1d7b7d
...@@ -177,9 +177,8 @@ bool Item_ident::remove_dependence_processor(byte * arg) ...@@ -177,9 +177,8 @@ bool Item_ident::remove_dependence_processor(byte * arg)
arguments in a condition the method must return false. arguments in a condition the method must return false.
RETURN RETURN
false on success (force the evaluation of collect_item_field_processor false to force the evaluation of collect_item_field_processor
for the subsequent items.) for the subsequent items.
true o/w (stop evaluation of subsequent items.)
*/ */
bool Item_field::collect_item_field_processor(byte *arg) bool Item_field::collect_item_field_processor(byte *arg)
......
This diff is collapsed.
...@@ -5020,8 +5020,7 @@ make_join_select(JOIN *join,SQL_SELECT *select,COND *cond) ...@@ -5020,8 +5020,7 @@ make_join_select(JOIN *join,SQL_SELECT *select,COND *cond)
} }
if (tmp || !cond) if (tmp || !cond)
{ {
if (tmp) DBUG_EXECUTE("where",print_where(tmp,tab->table->table_name););
DBUG_EXECUTE("where",print_where(tmp,tab->table->table_name););
SQL_SELECT *sel=tab->select=(SQL_SELECT*) SQL_SELECT *sel=tab->select=(SQL_SELECT*)
join->thd->memdup((gptr) select, sizeof(SQL_SELECT)); join->thd->memdup((gptr) select, sizeof(SQL_SELECT));
if (!sel) if (!sel)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment