Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
21223c04
Commit
21223c04
authored
Dec 18, 2022
by
Sergei Golubchik
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-29988 group by fix
parent
908c48a3
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
5 deletions
+23
-5
mysql-test/main/func_group.result
mysql-test/main/func_group.result
+10
-1
mysql-test/main/func_group.test
mysql-test/main/func_group.test
+8
-4
sql/item.h
sql/item.h
+5
-0
No files found.
mysql-test/main/func_group.result
View file @
21223c04
drop table if exists t1,t2,t3,t4,t5,t6;
set @sav_dpi= @@div_precision_increment;
set @sav_dpi= @@div_precision_increment;
set div_precision_increment= 5;
set div_precision_increment= 5;
show variables like 'div_precision_increment';
show variables like 'div_precision_increment';
...
@@ -2566,5 +2565,15 @@ stddev_samp(i) stddev_pop(i) stddev(i) std(i)
...
@@ -2566,5 +2565,15 @@ stddev_samp(i) stddev_pop(i) stddev(i) std(i)
drop view v1;
drop view v1;
drop table t1;
drop table t1;
#
#
# MDEV-29988: Major performance regression with 10.6.11
#
create table t1 (a varchar(10) charset utf8mb4, b int, c int);
insert t1 values (1,2,3),(4,5,6),(1,7,8);
select concat(a,":",group_concat(b)) from t1 group by a;
concat(a,":",group_concat(b))
1:2,7
4:5
drop table t1;
#
# End of 10.3 tests
# End of 10.3 tests
#
#
mysql-test/main/func_group.test
View file @
21223c04
...
@@ -2,10 +2,6 @@
...
@@ -2,10 +2,6 @@
# simple test of all group functions
# simple test of all group functions
#
#
--
disable_warnings
drop
table
if
exists
t1
,
t2
,
t3
,
t4
,
t5
,
t6
;
--
enable_warnings
set
@
sav_dpi
=
@@
div_precision_increment
;
set
@
sav_dpi
=
@@
div_precision_increment
;
set
div_precision_increment
=
5
;
set
div_precision_increment
=
5
;
show
variables
like
'div_precision_increment'
;
show
variables
like
'div_precision_increment'
;
...
@@ -1800,6 +1796,14 @@ select * from v1;
...
@@ -1800,6 +1796,14 @@ select * from v1;
drop
view
v1
;
drop
view
v1
;
drop
table
t1
;
drop
table
t1
;
--
echo
#
--
echo
# MDEV-29988: Major performance regression with 10.6.11
--
echo
#
create
table
t1
(
a
varchar
(
10
)
charset
utf8mb4
,
b
int
,
c
int
);
insert
t1
values
(
1
,
2
,
3
),(
4
,
5
,
6
),(
1
,
7
,
8
);
select
concat
(
a
,
":"
,
group_concat
(
b
))
from
t1
group
by
a
;
drop
table
t1
;
--
echo
#
--
echo
#
--
echo
# End of 10.3 tests
--
echo
# End of 10.3 tests
--
echo
#
--
echo
#
sql/item.h
View file @
21223c04
...
@@ -6976,6 +6976,11 @@ class Item_direct_ref_to_item : public Item_direct_ref
...
@@ -6976,6 +6976,11 @@ class Item_direct_ref_to_item : public Item_direct_ref
bool
is_expensive
()
{
return
m_item
->
is_expensive
();
}
bool
is_expensive
()
{
return
m_item
->
is_expensive
();
}
Item
*
build_clone
(
THD
*
thd
)
{
return
get_copy
(
thd
);
}
Item
*
build_clone
(
THD
*
thd
)
{
return
get_copy
(
thd
);
}
void
split_sum_func
(
THD
*
thd
,
Ref_ptr_array
ref_pointer_array
,
List
<
Item
>
&
fields
,
uint
flags
)
{
m_item
->
split_sum_func
(
thd
,
ref_pointer_array
,
fields
,
flags
);
}
/*
/*
This processor states that this is safe for virtual columns
This processor states that this is safe for virtual columns
(because this Item transparency)
(because this Item transparency)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment