Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
52be05be
Commit
52be05be
authored
Jun 01, 2022
by
Hirokazu Hata
Committed by
GitHub
Jun 01, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-27926 Deprecate spider_init_sql_alloc_size
Reviewed by: Nayuta Yanagisawa
parent
61727fa4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
27 additions
and
1 deletion
+27
-1
storage/spider/mysql-test/spider/r/variable_deprecation.result
...ge/spider/mysql-test/spider/r/variable_deprecation.result
+15
-0
storage/spider/mysql-test/spider/t/variable_deprecation.test
storage/spider/mysql-test/spider/t/variable_deprecation.test
+9
-0
storage/spider/spd_param.cc
storage/spider/spd_param.cc
+1
-1
storage/spider/spd_table.cc
storage/spider/spd_table.cc
+2
-0
No files found.
storage/spider/mysql-test/spider/r/variable_deprecation.result
View file @
52be05be
...
...
@@ -196,6 +196,21 @@ Warnings:
Warning 1287 The table parameter 'buffer_size' is deprecated and will be removed in a future release
DROP TABLE tbl_a;
DROP TABLE tbl_b;
# MDEV-27926 Deprecate spider_init_sql_alloc_size
SET spider_init_sql_alloc_size = 1;
Warnings:
Warning 1287 '@@spider_init_sql_alloc_size' is deprecated and will be removed in a future release
SHOW VARIABLES LIKE "spider_init_sql_alloc_size";
Variable_name Value
spider_init_sql_alloc_size 1
CREATE TABLE tbl_a (a INT) ENGINE=Spider COMMENT='isa "1"';
Warnings:
Warning 1287 The table parameter 'isa' is deprecated and will be removed in a future release
CREATE TABLE tbl_b (a INT) ENGINE=Spider COMMENT='init_sql_alloc_size "1"';
Warnings:
Warning 1287 The table parameter 'init_sql_alloc_size' is deprecated and will be removed in a future release
DROP TABLE tbl_a;
DROP TABLE tbl_b;
DROP DATABASE auto_test_local;
for master_1
for child2
...
...
storage/spider/mysql-test/spider/t/variable_deprecation.test
View file @
52be05be
...
...
@@ -117,6 +117,15 @@ eval CREATE TABLE tbl_b (a INT) $MASTER_1_ENGINE COMMENT='buffer_size "1"';
DROP
TABLE
tbl_a
;
DROP
TABLE
tbl_b
;
--
echo
# MDEV-27926 Deprecate spider_init_sql_alloc_size
SET
spider_init_sql_alloc_size
=
1
;
SHOW
VARIABLES
LIKE
"spider_init_sql_alloc_size"
;
eval
CREATE
TABLE
tbl_a
(
a
INT
)
$MASTER_1_ENGINE
COMMENT
=
'isa "1"'
;
eval
CREATE
TABLE
tbl_b
(
a
INT
)
$MASTER_1_ENGINE
COMMENT
=
'init_sql_alloc_size "1"'
;
DROP
TABLE
tbl_a
;
DROP
TABLE
tbl_b
;
DROP
DATABASE
auto_test_local
;
--
disable_query_log
...
...
storage/spider/spd_param.cc
View file @
52be05be
...
...
@@ -596,7 +596,7 @@ longlong spider_param_semi_split_read_limit(
*/
static
MYSQL_THDVAR_INT
(
init_sql_alloc_size
,
/* name */
PLUGIN_VAR_RQCMDARG
,
/* opt */
PLUGIN_VAR_RQCMDARG
|
PLUGIN_VAR_DEPRECATED
,
/* opt */
"Initial sql string alloc size"
,
/* comment */
NULL
,
/* check */
spider_use_table_value_deprecated
,
/* update */
...
...
storage/spider/spd_table.cc
View file @
52be05be
...
...
@@ -2377,6 +2377,7 @@ int spider_parse_connect_info(
"hwr"
,
hs_write_to_reads
,
0
,
1
);
SPIDER_PARAM_STR_LIST
(
"hws"
,
hs_write_socks
);
#endif
SPIDER_PARAM_DEPRECATED_WARNING
(
"isa"
);
SPIDER_PARAM_INT
(
"isa"
,
init_sql_alloc_size
,
0
);
SPIDER_PARAM_INT_WITH_MAX
(
"idl"
,
internal_delayed
,
0
,
1
);
SPIDER_PARAM_DEPRECATED_WARNING
(
"ilm"
);
...
...
@@ -2682,6 +2683,7 @@ int spider_parse_connect_info(
error_num
=
connect_string_parse
.
print_param_error
();
goto
error
;
case
19
:
SPIDER_PARAM_DEPRECATED_WARNING
(
"init_sql_alloc_size"
);
SPIDER_PARAM_INT
(
"init_sql_alloc_size"
,
init_sql_alloc_size
,
0
);
SPIDER_PARAM_INT_WITH_MAX
(
"auto_increment_mode"
,
auto_increment_mode
,
0
,
3
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment