Commit 5697b755 authored by marko's avatar marko

branches/zip: Pass the caller's file name and line number to

row_mysql_lock_data_dictionary(), row_mysql_freeze_data_dictionary(),
to better track down locking issues that involve dict_operation_lock.
parent 0cb2a737
...@@ -302,31 +302,39 @@ Locks the data dictionary exclusively for performing a table create or other ...@@ -302,31 +302,39 @@ Locks the data dictionary exclusively for performing a table create or other
data dictionary modification operation. */ data dictionary modification operation. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_lock_data_dictionary( row_mysql_lock_data_dictionary_func(
/*===========================*/ /*================================*/
trx_t* trx); /* in: transaction */ trx_t* trx, /* in/out: transaction */
const char* file, /* in: file name */
ulint line); /* in: line number */
#define row_mysql_lock_data_dictionary(trx) \
row_mysql_lock_data_dictionary_func(trx, __FILE__, __LINE__)
/************************************************************************* /*************************************************************************
Unlocks the data dictionary exclusive lock. */ Unlocks the data dictionary exclusive lock. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_unlock_data_dictionary( row_mysql_unlock_data_dictionary(
/*=============================*/ /*=============================*/
trx_t* trx); /* in: transaction */ trx_t* trx); /* in/out: transaction */
/************************************************************************* /*************************************************************************
Locks the data dictionary in shared mode from modifications, for performing Locks the data dictionary in shared mode from modifications, for performing
foreign key check, rollback, or other operation invisible to MySQL. */ foreign key check, rollback, or other operation invisible to MySQL. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_freeze_data_dictionary( row_mysql_freeze_data_dictionary_func(
/*=============================*/ /*==================================*/
trx_t* trx); /* in: transaction */ trx_t* trx, /* in/out: transaction */
const char* file, /* in: file name */
ulint line); /* in: line number */
#define row_mysql_freeze_data_dictionary(trx) \
row_mysql_freeze_data_dictionary_func(trx, __FILE__, __LINE__)
/************************************************************************* /*************************************************************************
Unlocks the data dictionary shared lock. */ Unlocks the data dictionary shared lock. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_unfreeze_data_dictionary( row_mysql_unfreeze_data_dictionary(
/*===============================*/ /*===============================*/
trx_t* trx); /* in: transaction */ trx_t* trx); /* in/out: transaction */
#ifndef UNIV_HOTBACKUP #ifndef UNIV_HOTBACKUP
/************************************************************************* /*************************************************************************
Creates a table for MySQL. If the name of the table ends in Creates a table for MySQL. If the name of the table ends in
......
...@@ -1634,13 +1634,15 @@ Locks the data dictionary in shared mode from modifications, for performing ...@@ -1634,13 +1634,15 @@ Locks the data dictionary in shared mode from modifications, for performing
foreign key check, rollback, or other operation invisible to MySQL. */ foreign key check, rollback, or other operation invisible to MySQL. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_freeze_data_dictionary( row_mysql_freeze_data_dictionary_func(
/*=============================*/ /*==================================*/
trx_t* trx) /* in: transaction */ trx_t* trx, /* in/out: transaction */
const char* file, /* in: file name */
ulint line) /* in: line number */
{ {
ut_a(trx->dict_operation_lock_mode == 0); ut_a(trx->dict_operation_lock_mode == 0);
rw_lock_s_lock(&dict_operation_lock); rw_lock_s_lock_func(&dict_operation_lock, 0, file, line);
trx->dict_operation_lock_mode = RW_S_LATCH; trx->dict_operation_lock_mode = RW_S_LATCH;
} }
...@@ -1651,7 +1653,7 @@ UNIV_INTERN ...@@ -1651,7 +1653,7 @@ UNIV_INTERN
void void
row_mysql_unfreeze_data_dictionary( row_mysql_unfreeze_data_dictionary(
/*===============================*/ /*===============================*/
trx_t* trx) /* in: transaction */ trx_t* trx) /* in/out: transaction */
{ {
ut_a(trx->dict_operation_lock_mode == RW_S_LATCH); ut_a(trx->dict_operation_lock_mode == RW_S_LATCH);
...@@ -1665,9 +1667,11 @@ Locks the data dictionary exclusively for performing a table create or other ...@@ -1665,9 +1667,11 @@ Locks the data dictionary exclusively for performing a table create or other
data dictionary modification operation. */ data dictionary modification operation. */
UNIV_INTERN UNIV_INTERN
void void
row_mysql_lock_data_dictionary( row_mysql_lock_data_dictionary_func(
/*===========================*/ /*================================*/
trx_t* trx) /* in: transaction */ trx_t* trx, /* in/out: transaction */
const char* file, /* in: file name */
ulint line) /* in: line number */
{ {
ut_a(trx->dict_operation_lock_mode == 0 ut_a(trx->dict_operation_lock_mode == 0
|| trx->dict_operation_lock_mode == RW_X_LATCH); || trx->dict_operation_lock_mode == RW_X_LATCH);
...@@ -1675,7 +1679,7 @@ row_mysql_lock_data_dictionary( ...@@ -1675,7 +1679,7 @@ row_mysql_lock_data_dictionary(
/* Serialize data dictionary operations with dictionary mutex: /* Serialize data dictionary operations with dictionary mutex:
no deadlocks or lock waits can occur then in these operations */ no deadlocks or lock waits can occur then in these operations */
rw_lock_x_lock(&dict_operation_lock); rw_lock_x_lock_func(&dict_operation_lock, 0, file, line);
trx->dict_operation_lock_mode = RW_X_LATCH; trx->dict_operation_lock_mode = RW_X_LATCH;
mutex_enter(&(dict_sys->mutex)); mutex_enter(&(dict_sys->mutex));
...@@ -1687,7 +1691,7 @@ UNIV_INTERN ...@@ -1687,7 +1691,7 @@ UNIV_INTERN
void void
row_mysql_unlock_data_dictionary( row_mysql_unlock_data_dictionary(
/*=============================*/ /*=============================*/
trx_t* trx) /* in: transaction */ trx_t* trx) /* in/out: transaction */
{ {
ut_a(trx->dict_operation_lock_mode == RW_X_LATCH); ut_a(trx->dict_operation_lock_mode == RW_X_LATCH);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment