Commit 5c4c1844 authored by Daniele Sciascia's avatar Daniele Sciascia Committed by Julius Goryavsky

MDEV-32781 galera_bf_lock_wait test failed

This test happens to fail if it runs after test
galera_inject_bf_long_wait.
And the reason is that galera_bf_lock_wait greps for message
"BF lock wait long" in the error log, and expects that grep matches
no lines. Whereas galera_inject_bf_long_wait intentionally causes the
message to appear in the log. The fix consists in using
assert_grep.inc with option assert_only_after, such that
galera_bf_lock_wait is limited to grep only those lines that appeared
in the log after it started to execute.
Signed-off-by: default avatarJulius Goryavsky <julius.goryavsky@mariadb.com>
parent 6d9c9d92
...@@ -20,7 +20,6 @@ versioning_trx_id : MDEV-18590 : galera.versioning_trx_id: Test failure: mysqlte ...@@ -20,7 +20,6 @@ versioning_trx_id : MDEV-18590 : galera.versioning_trx_id: Test failure: mysqlte
galera_concurrent_ctas : MDEV-32779 galera_concurrent_ctas: assertion in the galera::ReplicatorSMM::finish_cert() galera_concurrent_ctas : MDEV-32779 galera_concurrent_ctas: assertion in the galera::ReplicatorSMM::finish_cert()
galera_as_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback() galera_as_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback()
galera_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback() galera_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback()
galera_bf_lock_wait : MDEV-32781 galera_bf_lock_wait test failed
galera_sst_mysqldump_with_key : MDEV-32782 galera_sst_mysqldump_with_key test failed galera_sst_mysqldump_with_key : MDEV-32782 galera_sst_mysqldump_with_key test failed
mdev-31285 : MDEV-25089 Assertion `error.len > 0' failed in galera::ReplicatorSMM::handle_apply_error() mdev-31285 : MDEV-25089 Assertion `error.len > 0' failed in galera::ReplicatorSMM::handle_apply_error()
galera_var_ignore_apply_errors : MENT-1997 galera_var_ignore_apply_errors test freezes galera_var_ignore_apply_errors : MENT-1997 galera_var_ignore_apply_errors test freezes
......
...@@ -33,6 +33,26 @@ SET SESSION wsrep_sync_wait=0; ...@@ -33,6 +33,26 @@ SET SESSION wsrep_sync_wait=0;
call p1(1000); call p1(1000);
connection node_1; connection node_1;
checking error log for 'BF lock wait long' message for 10 times every 10 seconds ... checking error log for 'BF lock wait long' message for 10 times every 10 seconds ...
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
include/assert_grep.inc [BF lock wait long]
connection node_1_p1; connection node_1_p1;
connection node_1_p2; connection node_1_p2;
connection node_2_p1; connection node_2_p1;
......
...@@ -52,6 +52,12 @@ let $counter=10; ...@@ -52,6 +52,12 @@ let $counter=10;
let $sleep_period=10; let $sleep_period=10;
echo checking error log for 'BF lock wait long' message for $counter times every $sleep_period seconds ...; echo checking error log for 'BF lock wait long' message for $counter times every $sleep_period seconds ...;
--let assert_text= BF lock wait long
--let assert_select= BF lock wait long
--let assert_count= 0
--let assert_only_after= CURRENT_TEST: galera.galera_bf_lock_wait
while($counter > 0) while($counter > 0)
{ {
--disable_query_log --disable_query_log
...@@ -60,9 +66,11 @@ while($counter > 0) ...@@ -60,9 +66,11 @@ while($counter > 0)
--enable_query_log --enable_query_log
--enable_result_log --enable_result_log
# use error 0,1 instead if want test to continue --let assert_file= $MYSQLTEST_VARDIR/log/mysqld.1.err
--error 1 --source include/assert_grep.inc
exec grep 'BF lock wait long' $MYSQLTEST_VARDIR/log/mysqld.*.err;
--let assert_file= $MYSQLTEST_VARDIR/log/mysqld.2.err
--source include/assert_grep.inc
dec $counter; dec $counter;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment