Commit 6377f605 authored by marko's avatar marko

branches/zip: buf_page_get_gen(): Obey recv_no_ibuf_operations

and do not call ibuf_merge_or_delete_for_page() in crash recovery,
before the redo log has been applied.
This could cure some hard-to-repeat, hard-to-explain bugs
related to secondary indexes.

A possible recipe to repeat the bug:

1. update a secondary index leaf page on a compressed table
2. evict the page from the buffer pool while it is still dirty
3. ibuf_insert() something for the page
4. crash
5. crash recovery; ibuf merge would be done too early,
before applying redo log to the sec index page or the ibuf pages
parent 996e2ff9
2010-01-21 The InnoDB Team
* buf/buf0buf.c:
Do not merge buffered inserts to compressed pages before
the redo log has been applied in crash recovery.
2010-01-13 The InnoDB Team 2010-01-13 The InnoDB Team
* row/row0sel.c: * row/row0sel.c:
......
...@@ -2239,7 +2239,7 @@ buf_page_get_gen( ...@@ -2239,7 +2239,7 @@ buf_page_get_gen(
while not holding buf_pool_mutex or block->mutex. */ while not holding buf_pool_mutex or block->mutex. */
success = buf_zip_decompress(block, srv_use_checksums); success = buf_zip_decompress(block, srv_use_checksums);
if (UNIV_LIKELY(success)) { if (UNIV_LIKELY(success && !recv_no_ibuf_operations)) {
ibuf_merge_or_delete_for_page(block, space, offset, ibuf_merge_or_delete_for_page(block, space, offset,
zip_size, TRUE); zip_size, TRUE);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment