Commit 71154d32 authored by Sergey Glukhov's avatar Sergey Glukhov

Bug#40104 regression with table names?

On Winodws FN_DEVCHAR is ':' symbol.
There is a check in mysql_create_table_no_lock() func
on FN_DEVCHAR presence but this code is obsolete and
unnecessary. So the fix is to remove unnecessary code.


mysql-test/r/create.result:
  test result
mysql-test/t/create.test:
  test case
sql/sql_table.cc:
  On Winodws FN_DEVCHAR is ':' symbol.
  There is a check in mysql_create_table_no_lock() func
  on FN_DEVCHAR presence but this code is obsolete and
  unnecessary. So the fix is to remove unnecessary code.
parent f1bcbf16
...@@ -1890,5 +1890,7 @@ c1 c2 ...@@ -1890,5 +1890,7 @@ c1 c2
DROP TABLE t1; DROP TABLE t1;
# -- End of Bug#34274 # -- End of Bug#34274
create table `me:i`(id int);
drop table `me:i`;
End of 5.1 tests End of 5.1 tests
...@@ -1532,5 +1532,11 @@ DROP TABLE t1; ...@@ -1532,5 +1532,11 @@ DROP TABLE t1;
########################################################################### ###########################################################################
#
# Bug#40104 regression with table names?
#
create table `me:i`(id int);
drop table `me:i`;
--echo --echo
--echo End of 5.1 tests --echo End of 5.1 tests
...@@ -3427,14 +3427,6 @@ bool mysql_create_table_no_lock(THD *thd, ...@@ -3427,14 +3427,6 @@ bool mysql_create_table_no_lock(THD *thd,
} }
else else
{ {
#ifdef FN_DEVCHAR
/* check if the table name contains FN_DEVCHAR when defined */
if (strchr(alias, FN_DEVCHAR))
{
my_error(ER_WRONG_TABLE_NAME, MYF(0), alias);
DBUG_RETURN(TRUE);
}
#endif
path_length= build_table_filename(path, sizeof(path), db, alias, reg_ext, path_length= build_table_filename(path, sizeof(path), db, alias, reg_ext,
internal_tmp_table ? FN_IS_TMP : 0); internal_tmp_table ? FN_IS_TMP : 0);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment