MDEV-27169 Change default values of Spider plugin variables to default values of table variables

Some Spider table options introduces an unnecessary complication to
Spider settings. For example, the default value of the plugin variable
spider_auto_increment_mode is -1 (use table value) and the default
table option value is 0 (normal mode). Thus, the virtual default value
of the variable is 0. This kind of indirection is confusing.

In order to delete such confusing table options in a future release,
we first change the default values of some Spider plugin variables
from -1 (use table value) to the corresponding default table values.
The default table values are defined in spider_set_connect_info_default().

At the same time, we also deprecate the option value -1 (use table value).

storage/spider/mysql-test/spider/bg/r/spider3_fixes.result

@@ -36,6 +36,10 @@ SELECT 1;
 3.1
 auto_increment
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1, t2;
@@ -190,6 +194,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t2;
 MAX(id)
 10000
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id

storage/spider/mysql-test/spider/bg/r/spider3_fixes_part.result

@@ -34,6 +34,10 @@ SELECT 1;
 1
 auto_increment with partition
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1, t2;
@@ -188,6 +192,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t2;
 MAX(id)
 10000
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id

storage/spider/mysql-test/spider/bg/r/spider_fixes.result

@@ -413,6 +413,10 @@ connection master_1;
 
 read only
 connection master_1;
+SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+SET SESSION spider_read_only_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -441,10 +445,19 @@ DELETE FROM t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
 TRUNCATE t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
+SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 
 2.27
 error mode
 connection master_1;
+SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+SET SESSION spider_error_read_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
+SET SESSION spider_error_write_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -466,6 +479,8 @@ Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
 TRUNCATE t1;
 Warnings:
 Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
+SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 
 3.0
 is null

storage/spider/mysql-test/spider/bg/t/spider3_fixes.test

@@ -97,6 +97,8 @@ if ($USE_CHILD_GROUP2)
   }
 }
 --connection master_1
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
 if ($USE_REPLICATION)
 {
   save_master_pos;
@@ -222,6 +224,7 @@ SELECT MAX(id) FROM t1;
 INSERT INTO t2 (id) VALUES (1000);
 SELECT LAST_INSERT_ID();
 SELECT MAX(id) FROM t2;
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 if ($USE_REPLICATION)
 {
   save_master_pos;

storage/spider/mysql-test/spider/bg/t/spider3_fixes_part.test

@@ -131,6 +131,8 @@ if ($HAVE_PARTITION)
     }
   }
   --connection master_1
+  SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+  SET SESSION spider_auto_increment_mode = -1;
   if ($USE_REPLICATION)
   {
     save_master_pos;
@@ -256,6 +258,7 @@ if ($HAVE_PARTITION)
   INSERT INTO t2 (id) VALUES (1000);
   SELECT LAST_INSERT_ID();
   SELECT MAX(id) FROM t2;
+  SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
   if ($USE_REPLICATION)
   {
     save_master_pos;

storage/spider/mysql-test/spider/bg/t/spider_fixes.test

@@ -1172,6 +1172,8 @@ let $MASTER_1_ENGINE_IS_SPIDER=
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+  SET SESSION spider_read_only_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1197,6 +1199,7 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   DELETE FROM t1;
   --error 12518
   TRUNCATE t1;
+  SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {
@@ -1210,6 +1213,10 @@ if (!$MASTER_1_ENGINE_IS_SPIDER)
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+  SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+  SET SESSION spider_error_read_mode = -1;
+  SET SESSION spider_error_write_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1227,6 +1234,8 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   INSERT INTO t1 (id) VALUES (1);
   DELETE FROM t1;
   TRUNCATE t1;
+  SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+  SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {

storage/spider/mysql-test/spider/handler/r/spider3_fixes.result

@@ -36,6 +36,10 @@ SELECT 1;
 3.1
 auto_increment
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1, t2;
@@ -206,6 +210,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t2;
 MAX(id)
 46
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id

storage/spider/mysql-test/spider/handler/r/spider3_fixes_part.result

@@ -34,6 +34,10 @@ SELECT 1;
 1
 auto_increment with partition
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1, t2;
@@ -204,6 +208,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t2;
 MAX(id)
 26
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id

storage/spider/mysql-test/spider/handler/r/spider_fixes.result

@@ -306,6 +306,10 @@ UNLOCK TABLES;
 
 auto_increment
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1;
@@ -399,6 +403,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t1;
 MAX(id)
 42
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id
@@ -417,6 +422,10 @@ connection master_1;
 
 read only
 connection master_1;
+SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+SET SESSION spider_read_only_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -445,10 +454,19 @@ DELETE FROM t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
 TRUNCATE t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
+SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 
 2.27
 error mode
 connection master_1;
+SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+SET SESSION spider_error_read_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
+SET SESSION spider_error_write_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -470,6 +488,8 @@ Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
 TRUNCATE t1;
 Warnings:
 Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
+SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 
 3.0
 is null

storage/spider/mysql-test/spider/handler/r/spider_fixes_part.result

@@ -109,6 +109,10 @@ a	b	c
 2.26
 auto_increment with partition
 connection master_1;
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 connection slave1_1;
 connection master_1;
 DROP TABLE IF EXISTS t1;
@@ -202,6 +206,7 @@ LAST_INSERT_ID()
 SELECT MAX(id) FROM t1;
 MAX(id)
 26
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 connection slave1_1;
 SELECT id FROM t1 ORDER BY id;
 id

storage/spider/mysql-test/spider/handler/t/spider3_fixes.test

@@ -97,6 +97,8 @@ if ($USE_CHILD_GROUP2)
   }
 }
 --connection master_1
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
 if ($USE_REPLICATION)
 {
   save_master_pos;
@@ -222,6 +224,7 @@ SELECT MAX(id) FROM t1;
 INSERT INTO t2 (id) VALUES (1000);
 SELECT LAST_INSERT_ID();
 SELECT MAX(id) FROM t2;
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 if ($USE_REPLICATION)
 {
   save_master_pos;

storage/spider/mysql-test/spider/handler/t/spider3_fixes_part.test

@@ -131,6 +131,8 @@ if ($HAVE_PARTITION)
     }
   }
   --connection master_1
+  SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+  SET SESSION spider_auto_increment_mode = -1;
   if ($USE_REPLICATION)
   {
     save_master_pos;
@@ -256,6 +258,7 @@ if ($HAVE_PARTITION)
   INSERT INTO t2 (id) VALUES (1000);
   SELECT LAST_INSERT_ID();
   SELECT MAX(id) FROM t2;
+  SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
   if ($USE_REPLICATION)
   {
     save_master_pos;

storage/spider/mysql-test/spider/handler/t/spider_fixes.test

@@ -1049,6 +1049,8 @@ if ($USE_CHILD_GROUP2)
   }
 }
 --connection master_1
+SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+SET SESSION spider_auto_increment_mode = -1;
 if ($USE_REPLICATION)
 {
   save_master_pos;
@@ -1120,6 +1122,7 @@ SELECT MAX(id) FROM t1;
 INSERT INTO t1 (id) VALUES (1000);
 SELECT LAST_INSERT_ID();
 SELECT MAX(id) FROM t1;
+SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
 if ($USE_REPLICATION)
 {
   save_master_pos;
@@ -1172,6 +1175,8 @@ let $MASTER_1_ENGINE_IS_SPIDER=
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+  SET SESSION spider_read_only_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1197,6 +1202,7 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   DELETE FROM t1;
   --error 12518
   TRUNCATE t1;
+  SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {
@@ -1210,6 +1216,10 @@ if (!$MASTER_1_ENGINE_IS_SPIDER)
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+  SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+  SET SESSION spider_error_read_mode = -1;
+  SET SESSION spider_error_write_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1227,6 +1237,8 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   INSERT INTO t1 (id) VALUES (1);
   DELETE FROM t1;
   TRUNCATE t1;
+  SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+  SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {

storage/spider/mysql-test/spider/handler/t/spider_fixes_part.test

@@ -485,6 +485,8 @@ if ($HAVE_PARTITION)
     }
   }
   --connection master_1
+  SET @original_spider_auto_increment_mode = @@SESSION.spider_auto_increment_mode;
+  SET SESSION spider_auto_increment_mode = -1;
   if ($USE_REPLICATION)
   {
     save_master_pos;
@@ -556,6 +558,7 @@ if ($HAVE_PARTITION)
   INSERT INTO t1 (id) VALUES (1000);
   SELECT LAST_INSERT_ID();
   SELECT MAX(id) FROM t1;
+  SET SESSION spider_auto_increment_mode = @original_spider_auto_increment_mode;
   if ($USE_REPLICATION)
   {
     save_master_pos;

storage/spider/mysql-test/spider/r/spider_fixes.result

@@ -413,6 +413,10 @@ connection master_1;
 
 read only
 connection master_1;
+SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+SET SESSION spider_read_only_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -441,10 +445,19 @@ DELETE FROM t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
 TRUNCATE t1;
 ERROR HY000: Table 'auto_test_local.t1' is read only
+SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 
 2.27
 error mode
 connection master_1;
+SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+SET SESSION spider_error_read_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
+SET SESSION spider_error_write_mode = -1;
+Warnings:
+Warning	138	The option value -1 (use table value) is deprecated and will be removed in a future release
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (
 id int(11) NOT NULL,
@@ -466,6 +479,8 @@ Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
 TRUNCATE t1;
 Warnings:
 Error	1146	Table 'auto_test_remote.ter1_1' doesn't exist
+SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 
 3.0
 is null

storage/spider/mysql-test/spider/t/spider_fixes.test

@@ -1172,6 +1172,8 @@ let $MASTER_1_ENGINE_IS_SPIDER=
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_read_only_mode = @@SESSION.spider_read_only_mode;
+  SET SESSION spider_read_only_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1197,6 +1199,7 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   DELETE FROM t1;
   --error 12518
   TRUNCATE t1;
+  SET SESSION spider_read_only_mode = @original_spider_read_only_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {
@@ -1210,6 +1213,10 @@ if (!$MASTER_1_ENGINE_IS_SPIDER)
 if ($MASTER_1_ENGINE_IS_SPIDER)
 {
   --connection master_1
+  SET @original_spider_error_read_mode = @@SESSION.spider_error_read_mode;
+  SET @original_spider_error_write_mode = @@SESSION.spider_error_write_mode;
+  SET SESSION spider_error_read_mode = -1;
+  SET SESSION spider_error_write_mode = -1;
   --disable_warnings
   DROP TABLE IF EXISTS t1;
   --enable_warnings
@@ -1227,6 +1234,8 @@ if ($MASTER_1_ENGINE_IS_SPIDER)
   INSERT INTO t1 (id) VALUES (1);
   DELETE FROM t1;
   TRUNCATE t1;
+  SET SESSION spider_error_read_mode = @original_spider_error_read_mode;
+  SET SESSION spider_error_write_mode = @original_spider_error_write_mode;
 }
 if (!$MASTER_1_ENGINE_IS_SPIDER)
 {