MDEV-28364 Spider: remove #ifdef SPIDER_HAS_EXPR_CACHE_ITEM

storage/spider/spd_db_conn.cc

@@ -7935,9 +7935,7 @@ int spider_db_print_item_type(
         field, spider, str, alias, alias_length, dbton_id, use_fields, fields));
     case Item::SUBSELECT_ITEM:
     case Item::TRIGGER_FIELD_ITEM:
-#ifdef SPIDER_HAS_EXPR_CACHE_ITEM
     case Item::EXPR_CACHE_ITEM:
-#endif
       DBUG_RETURN(ER_SPIDER_COND_SKIP_NUM);
     default:
       DBUG_RETURN(spider_db_print_item_type_default(item, spider, str));

storage/spider/spd_db_include.h

@@ -33,7 +33,6 @@
 #define SPIDER_HAS_APPEND_FOR_SINGLE_QUOTE
 #define SPIDER_HAS_SHOW_SIMPLE_FUNC
 #define SPIDER_HAS_JT_HASH_INDEX_MERGE
-#define SPIDER_HAS_EXPR_CACHE_ITEM
 #define SPIDER_HAS_TIME_STATUS
 #define SPIDER_HAS_DECIMAL_OPERATION_RESULTS_VALUE_TYPE
 #define SPIDER_ITEM_STRING_WITHOUT_SET_STR_WITH_COPY

storage/spider/spd_db_mysql.cc

@@ -6387,15 +6387,12 @@ int spider_db_mbase_util::open_item_func(
           bool has_other_item = FALSE;
           while((item = lif++))
           {
-#ifdef SPIDER_HAS_EXPR_CACHE_ITEM
             if (
               item->type() == Item::EXPR_CACHE_ITEM
             ) {
               DBUG_PRINT("info",("spider EXPR_CACHE_ITEM"));
               has_expr_cache_item = TRUE;
-            } else
-#endif
-            if (
+            } else if (
               item->type() == Item::FUNC_ITEM &&
               ((Item_func *) item)->functype() == Item_func::ISNOTNULL_FUNC
             ) {