Commit a0187c8a authored by unknown's avatar unknown

Cleanups during review


ndb/src/ndbapi/DictCache.cpp:
  Simpler bit handling code
sql/sql_acl.cc:
  Fix for bool parameter
sql/sql_yacc.yy:
  Removed compiler warning
parent dbb332d8
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
Ndb_local_table_info * Ndb_local_table_info *
Ndb_local_table_info::create(NdbTableImpl *table_impl, Uint32 sz) Ndb_local_table_info::create(NdbTableImpl *table_impl, Uint32 sz)
{ {
Uint32 tot_size= sizeof(NdbTableImpl *) + ((sz+7)>>3)<<3; // round to Uint64 Uint32 tot_size= sizeof(NdbTableImpl *) + ((sz+7) & ~7); // round to Uint64
void *data= malloc(tot_size); void *data= malloc(tot_size);
if (data == 0) if (data == 0)
return 0; return 0;
......
...@@ -2729,7 +2729,8 @@ bool mysql_table_grant(THD *thd, TABLE_LIST *table_list, ...@@ -2729,7 +2729,8 @@ bool mysql_table_grant(THD *thd, TABLE_LIST *table_list,
pthread_mutex_lock(&acl_cache->lock); pthread_mutex_lock(&acl_cache->lock);
error=replace_user_table(thd, tables[0].table, *Str, error=replace_user_table(thd, tables[0].table, *Str,
0, revoke_grant, create_new_users, 0, revoke_grant, create_new_users,
thd->variables.sql_mode & MODE_NO_AUTO_CREATE_USER); test(thd->variables.sql_mode &
MODE_NO_AUTO_CREATE_USER));
pthread_mutex_unlock(&acl_cache->lock); pthread_mutex_unlock(&acl_cache->lock);
if (error) if (error)
{ {
...@@ -2935,7 +2936,8 @@ bool mysql_procedure_grant(THD *thd, TABLE_LIST *table_list, ...@@ -2935,7 +2936,8 @@ bool mysql_procedure_grant(THD *thd, TABLE_LIST *table_list,
pthread_mutex_lock(&acl_cache->lock); pthread_mutex_lock(&acl_cache->lock);
error=replace_user_table(thd, tables[0].table, *Str, error=replace_user_table(thd, tables[0].table, *Str,
0, revoke_grant, create_new_users, 0, revoke_grant, create_new_users,
thd->variables.sql_mode & MODE_NO_AUTO_CREATE_USER); test(thd->variables.sql_mode &
MODE_NO_AUTO_CREATE_USER));
pthread_mutex_unlock(&acl_cache->lock); pthread_mutex_unlock(&acl_cache->lock);
if (error) if (error)
{ {
...@@ -3061,7 +3063,8 @@ bool mysql_grant(THD *thd, const char *db, List <LEX_USER> &list, ...@@ -3061,7 +3063,8 @@ bool mysql_grant(THD *thd, const char *db, List <LEX_USER> &list,
} }
if (replace_user_table(thd, tables[0].table, *Str, if (replace_user_table(thd, tables[0].table, *Str,
(!db ? rights : 0), revoke_grant, create_new_users, (!db ? rights : 0), revoke_grant, create_new_users,
thd->variables.sql_mode & MODE_NO_AUTO_CREATE_USER)) test(thd->variables.sql_mode &
MODE_NO_AUTO_CREATE_USER)))
result= -1; result= -1;
else if (db) else if (db)
{ {
......
...@@ -1398,7 +1398,7 @@ create_function_tail: ...@@ -1398,7 +1398,7 @@ create_function_tail:
uint unused1= 0; uint unused1= 0;
int unused2= 0; int unused2= 0;
if (!(new_field= new_create_field(YYTHD, "", if (!(new_field= new_create_field(YYTHD, (char*) "",
(enum enum_field_types)$8, (enum enum_field_types)$8,
lex->length, lex->dec, lex->type, lex->length, lex->dec, lex->type,
(Item *)0, (Item *) 0, &cmt, 0, (Item *)0, (Item *) 0, &cmt, 0,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment