Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
a1f3f1e8
Commit
a1f3f1e8
authored
Oct 16, 2018
by
Marko Mäkelä
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace FIXME comments
parent
ebf73cf7
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
storage/innobase/handler/handler0alter.cc
storage/innobase/handler/handler0alter.cc
+3
-3
No files found.
storage/innobase/handler/handler0alter.cc
View file @
a1f3f1e8
...
...
@@ -1275,7 +1275,7 @@ ha_innobase::check_if_supported_inplace_alter(
|
ALTER_DROP_NON_UNIQUE_NON_PRIM_INDEX
);
if
(
supports_instant
)
{
flags
&=
~
(
ALTER_DROP_STORED_COLUMN
#if 0 /* MDEV-1
5562 FIXME
: remove check_v_col_in_order() and fix the code */
#if 0 /* MDEV-1
7468
: remove check_v_col_in_order() and fix the code */
| ALTER_ADD_STORED_BASE_COLUMN
#endif
|
ALTER_STORED_COLUMN_ORDER
);
...
...
@@ -4165,7 +4165,7 @@ prepare_inplace_add_virtual(
/* No need to track the list */
ctx
->
add_vcol
[
j
].
v_indexes
=
NULL
;
/*
FIXME: This should be done
on ctx->instant_table later */
/*
MDEV-17468: Do this
on ctx->instant_table later */
innodb_base_col_setup
(
ctx
->
old_table
,
field
,
&
ctx
->
add_vcol
[
j
]);
j
++
;
}
...
...
@@ -10355,7 +10355,7 @@ ha_innobase::commit_inplace_alter_table(
}
}
/*
FIXME: Avoid this
when ctx->is_instant().
/*
MDEV-17468: Avoid this at least
when ctx->is_instant().
Currently dict_load_column_low() is the only place where
num_base for virtual columns is assigned to nonzero. */
if
(
ctx0
->
num_to_drop_vcol
||
ctx0
->
num_to_add_vcol
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment