Commit af346225 authored by Zardosht Kasheff's avatar Zardosht Kasheff Committed by Yoni Fogel

[t:4286], add comment on scope of read_extraargs and write_extraargs

git-svn-id: file:///svn/toku/tokudb@37989 c7de825b-a66e-492c-adef-691d508d4ae1
parent 6f13ac84
...@@ -2087,6 +2087,12 @@ int toku_cachetable_get_and_pin ( ...@@ -2087,6 +2087,12 @@ int toku_cachetable_get_and_pin (
void* write_extraargs // parameter for flush_callback, pe_est_callback, pe_callback, and cleaner_callback void* write_extraargs // parameter for flush_callback, pe_est_callback, pe_callback, and cleaner_callback
) )
{ {
// We have separate parameters of read_extraargs and write_extraargs because
// the lifetime of the two parameters are different. write_extraargs may be used
// long after this function call (e.g. after a flush to disk), whereas read_extraargs
// will not be used after this function returns. As a result, the caller may allocate
// read_extraargs on the stack, whereas write_extraargs must be allocated
// on the heap.
return toku_cachetable_get_and_pin_with_dep_pairs ( return toku_cachetable_get_and_pin_with_dep_pairs (
cachefile, cachefile,
key, key,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment