Commit bd47ccfc authored by osku's avatar osku

Do not reset cell->wait_object to NULL when a cell in sync array is freed

since this can lead to problems.
parent c2083023
...@@ -54,9 +54,9 @@ struct sync_cell_struct { ...@@ -54,9 +54,9 @@ struct sync_cell_struct {
enum { SC_FREE, SC_RESERVED, SC_WAKING_UP } state; enum { SC_FREE, SC_RESERVED, SC_WAKING_UP } state;
void* wait_object; /* pointer to the object the void* wait_object; /* pointer to the object the
thread is waiting for; like state, thread is waiting for; this is not
this can change from non-NULL to reseted to NULL when a cell is
NULL without any mutex protection */ freed. */
mutex_t* old_wait_mutex; /* the latest wait mutex in cell */ mutex_t* old_wait_mutex; /* the latest wait mutex in cell */
rw_lock_t* old_wait_rw_lock;/* the latest wait rw-lock in cell */ rw_lock_t* old_wait_rw_lock;/* the latest wait rw-lock in cell */
...@@ -413,7 +413,6 @@ sync_array_free_cell( ...@@ -413,7 +413,6 @@ sync_array_free_cell(
ut_a(cell->wait_object != NULL); ut_a(cell->wait_object != NULL);
cell->state = SC_FREE; cell->state = SC_FREE;
cell->wait_object = NULL;
} }
/********************************************************************** /**********************************************************************
...@@ -443,7 +442,6 @@ sync_array_free_cell_protected( ...@@ -443,7 +442,6 @@ sync_array_free_cell_protected(
} }
cell->state = SC_FREE; cell->state = SC_FREE;
cell->wait_object = NULL;
sync_array_exit(arr); sync_array_exit(arr);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment