Commit e90e5db8 authored by Leif Walsh's avatar Leif Walsh Committed by Yoni Fogel

refs #5537 little cmake cleanup


git-svn-id: file:///svn/toku/tokudb@48383 c7de825b-a66e-492c-adef-691d508d4ae1
parent 64972572
...@@ -128,7 +128,7 @@ if (NOT USE_VALGRIND) ...@@ -128,7 +128,7 @@ if (NOT USE_VALGRIND)
endif () endif ()
## set warnings ## set warnings
set(WARN_FLAGS set_cflags_if_supported(
-Wextra -Wextra
-Wbad-function-cast -Wbad-function-cast
-Wno-missing-noreturn -Wno-missing-noreturn
...@@ -149,18 +149,12 @@ set(WARN_FLAGS ...@@ -149,18 +149,12 @@ set(WARN_FLAGS
#-Wvector-optimization-performance #-Wvector-optimization-performance
) )
option(WARN_ABOUT_PACKED "Warn about useless __attribute__((packed)). This generates lots of warnings." OFF)
if (WARN_ABOUT_PACKED)
list(APPEND WARN_FLAGS -Wpacked -Wno-error=packed)
endif ()
if (CMAKE_CXX_COMPILER_ID STREQUAL Clang) if (CMAKE_CXX_COMPILER_ID STREQUAL Clang)
message(WARNING "Disabling -Wcast-align with clang. TODO: fix casting and re-enable it.") message(WARNING "Disabling -Wcast-align with clang. TODO: fix casting and re-enable it.")
else () else ()
list(APPEND WARN_FLAGS -Wcast-align) set_cflags_if_supported(-Wcast-align)
endif () endif ()
set_cflags_if_supported(${WARN_CFLAGS})
## always want these ## always want these
set(CMAKE_C_FLAGS "-Wall -Werror ${CMAKE_C_FLAGS}") set(CMAKE_C_FLAGS "-Wall -Werror ${CMAKE_C_FLAGS}")
set(CMAKE_CXX_FLAGS "-Wall -Werror ${CMAKE_CXX_FLAGS}") set(CMAKE_CXX_FLAGS "-Wall -Werror ${CMAKE_CXX_FLAGS}")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment