Commit ee8d3334 authored by Michael Widenius's avatar Michael Widenius

Updated comments as part of code review

.bzr-mysql/default.conf:
  5.2 -> 5.3
sql/handler.h:
  Updated comments.
parent 23dbc2a7
[MYSQL] [MYSQL]
tree_location = lp:maria/5.2 tree_location = lp:maria/5.3
post_commit_to = commits@mariadb.org post_commit_to = commits@mariadb.org
post_commit_url = lp:maria/5.2 post_commit_url = lp:maria/5.3
tree_name = maria/5.2 tree_name = maria/5.3
project_name = "Mariadb 5.2, with Maria 2.0" project_name = "Mariadb 5.3, with Aria 2.0"
...@@ -163,7 +163,7 @@ ...@@ -163,7 +163,7 @@
#define HA_DO_INDEX_COND_PUSHDOWN 256 /* Supports Index Condition Pushdown */ #define HA_DO_INDEX_COND_PUSHDOWN 256 /* Supports Index Condition Pushdown */
/* /*
Data is clustered on this key. This means that when you read the key Data is clustered on this key. This means that when you read the key
you also get the row data in the same block. you also get the row data without any additional disk reads.
*/ */
#define HA_CLUSTERED_INDEX 512 #define HA_CLUSTERED_INDEX 512
...@@ -2314,8 +2314,8 @@ class handler :public Sql_alloc ...@@ -2314,8 +2314,8 @@ class handler :public Sql_alloc
/* /*
Check if the primary key (if there is one) is a clustered key covering Check if the primary key (if there is one) is a clustered and a
all fields. This means: reference key. This means:
- Data is stored together with the primary key (no secondary lookup - Data is stored together with the primary key (no secondary lookup
needed to find the row data). The optimizer uses this to find out needed to find the row data). The optimizer uses this to find out
...@@ -2326,7 +2326,13 @@ class handler :public Sql_alloc ...@@ -2326,7 +2326,13 @@ class handler :public Sql_alloc
- When doing a HA_KEYREAD_ONLY we get also all the primary key parts - When doing a HA_KEYREAD_ONLY we get also all the primary key parts
into the row. This is critical property used by index_merge. into the row. This is critical property used by index_merge.
For a clustered primary key, index_flags() returns also HA_CLUSTERED_INDEX All the above is usually true for engines that store the row
data in the primary key index (e.g. in a b-tree), and use the primary
key value as a position(). InnoDB is an example of such an engine.
For such a clustered primary key, the following should also hold:
index_flags() should contain HA_CLUSTERED_INDEX
table_flags() should contain HA_TABLE_SCAN_ON_INDEX
@retval TRUE yes @retval TRUE yes
@retval FALSE No. @retval FALSE No.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment