Commit f638ffef authored by Vicențiu Ciorbaru's avatar Vicențiu Ciorbaru

Convert if statements to switch case.

parent 1cc6fd1f
...@@ -372,5 +372,4 @@ class Item_window_func : public Item_result_field ...@@ -372,5 +372,4 @@ class Item_window_func : public Item_result_field
}; };
#endif /* ITEM_WINDOWFUNC_INCLUDED */ #endif /* ITEM_WINDOWFUNC_INCLUDED */
...@@ -886,28 +886,32 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list) ...@@ -886,28 +886,32 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
item_win->setup_partition_border_check(thd); item_win->setup_partition_border_check(thd);
Item_sum::Sumfunctype type= item_win->window_func->sum_func(); Item_sum::Sumfunctype type= item_win->window_func->sum_func();
if (type == Item_sum::ROW_NUMBER_FUNC || switch (type) {
type == Item_sum::RANK_FUNC || case Item_sum::ROW_NUMBER_FUNC:
type == Item_sum::DENSE_RANK_FUNC) case Item_sum::RANK_FUNC:
{ case Item_sum::DENSE_RANK_FUNC:
/* {
One-pass window function computation, walk through the rows and /*
assign values. One-pass window function computation, walk through the rows and
*/ assign values.
if (compute_window_func_values(item_win, tbl, &info)) */
is_error= true; if (compute_window_func_values(item_win, tbl, &info))
} is_error= true;
else if (type == Item_sum::COUNT_FUNC) break;
{ }
/* case Item_sum::COUNT_FUNC:
Frame-aware window function computation. It does one pass, but {
uses three cursors -frame_top, current_row, and frame_bottom. /*
*/ Frame-aware window function computation. It does one pass, but
if (compute_window_func_with_frames(item_win, tbl, &info)) uses three cursors -frame_start, current_row, and frame_end.
is_error= true; */
if (compute_window_func_with_frames(item_win, tbl, &info))
is_error= true;
break;
}
default:
DBUG_ASSERT(0);
} }
else
DBUG_ASSERT(0);
item_win->set_read_value_from_result_field(); item_win->set_read_value_from_result_field();
/* This calls filesort_free_buffers(): */ /* This calls filesort_free_buffers(): */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment