Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
fa839ece
Commit
fa839ece
authored
Feb 06, 2007
by
unknown
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug #26021 valgrind warning handle_trailing_share/ndbcluster_free_share invalid read
- revert bugfix, needs more work
parent
dd01c46f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
1 deletion
+6
-1
sql/ha_ndbcluster_binlog.cc
sql/ha_ndbcluster_binlog.cc
+6
-1
No files found.
sql/ha_ndbcluster_binlog.cc
View file @
fa839ece
...
@@ -2445,8 +2445,10 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key,
...
@@ -2445,8 +2445,10 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key,
pthread_mutex_unlock
(
&
ndbcluster_mutex
);
pthread_mutex_unlock
(
&
ndbcluster_mutex
);
DBUG_RETURN
(
1
);
DBUG_RETURN
(
1
);
}
}
#ifdef NOT_YET
if
(
share
->
connect_count
!=
if
(
share
->
connect_count
!=
g_ndb_cluster_connection
->
get_connect_count
())
g_ndb_cluster_connection
->
get_connect_count
())
#endif
{
{
handle_trailing_share
(
share
);
handle_trailing_share
(
share
);
share
=
NULL
;
share
=
NULL
;
...
@@ -2454,11 +2456,14 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key,
...
@@ -2454,11 +2456,14 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key,
}
}
/* Create share which is needed to hold replication information */
/* Create share which is needed to hold replication information */
#ifdef NOT_YET
if
(
share
)
if
(
share
)
{
{
++
share
->
use_count
;
++
share
->
use_count
;
}
}
else
if
(
!
(
share
=
get_share
(
key
,
0
,
TRUE
,
TRUE
)))
else
#endif
if
(
!
(
share
=
get_share
(
key
,
0
,
TRUE
,
TRUE
)))
{
{
sql_print_error
(
"NDB Binlog: "
sql_print_error
(
"NDB Binlog: "
"allocating table share for %s failed"
,
key
);
"allocating table share for %s failed"
,
key
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment