An error occurred fetching the project authors.
  1. 12 Feb, 2004 1 commit
    • unknown's avatar
      memory leacks in PS with subqueries fixed (adddition to fix of BUG#2462) · 00392bf8
      unknown authored
      sql/item.h:
        mechanism to keep reference in cache array for row IN
      sql/item_cmpfunc.cc:
        mechanism to keep reference in cache array for row IN
        layout fixed
      sql/item_cmpfunc.h:
        mechanism to keep reference in cache array for row IN
      sql/item_subselect.cc:
        fixed memory pools swapping
        prevented deleting Item_in_optimizer cache in case of row IN subquery
      sql/mysql_priv.h:
        declarations of function moved to be useful in sql_class.h
      sql/sql_base.cc:
        keep fields expanded from '*' in statement memory pool
      sql/sql_class.cc:
        fixed restoring/backup of memory pool and list of items
      sql/sql_class.h:
        memory allocation methods moved to Statement
        memory pool substituting for preparing
      sql/sql_lex.cc:
        ref_pointer_array kept in statement memory
      sql/sql_lex.h:
        reinitialization of UNIT
      sql/sql_prepare.cc:
        memory allocation/swapping fixed
      tests/client_test.c:
        layout fixed
      00392bf8
  2. 08 Feb, 2004 2 commits
    • unknown's avatar
      fixed cleupup() for distinct aggregate functions (BUG#2663) · 977021a4
      unknown authored
      sql/item_sum.cc:
        fixed cleupup() for distinct aggregate functions
      tests/client_test.c:
        fixed subqueries test
        test of distinct aggregate functions in PS
      977021a4
    • unknown's avatar
      fixed subquery with PS (BUG#2462) · d8703464
      unknown authored
      fixed UNION preparation
      
      
      sql/item.cc:
        debug output added
      sql/item.h:
        debug output added
      sql/item_cmpfunc.cc:
        correct cleunup() for Item_in_optimizer
      sql/item_cmpfunc.h:
        correct cleunup() for Item_in_optimizer
        debug output added
      sql/item_func.h:
        debug output added
      sql/item_subselect.cc:
        support of prepared statemnts added - mostly memorry allocation manegement, only one trabsformatio & correct cleupup()
      sql/item_subselect.h:
        support of prepared statemnts added - mostly memorry allocation manegement, only one trabsformatio & correct cleupup()
      sql/item_sum.cc:
        debug output added
      sql/item_sum.h:
        debug output added
      sql/sql_class.cc:
        function to switch allocation arena for Items
      sql/sql_class.h:
        function to switch allocation arena for Items
        pointer on current prepared statement added
      sql/sql_lex.cc:
        comment fixed
      sql/sql_lex.h:
        item cleanup support
      sql/sql_prepare.cc:
        - fixed preparation of PS to avoid storing junk in its memory + correct work with union
        - fixed tables cleanup for UNION & subqueries
      sql/sql_select.cc:
        removed condition which is always true for now
        fixed layout
      sql/sql_union.cc:
        support of UNION subquery cleanup
      tests/client_test.c:
        test of repeatable subqueries
        test of correct UNION initialisation
      d8703464
  3. 19 Dec, 2003 1 commit
    • unknown's avatar
      Prepared_statement deployed instead of PREP_STMT. · 9c6eed72
      unknown authored
      libmysqld/lib_sql.cc:
        Prepared_statement now resides entirely in sql_prepare.cc
        Embedded versions of setup_params_data moved to sql_prepare.cc
      sql/mysql_priv.h:
        removed declarations for non-existing functions
      sql/slave.cc:
        no thd->init_for_queries() any more
      sql/sql_class.cc:
        added Statement and Statement_map classes.
        PREP_STMT replaced with Statement (Prepared_statement) and moved to
        sql_prepare.cc
      sql/sql_class.h:
        added Statement and Statement_map classes.
        PREP_STMT replaced with Statement (Prepared_statement) and moved to
        sql_prepare.cc
      sql/sql_parse.cc:
        thd->init_for_queries() doesn't exist any more
        comment moved to proper place
      sql/sql_prepare.cc:
        PREP_STMT replaced with Prepared_statement
        minor code cleanups
      tests/client_test.c:
        Later in the test we rely on order of rows, which normally is not defined.
        My patch changes the order.
      9c6eed72
  4. 08 Dec, 2003 1 commit
  5. 26 Nov, 2003 3 commits
  6. 25 Nov, 2003 1 commit
    • unknown's avatar
      fix for bug #1946: · 5910d9f0
      unknown authored
      "You can always mysql_real_query a query with placeholders 
      after mysql_prepare()"
      
      
      sql/sql_class.cc:
        prepare_command removed
      sql/sql_class.h:
        prepare_command removed
      sql/sql_prepare.cc:
        prepare_command removed
      sql/sql_yacc.yy:
        prepare_command removed
      tests/client_test.c:
        added test for bug #1946: "You can always
        mysql_real_query a query with placeholders after mysql_prepare()"
      5910d9f0
  7. 22 Nov, 2003 1 commit
    • unknown's avatar
      Fix for bug #1500 "Server crash with mysql_prepare" · e3386d8f
      unknown authored
      We treat Item_param whose value is not set as non-const.
      This allows us to avoid use of Item_param's value (not yet existing) in 
      those fix_fields and fix_length_and_dec that do calculations if their 
      Items arguments are const. So we can call fix_fields for such items from
      mysql_prepare safely.
      
      
      sql/item.cc:
        Now Item_param is non-constant (const_item()==FALSE) until its value is set.
      sql/item.h:
        Added Item::const_during_execution() method which indicates constants that will be known 
        during execution phase (but they may be not known during preparing phase for example parameters 
        of prep. statements.)
        Made Item_param non-constant until its is value set, so its value won't be requested during 
        prepare statement step.
      sql/item_func.cc:
        Fulltext search AGAINST clause now allows prepared statement parameter as its argument.
        Removed duplicate used_tables_cache update in Item_func_match::fix_fields()
        (it is set during Item_func::fix_fields).
      tests/client_test.c:
        Added test for bug #1500 "Server crash with mysql_prepare"
      e3386d8f
  8. 19 Nov, 2003 1 commit
    • unknown's avatar
      Changed mysql_next_result() to return int instead of bool · b2b6a62f
      unknown authored
      Changed ~Item_func_in() to call cleanup() (to fix memory leak)
      Fixed test_multi_statements() test in client_test
      
      
      include/mysql.h:
        Changed mysql_next_result() to return int instead of bool
      libmysql/libmysql.c:
        Changed mysql_next_result() to return int instead of bool
        Added check to mysql_next_result() to ensure that it's not called in wrong context.
      sql/item_cmpfunc.cc:
        Indentation fixes
      sql/item_cmpfunc.h:
        Changed ~Item_func_in() to call cleanup()
        (Fixed memory leak in cmp_item_row())
      tests/client_test.c:
        Fixed test_multi_statements() test.
      b2b6a62f
  9. 18 Nov, 2003 1 commit
    • unknown's avatar
      Delete duplicate error message names · 8a2a03fd
      unknown authored
      include/mysqld_error.h:
        Delete duplicate error names
      include/sql_state.h:
        Delete duplicate error names
      myisam/ft_dump.c:
        Delete wrong patch
      myisam/myisamchk.c:
        Delete wrong patch
      mysql-test/r/query_cache.result:
        Fix after deleting duplicated error messages
      mysql-test/t/create.test:
        Fix after deleting duplicated error messages
      mysql-test/t/fulltext.test:
        Fix after deleting duplicated error messages
      mysql-test/t/key_cache.test:
        Fix after deleting duplicated error messages
      sql/share/czech/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/danish/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/dutch/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/english/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/estonian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/french/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/german/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/greek/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/hungarian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/italian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/japanese/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/korean/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/norwegian-ny/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/norwegian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/polish/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/portuguese/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/romanian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/russian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/serbian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/slovak/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/spanish/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/swedish/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/share/ukrainian/errmsg.txt:
        Fix after deleting duplicated error messages
      sql/sql_db.cc:
        Fix after deleting duplicated error messages
      sql/sql_parse.cc:
        Fix after deleting duplicated error messages
      sql/sql_table.cc:
        Fix after deleting duplicated error messages
      tests/client_test.c:
        CLIENT_MULTI_QUERIES -> CLIENT_MULTI_STATEMENTS
      8a2a03fd
  10. 27 Oct, 2003 1 commit
    • unknown's avatar
      BUG#1644: Insertion of more than 3 NULL columns with parameter binding fails · 6e1a2560
      unknown authored
      Fixed. Enabled test case in client_test.c.
      
      
      sql/sql_prepare.cc:
        BUG#1644: Insertion of more than 3 NULL columns with parameter binding fails
        Added missing parentheses in IS_PARAM_NULL to get the right bit.
      tests/client_test.c:
        BUG#1644: Insertion of more than 3 NULL columns with parameter binding fails
        Fixed. Enabled test case.
      6e1a2560
  11. 25 Oct, 2003 2 commits
    • unknown's avatar
      A few more fixes. · eb397abb
      unknown authored
      And added new test for BUG#1644. (Disabled for now, not fixed yet.)
      
      
      tests/client_test.c:
        A few more fixes:
        - Avoid buffer overruns in printf().
        - Corrected index for comment field in show table status output.
        
        And added new test for BUG#1644. (Disabled for now, not fixed yet.)
      eb397abb
    • unknown's avatar
      A major overhaul to adopt to recent changes. It now passes all tests. · 3c8c83d0
      unknown authored
      Note:
      - All test results haven't been inspected in detail to see if they are correct.
      - Some result set printing seems to have the wrong field width; most notably
        date/time fields and type fields (e.g. "int(4)").
      - There are still some valgrind complaints, but they seem to be in assert() or
        in libmysql.
      
      
      tests/client_test.c:
        A major overhaul to adopt to recent changes:
        
        - SHOW TABLE result has changed (more columns)
        - EXPLAIN result has VAR_STRING types now
        - Added missing mysql_bind_result() calls
        - Adopted to mysql_fetch_column() semantics: Don't use same pointers in MYSQL_BIND
          structs for fetch_column as for binding.
        - Removed a number of duplicated calls to tests
        - Added missing initialization of MYSQL_BIND structs fields (lenght fields),
          to shutup valgrind.
      3c8c83d0
  12. 24 Sep, 2003 1 commit
    • unknown's avatar
      - Code cleanup: replaced C++-style comments with the proper syntax for · bad17621
      unknown authored
         .c files (the IBM Visual Age C compiler aborts with a syntax error
         on these)
      
      
      libmysql/dll.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      libmysql/libmysql.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      mysys/my_getopt.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      sql/net_serv.cc:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      strings/ctype-bin.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      tests/client_test.c:
         - replaced C++-style comment with the proper syntax for .c files
           (the IBM Visual Age C compiler aborts with a syntax error on these)
      bad17621
  13. 11 Sep, 2003 1 commit
    • unknown's avatar
      After merge fixes. · d574e99c
      unknown authored
      Note that mix_innodb_myisam_binlog and union fails after this patch (Will be fixed shortly by maintaners of this code)
      
      
      client/mysql.cc:
        After merge fix
      include/mysql.h:
        Some additions to MYSQL_BIND for cleaner prepared statement code
      libmysql/libmysql.c:
        mysql_prepare_result -> mysql_get_metadata()
        Added test for offset overflow when using mysql_fetch_column()
        Cleaned up mysql_fetch_column()
        Optimized fetch_result() usage
      mysql-test/r/func_group.result:
        Updated results after merge
      mysql-test/r/func_test.result:
        Updated results after merge
      mysql-test/r/grant.result:
        Updated results after merge
      mysql-test/r/loaddata.result:
        Updated results after merge
      mysql-test/r/lowercase_table.result:
        Updated results after merge
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Updated results after merge (note that this is still not correct; Need patch to mysqld to fix this properly)
      mysql-test/r/myisam.result:
        Updated results after merge
      mysql-test/r/range.result:
        Updated results after merge
      mysql-test/r/rpl_loaddata.result:
        Updated results after merge
      mysql-test/r/rpl_loaddata_rule_m.result:
        Updated results after merge
      mysql-test/r/rpl_loaddata_rule_s.result:
        Updated results after merge
      mysql-test/r/rpl_log.result:
        Updated results after merge
      mysql-test/r/union.result:
        Updated results after merge
      mysql-test/t/lowercase_table.test:
        Update after merge
      mysql-test/t/myisam.test:
        Update after merge
      mysql-test/t/union.test:
        Update after merge
      sql-bench/compare-results.sh:
        Fix for now output format
      sql/field.h:
        Added is_null_in_record() to make ha_innodb.cc code more general
      sql/ha_innodb.cc:
        Removed some functions that uses inernal (private) MySQL information
      sql/item_cmpfunc.cc:
        After merge fix
      sql/log_event.cc:
        After merge fix; (Some code should be checked by Guilhem)
      sql/opt_range.cc:
        Simple optimzation and after merge fixes
      sql/slave.cc:
        After merge fix
      sql/sql_acl.cc:
        After merge fix + code cleanup
      sql/sql_select.cc:
        After merge fix
      sql/sql_show.cc:
        After merge fix
      sql/sql_table.cc:
        After merge fix
        Cleanup of mysql_checksum_table()
      sql/sql_union.cc:
        After merge fixes.
        Note that after this the union test still fails; Will be fixed shortly...
      tests/client_test.c:
        mysql_prepare_result() -> mysql_get_metadata()
      d574e99c
  14. 02 Sep, 2003 2 commits
    • unknown's avatar
      fixed BUG#1180 (changing WHERE clause of prepared statements by optimisation) · 313fee35
      unknown authored
      sql/item.h:
        constructor and method for aloning AND/OR structure of WHERE clause
      sql/item_cmpfunc.cc:
        constructor and method for aloning AND/OR structure of WHERE clause
      sql/item_cmpfunc.h:
        constructor and method for aloning AND/OR structure of WHERE clause
      sql/item_func.cc:
        constructor for aloning AND/OR structure of WHERE clause
      sql/item_func.h:
        constructor for aloning AND/OR structure of WHERE clause
      sql/sql_lex.cc:
        field for saving WHERE root
      sql/sql_lex.h:
        field for saving WHERE root
      sql/sql_prepare.cc:
        saving WHERE root
        creating new AND/OR structure before executing prepared statement
      tests/client_test.c:
        test suite for bug #1180
      313fee35
    • unknown's avatar
      fixed string parameter assugnment (coping instead of asigning pointer to buffer) (BUG#1115) · 7207e232
      unknown authored
      fixed test_field_misc (UTF variable value)
      
      
      sql/item.cc:
        added debug informetion
        fixed string parameter assugnment (coping instead of asigning pointer to buffer)
      tests/client_test.c:
        test for BUG#1115
        fixed test_field_misc (UTF variable value)
      7207e232
  15. 30 Jul, 2003 1 commit
  16. 21 Jul, 2003 1 commit
  17. 24 Jun, 2003 1 commit
  18. 08 Jun, 2003 1 commit
    • unknown's avatar
      Fix for mysql_list_fields & reset stmt buffers from stmt_free_result · 5c2c1318
      unknown authored
        Windows build fix 
      
      
      VC++Files/sql/mysqld.dsp:
        Added sql_state.c to wrk space
      include/mysql_com.h:
        Windows build fix (mismatch declaration of my_bool and bool from defination)
      include/thr_alarm.h:
        Windows build fix
      libmysql/libmysql.c:
        Fix for mysql_list_fields & reset stmt buffers from stmt_free_result
      tests/client_test.c:
        Updated test for DEFAULT value for mysql_list_fields()
        New tests for mysql_stmt_free_result()
      5c2c1318
  19. 04 Jun, 2003 1 commit
    • unknown's avatar
      protocol test update · 86e7bca3
      unknown authored
        (fix for memory ovverun bug from DBD(ranger) + changes for removal of collation from explain)
      
      
      tests/client_test.c:
        protocol test update 
        (fix for memory ovverun bug from DBD(ranger) + changes for removal of collation from explain)
      86e7bca3
  20. 21 May, 2003 1 commit
    • unknown's avatar
      client_test.c: · b579ec19
      unknown authored
        Updated protocol test
      
      
      tests/client_test.c:
        Updated protocol test
      b579ec19
  21. 04 Mar, 2003 1 commit
    • unknown's avatar
      Fix EXPLAIN bug with binary protocol · 6e5ddca3
      unknown authored
      Added new client tests (EXPLAIN + DECIMAL conv)
      
      
      
      sql/sql_prepare.cc:
        Fix EXPLAIN bug with binary protocol
      tests/client_test.c:
        New tests for EXPLAIN + DECIMAL conv
      6e5ddca3
  22. 25 Feb, 2003 1 commit
    • unknown's avatar
      1. Fix for the crash in debug mode when the .frm is corrupted and SHOW TABLE... · d0d212a8
      unknown authored
      1. Fix for the crash in debug mode when the .frm is corrupted and SHOW TABLE STATUS is executed.This also fixes to return the error message to comment field in SHOW TABLE STATUS when the .frm is corrupted
      2. Test for corrupted .frm and the SHOW TABLE STATUS
      
      
      sql/sql_show.cc:
        Fix for the crash in debug mode when the .frm is corrupted and SHOW TABLE STATUS is executed
        This also fixes to return the error message to comment field in SHOW TABLE STATUS when the .frm is corrupted
      tests/client_test.c:
        test for corrupted .frm and the SHOW TABLE STATUS
      d0d212a8
  23. 15 Feb, 2003 2 commits
  24. 05 Feb, 2003 2 commits
    • unknown's avatar
      Fix stupid signed and unsigned conversion - When field and buffer types are... · 1239e212
      unknown authored
        Fix stupid signed and unsigned conversion - When field and buffer types are different (Client receiving end)
        Added tests for singed and unsigned conversion (client_test.c)
      
      
      tests/client_test.c:
        Tests for singed and unsigned conversion
      libmysql/libmysql.c:
        Fix signed and unsigned conversion - When field and buffer types are different
      1239e212
    • unknown's avatar
      Conversion fix - bug report from PHP · 7a6fd35e
      unknown authored
      Added a new conversion bug test
      Changed options with default_options read from my.ini from [client] section
      More cleanups for better usage
      
      
      libmysql/libmysql.c:
        Conversion fix - bug report from PHP
      tests/client_test.c:
        Added a new conversion bug test
        Changed options with default_options read from my.ini from [client] section
        More cleanups for better usage
      7a6fd35e
  25. 31 Jan, 2003 3 commits
  26. 30 Jan, 2003 2 commits
  27. 29 Jan, 2003 1 commit
    • unknown's avatar
      client_test.c: · f5686cca
      unknown authored
        Compilation failure fix
      
      
      tests/client_test.c:
        Compilation failure fix
      f5686cca
  28. 28 Jan, 2003 1 commit
  29. 27 Jan, 2003 1 commit
  30. 26 Jan, 2003 1 commit
    • unknown's avatar
      Remove un-used variables · 838874e7
      unknown authored
      Pure coverage tests (debug only)
      
      
      include/mysql.h:
        Remove un-used variables
      tests/client_test.c:
        Pure coverage tests (debug only)
      838874e7