1. 07 Jun, 2005 40 commits
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-5.0 into mysql.com:/home/bk/mysql-5.0 · 0056d4d1
      unknown authored
      
      mysql-test/r/sp_trans.result:
        Auto merged
      mysql-test/t/sp_trans.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      0056d4d1
    • unknown's avatar
      BUG#6883: Merge fixes · ab393d60
      unknown authored
      
      mysql-test/r/innodb.result:
        Minor fixes
      mysql-test/r/rpl_ddl.result:
        Merge fixes
      mysql-test/r/sp_trans.result:
        TRUNCATE now makes implicit commit
      mysql-test/t/sp_trans.test:
        No error since we have inplicit commit
      ab393d60
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 5e8b284b
      unknown authored
      into mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      5e8b284b
    • unknown's avatar
      several fixes to the previous patch · ad283c80
      unknown authored
      
      server-tools/instance-manager/instance_options.cc:
        fix order of if branches
      server-tools/instance-manager/instance_options.h:
        portability fix
      server-tools/instance-manager/parse_output.cc:
        remove stupid comment
      server-tools/instance-manager/parse_output.h:
        portability fix
      ad283c80
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 3a09d369
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-5.0
      
      3a09d369
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 20aee4a9
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-5.0
      
      
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      20aee4a9
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 94af10a4
      unknown authored
      into mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      94af10a4
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-5.0 · e4d4bfbd
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      e4d4bfbd
    • unknown's avatar
      - added the libndbclient static and shared libraries to the RPM (BUG 10676) · 4d4425de
      unknown authored
      
      support-files/mysql.spec.sh:
        - added the libndbclient static and shared libraries (BUG 10676)
      4d4425de
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · cc48483c
      unknown authored
      into mysql.com:/opt/local/work/mysql-5.0-7306-final
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      cc48483c
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 43f18a41
      unknown authored
      into mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      43f18a41
    • unknown's avatar
      post-review fixes · 16db9cc4
      unknown authored
      
      server-tools/instance-manager/commands.cc:
        remove commented out code
      server-tools/instance-manager/instance.cc:
        use flag instead of int variable
      server-tools/instance-manager/instance.h:
        no more default values
      server-tools/instance-manager/instance_map.cc:
        use flag to be more verbose
      server-tools/instance-manager/instance_options.cc:
        don't read options when looking for an option, use strmake instead of strchr
      server-tools/instance-manager/instance_options.h:
        fix comment, use flag instead of int value
      server-tools/instance-manager/listener.cc:
        don't like c++ comments
      server-tools/instance-manager/log.cc:
        safety: strmake adds trailing zero to the string
      server-tools/instance-manager/parse_output.cc:
        use strmake instead of strncpy, renamed varianles to make code more readable
      server-tools/instance-manager/parse_output.h:
        get rid of default value
      16db9cc4
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 91e4732a
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      91e4732a
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-5.0 into mysql.com:/home/bk/mysql-5.0 · 3a365b07
      unknown authored
      
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      3a365b07
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b1367008
      unknown authored
      into mysql.com:/opt/local/work/mysql-5.0-7306-final
      
      b1367008
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 3c78f1b9
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-5.0-bg10015
      
      
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      3c78f1b9
    • unknown's avatar
      Fix for bug #10015 "Crash in InnoDB if stored routines are used". · a2bf92f2
      unknown authored
      We should not allow explicit or implicit transaction commits inside
      of stored functions or triggers (so in autocommit mode we should not
      do commits after execution of sub-statement).
      Also since we don't support nested statement transactions in 5.0,
      we shouldn't commit or rollback stmt transactions while we are inside
      stored functions or triggers. This should be fixed in later (>=5.1)
      releases.
      
      
      mysql-test/r/sp_trans.result:
        Added test for bug #10015 "Crash in InnoDB if stored routines are used"
        and for general transaction handling inside of functions.
      mysql-test/t/sp_trans.test:
        Added test for bug #10015 "Crash in InnoDB if stored routines are used"
        and for general transaction handling inside of functions.
      sql/handler.cc:
        ha_trans_commit()/ha_trans_rollback():
          Since we don't support nested statement transactions in 5.0,
          we can't commit or rollback stmt transactions while we are inside
          stored functions or triggers. So we simply do nothing now.
          This should be fixed in later ( >= 5.1) releases.
      sql/item_func.cc:
        Item_func_sp::execute():
          Set THD::transaction.in_sub_stmt flag to TRUE during stored function
          execution to prevent commits and rollbacks for statement level
          transactions, since doing them will ruin such transaction for
          stateemtn which calls this function.
      sql/share/errmsg.txt:
        Added error message which says that statements doing explicit or implicit
        commits are disallowed in triggers and stored functions.
      sql/sql_base.cc:
        close_thread_tables():
          Clarified comment about committing of statement transactions in
          prelocked mode.
      sql/sql_class.h:
        THD::transaction:
          Added in_sub_stmt method which indicates that we are executing
          statements from trigger or stored function now, and thus
          statement transaction belongs to statement which invoked this
          routine and we should not commit or rollback it while executing
          these sub-statements.
      sql/sql_parse.cc:
        end_active_trans()/begin_trans()/end_trans():
          We should not commit or rollback global (non-stmt) transaction
          if we are executing stored function or trigger. These checks will
          catch situation when we are trying to do commit or rollback in stored
          procedure which is called from function or trigger.
      sql/sql_trigger.h:
        Table_triggers_list::process_triggers():
          Set THD::transaction.in_sub_stmt flag to TRUE during trigger
          execution to prevent commits and rollbacks for statement level
          transactions, since doing them will ruin such transaction for
          stateemtn which invokes this trigger.
      sql/sql_yacc.yy:
        Prohibited usage of statements which do explicit or implicit commit or
        rollback inside of stored functions and triggers.
      a2bf92f2
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · 383a7799
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      383a7799
    • unknown's avatar
      Manual merge. · cb8e5581
      unknown authored
      
      sql/item.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      cb8e5581
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 81e45238
      unknown authored
      into a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-5.0
      
      81e45238
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 05767bd9
      unknown authored
      into a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-5.0
      
      05767bd9
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-5.0 · a0c3d7ea
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      a0c3d7ea
    • unknown's avatar
      ndb - backup/restore, fix count of dist keys · 455e625c
      unknown authored
        better fix for bug#10190
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        better fix for bug#10190
      455e625c
    • unknown's avatar
      Merge b6883-mysql-4.1 -> 5.0 · f433700c
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      myisam/mi_key.c:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      f433700c
    • unknown's avatar
      Patch two (the final one) for Bug#7306 "the server side preparedStatement · 59544040
      unknown authored
       error for LIMIT placeholder".
      The patch adds grammar support for LIMIT ?, ? and changes the
      type of ST_SELECT_LEX::select_limit,offset_limit from ha_rows to Item*,
      so that it can point to Item_param.
      
      
      mysql-test/include/ps_modify.inc:
        Fix existing tests: now LIMIT can contain placeholders.
      mysql-test/include/ps_query.inc:
        Fix existing tests: now LIMIT can contain placeholders.
      mysql-test/r/ps.result:
        Add basic test coverage for LIMIT ?, ? and fix test results.
      mysql-test/r/ps_2myisam.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/r/ps_3innodb.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/r/ps_4heap.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/r/ps_5merge.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/r/ps_6bdb.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/r/ps_7ndb.result:
        Fix test results: now LIMIT can contain placeholders.
      mysql-test/t/ps.test:
        Add basic test coverage for LIMIT ?, ?.
      sql/item.h:
        Add a short-cut for (ulonglong) val_int() to Item.
        Add a constructor to Item_int() that accepts ulonglong.
        Simplify Item_uint constructor by using the c-tor above.
      sql/item_subselect.cc:
        Now select_limit has type Item *.
        We can safely create an Item in Item_exists_subselect::fix_length_and_dec():
        it will be allocated in runtime memory root and freed in the end of
        execution.
      sql/sp_head.cc:
        Add a special initalization state for stored procedures to 
        be able to easily distinguish the first execution of a stored procedure
        from prepared statement prepare.
      sql/sql_class.h:
        Introduce new state 'INITIALIZED_FOR_SP' to be able to easily distinguish
        the first execution of a stored procedure from prepared statement prepare.
      sql/sql_derived.cc:
        - use unit->set_limit() to set unit->select_limit_cnt, offset_limit_cnt
          evreryplace. Add a warning about use of set_limit in 
        mysql_derived_filling.
      sql/sql_error.cc:
        - use unit->set_limit() to set unit->select_limit_cnt, offset_limit_cnt
          evreryplace.
        - this change is also aware of bug#11095 "show warnings limit 0 returns 
        all rows instead of zero rows", so the one who merges the bugfix from
        4.1 can use local version of sql_error.cc.
      sql/sql_handler.cc:
        - use unit->set_limit() to initalize 
        unit->select_limit_cnt,offset_limit_cnt everyplace.
      sql/sql_lex.cc:
        Now ST_SELECT_LEX::select_limit, offset_limit have type Item *
      sql/sql_lex.h:
        Now ST_SELECT_LEX::select_limit, offset_limit have type Item *
      sql/sql_parse.cc:
        - use unit->set_limit() to initalize 
        unit->select_limit_cnt,offset_limit_cnt everyplace. 
        - we can create an Item_int to set global limit of a statement:
        it will be created in the runtime mem root and freed in the end of
        execution.
      sql/sql_repl.cc:
        Use unit->set_limit to initialize limits.
      sql/sql_select.cc:
        - select_limit is now Item* so the proper way to check for default value
        is to compare it with NULL.
      sql/sql_union.cc:
        Evaluate offset_limit_cnt using the new type of ST_SELECT_LEX::offset_limit
      sql/sql_view.cc:
        Now ST_SELECT_LEX::select_limit, offset_limit have type Item *
      sql/sql_yacc.yy:
        Add grammar support for LIMIT ?, ? clause.
      59544040
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/dev/mysql-4.1-0 · 5f65cb6c
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      mysql-test/r/group_by.result:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_buff.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      5f65cb6c
    • unknown's avatar
      sql_select.cc, item_buff.cc, item.h: · 931e78ec
      unknown authored
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB field.
        Now the size of the buffer is limited by max_sort_length.
      group_by.test, group_by.result:
        Added a test case for bug #11088.
      
      
      mysql-test/r/group_by.result:
        Added a test case for bug #11088.
      mysql-test/t/group_by.test:
        Added a test case for bug #11088.
      sql/item.h:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      sql/item_buff.cc:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      sql/sql_select.cc:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      931e78ec
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-4.1 · d2a66935
      unknown authored
      into mysql.com:/home/bk/b6883-mysql-4.1
      
      
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      d2a66935
    • unknown's avatar
      BUG#6883: Changed comment, style · b2ec9d09
      unknown authored
      
      sql/sql_parse.cc:
        Changed comment, style
      b2ec9d09
    • unknown's avatar
      - manual merge of mysql.spec.sh · 10aca2db
      unknown authored
      
      scripts/Makefile.am:
        Auto merged
      support-files/mysql.spec.sh:
        - post merge fixes
      10aca2db
    • unknown's avatar
      innodb.result: · 7ccff7d4
      unknown authored
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      
      
      mysql-test/r/innodb.result:
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      7ccff7d4
    • unknown's avatar
      innodb.test: · 46649e88
      unknown authored
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      
      
      mysql-test/t/innodb.test:
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      46649e88
    • unknown's avatar
      innodb.result, innodb.test: · f734188f
      unknown authored
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      
      
      mysql-test/t/innodb.test:
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      mysql-test/r/innodb.result:
        Update Monty's tests for AUTO-INC bug #11080 and bug #11005
      f734188f
    • unknown's avatar
      Merge mysql.com:/Users/emurphy/src/bk-clean/mysql-4.1 · 125970ea
      unknown authored
      into  mysql.com:/Users/emurphy/src/work/mysql-4.1
      
      125970ea
    • unknown's avatar
      Accepted openlogging · 6c0f1351
      unknown authored
      6c0f1351
    • unknown's avatar
      Bug#10253: compound index length and utf8 char set · 309ed4c5
      unknown authored
      produces invalid query results
      
      mi_key.c:
        well_formed_length should be executed before space trimming, not after.
      ctype_utf8.test:
      ctype_utf8.result:
        adding test.
      
      
      myisam/mi_key.c:
        Bug#10253: ompound index length and utf8 char set produces invalid query results
        well_formed_length should be executed before space trimming, not after.
      mysql-test/r/ctype_utf8.result:
        adding test.
        adding test.
      mysql-test/t/ctype_utf8.test:
        adding test.
      309ed4c5
    • unknown's avatar
      ha_innodb.cc: · e4b83507
      unknown authored
        Update the InnoDB internal auto-inc counter in ::write_row() if the statement is a REPLACE that fails in a duplicate key error: REPLACE will handle duplicate key error, and the insert will eventually succeed; note that we did NOT change InnoDB's behavior in an UPDATE, because updating the auto-inc counter in an UPDATE would require a bigger patch (Bug #11005)
      
      
      sql/ha_innodb.cc:
        Update the InnoDB internal auto-inc counter in ::write_row() if the statement is a REPLACE that fails in a duplicate key error: REPLACE will handle duplicate key error, and the insert will eventually succeed; note that we did NOT change InnoDB's behavior in an UPDATE, because updating the auto-inc counter in an UPDATE would require a bigger patch (Bug #11005)
      e4b83507
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 240daca2
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      configure.in:
        Auto merged
      libmysqld/Makefile.am:
        Auto merged
      strings/ctype-big5.c:
        Auto merged
      strings/ctype-ucs2.c:
        Auto merged
      240daca2
    • unknown's avatar
      Moved tc_log_page_waits outside HAVE_MMAP, · 87d6a922
      unknown authored
      because it's used also outside.
      
      
      87d6a922
    • unknown's avatar
      A fix for systems that don't have HAVE_MMAP defined. · 9fae5188
      unknown authored
      Moved some variable externs from sql_class.h to mysql_priv.h
      
      
      sql/mysql_priv.h:
        Moved variables from sql_class.h to mysql_priv.h
      sql/mysqld.cc:
        Didn't compile, if HAVE_MMAP was not defined (Netware for example)
      sql/sql_class.h:
        Moved variables.
      9fae5188