An error occurred fetching the project authors.
  1. 02 Feb, 2009 1 commit
    • Serge Kozlov's avatar
      Post-merge patch for extra/rpl_test/rpl_log.test: · 01e368d1
      Serge Kozlov authored
      Remove size of binlog file from SHOW BINARY LOGS. 
      Changing size of binlog file is an affect of adding or removing events to/from
      binlog and it can be checked in next command of test: SHOW BINLOG EVENTS.
      For SHOW BINARY LOGS statement enough to show the list of file names.
      01e368d1
  2. 23 Jan, 2009 1 commit
  3. 22 Jan, 2009 1 commit
    • Andrei Elkin's avatar
      Bug #31240 load data infile replication between (4.0 or 4.1) and 5.1 fails · ffb14117
      Andrei Elkin authored
      It's a regression issue.
      The reason of the bug appeared to be an error introduced into 5.1 source code.
      A piece of code in Create_file_log_event::do_apply_event() did not have test
      coverage which made make test and pb unaware.
            
      Fixed with inverting the old value of the return value from 
      Create_file_log_event::do_apply_event().
      The rpl test suite is extended with `rpl_cross_version' the file to hold 
      regression cases similar to the current.
      ffb14117
  4. 21 Jan, 2009 1 commit
  5. 14 Jan, 2009 1 commit
  6. 09 Jan, 2009 1 commit
    • Sven Sandberg's avatar
      BUG#37718: rpl.rpl_stm_mystery22 fails sporadically on pushbuild · 3889dffc
      Sven Sandberg authored
      Problem 1: The test waits for an error in the slave sql thread,
      then resolves the error and issues 'start slave'. However, there
      is a gap between when the error is reported and the slave sql
      thread stops. If this gap was long, the slave would still be
      running when 'start slave' happened, so 'start slave' would fail
      and cause a test failure.
      Fix 1: Made wait_for_slave_sql_error wait for the slave to stop
      instead of wait for error in the IO thread. After stopping, the
      error code is verified. If the error code is wrong, debug info
      is printed. To print debug info, the debug printing code in
      wait_for_slave_param.inc was moved out to a new file,
      show_rpl_debug_info.inc.
      Problem 2: rpl_stm_mystery22 is a horrible name, the comments in
      the file didn't explain anything useful, the test was generally
      hard to follow, and the test was essentially duplicated between
      rpl_stm_mystery22 and rpl_row_mystery22.
      Fix 2: The test is about conflicts in the slave SQL thread,
      hence I renamed the tests to rpl_{stm,row}_conflicts. Refactored
      the test so that the work is done in
      extra/rpl_tests/rpl_conflicts.inc, and
      rpl.rpl_{row,stm}_conflicts merely sets some variables and then
      sourced extra/rpl_tests/rpl_conflicts.inc.
      The tests have been rewritten and comments added.
      Problem 3: When calling wait_for_slave_sql_error.inc, you always
      want to verify that the sql thread stops because of the expected
      error and not because of some other error. Currently,
      wait_for_slave_sql_error.inc allows the caller to omit the error
      code, in which case all error codes are accepted.
      Fix 3: Made wait_for_slave_sql_error.inc fail if no error code
      is given. Updated rpl_filter_tables_not_exist accordingly.
      Problem 4: rpl_filter_tables_not_exist had a typo, the dollar
      sign was missing in a 'let' statement.
      Fix 4: Added dollar sign.
      Problem 5: When replicating from other servers than the one named
      'master', the wait_for_slave_* macros were unable to print debug
      info on the master.
      Fix 5: Replace parameter $slave_keep_connection by
      $master_connection.
      3889dffc
  7. 29 Dec, 2008 1 commit
  8. 19 Dec, 2008 2 commits
    • Andrei Elkin's avatar
      Bug#38540 rpl_server_id2 uses show slave status unnecessarily · 50fa9c57
      Andrei Elkin authored
      a minor improvement to the test to ease merging.
      50fa9c57
    • Andrei Elkin's avatar
      Bug#38934 slave slave until does not work with --replicate-same-server-id · 04d72f86
      Andrei Elkin authored
      Bug#38540 rpl_server_id2 uses show slave status unnecessarily
                  
      Slave did not perform any event recorded into the relay log from some
      different master when it was started with --replicate-same-server-id.
      The reason appeared to be a consequence of BUG#38734 which stopped the
      sql thread at its startup time.
            
      The real fixes for the current bug are in the patch for BUG#38734.
      This changeset carries only a regression test for the bugs.  Bug#38540
      gets fixed too by means of eliminating an extra show slave status.
      04d72f86
  9. 12 Dec, 2008 1 commit
  10. 05 Dec, 2008 1 commit
    • Mats Kindahl's avatar
      Bug #40116: · 4e9695ac
      Mats Kindahl authored
      Uncommited changes are replicated and stay on slave after
      rollback on master
      
      Making test slightly more generic and robust.
      4e9695ac
  11. 03 Dec, 2008 1 commit
    • Mats Kindahl's avatar
      Bug #40116: Uncommited changes are replicated and stay on slave · 82757fdf
      Mats Kindahl authored
      after rollback on master
      
      When starting a transaction with a statement containing changes
      to both transactional tables and non-transactional tables, the
      statement is considered as non-transactional and is therefore
      written directly to the binary log. This behaviour was present
      in 5.0, and has propagated to 5.1.
      
      If a trigger containing a change of a non-transactional table is
      added to a transactional table, any changes to the transactional
      table is "tainted" as non-transactional.
      
      This patch solves the problem by removing the existing "hack" that
      allows non-transactional statements appearing first in a transaction
      to be written directly to the binary log. Instead, anything inside
      a transaction is treaded as part of the transaction and not written
      to the binary log until the transaction is committed.
      82757fdf
  12. 27 Nov, 2008 1 commit
  13. 24 Nov, 2008 1 commit
    • He Zhenxing's avatar
      BUG#40707 rpl_multi_engine fails sporadically in pushbuild · 560a9d15
      He Zhenxing authored
      If before running test rpl_mulit_engin, the mysqltest1 database exists
      on master but not exists on slave, then the following statement:
      
        create database if not exists mysqltest1;
      
      would not be logged to binary log, and so the database would not be
      created on slave. This would cause the test to fail and reporting 
      mysqltest1 database not existed on slave.
      
      This patch fixed this problem by not using a different database for
      the whole test, just use the default test database, there is no reason
      why a seperate database is used for this test.
      560a9d15
  14. 13 Nov, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#38350: Many tests don't clean up after themselves on exit. · 78a3abec
      Sven Sandberg authored
      Problem: Many test cases don't clean up after themselves (fail
      to drop tables or fail to reset variables). This implies that:
      (1) check-testcase in the new mtr that currently lives in
      5.1-rpl failed. (2) it may cause unexpected results in
      subsequent tests.
      Fix: make all tests clean up.
      Also: cleaned away unnecessary output in rpl_packet.result
      Also: fixed bug where rpl_log called RESET MASTER with a running
      slave. This is not supposed to work.
      Also: removed unnecessary code from rpl_stm_EE_err2 and made it
      verify that an error occurred.
      Also: removed unnecessary code from rpl_ndb_ctype_ucs2_def.
      78a3abec
  15. 06 Nov, 2008 2 commits
    • Andrei Elkin's avatar
      bug#38230 · c1612bbf
      Andrei Elkin authored
      refining the regression test to avoid explicit innodb engine in create.
      c1612bbf
    • Sven Sandberg's avatar
      BUG#36625: Please remove the rpl_probe and rpl_parse features from the server · e66ea9eb
      Sven Sandberg authored
      Problem 1: BUG#36625: rpl_redirect doesn't do anything useful. It tests an
      obsolete feature that was never fully implemented.
      Fix 1: Remove rpl_redirect.
      Problem 2: rpl_innodb_bug28430 and rpl_flushlog_loop are disabled despite the
      bugs for which they were disabled have been fixed.
      Fix 2: Re-enable rpl_innodb_bug28430 and rpl_flushlog_loop.
      e66ea9eb
  16. 04 Nov, 2008 3 commits
  17. 03 Nov, 2008 1 commit
  18. 29 Oct, 2008 2 commits
    • Mats Kindahl's avatar
      Post-merge fixes to fix test cases. · 450cc26b
      Mats Kindahl authored
      450cc26b
    • Sven Sandberg's avatar
      BUG#40257: Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf · 2dca77e4
      Sven Sandberg authored
      Removed the flag that disables innodb on slave in the default
      configuration of replication tests. That made the explicit
      --innodb flag in -slave.opt files redundant, so lots of -slave.opt
      files could be removed. Also, -master.opt files containing reduntant
      --innodb flag were removed (those were redundant even without
      changing the default). Removing .opt files is good because .opt
      files cause server restarts and make tests less readable.
      Also fixed a bug where rpl_innodb_mixed_ddl unintentionally
      used myisam on slave.
      2dca77e4
  19. 24 Oct, 2008 1 commit
  20. 20 Oct, 2008 1 commit
    • Mats Kindahl's avatar
      Bug #40004 Replication failure with no PK + no indexes · 95833a74
      Mats Kindahl authored
      In certain situations, a scan of the table will return the error
      code HA_ERR_RECORD_DELETED, and this error code is not 
      correctly caught in the Rows_log_event::find_row() function, which
      causes an error to be returned for this case.
      
      This patch fixes the problem by adding code to either ignore the
      record and continuing with the next one, the the event of a table
      scan, or change the error code to HA_ERR_KEY_NOT_FOUND, in the event
      that a key lookup is attempted.
      95833a74
  21. 16 Oct, 2008 1 commit
  22. 13 Oct, 2008 1 commit
  23. 11 Oct, 2008 1 commit
  24. 08 Oct, 2008 2 commits
    • Georgi Kodinov's avatar
      Bug #32124: crash if prepared statements refer to variables in the where clause · 489ad44a
      Georgi Kodinov authored
                        
      The code to get read the value of a system variable was extracting its value 
      on PREPARE stage and was substituting the value (as a constant) into the parse tree.
      Note that this must be a reversible transformation, i.e. it must be reversed before
      each re-execution.
      Unfortunately this cannot be reliably done using the current code, because there are
      other non-reversible source tree transformations that can interfere with this
      reversible transformation.
      Fixed by not resolving the value at PREPARE, but at EXECUTE (as the rest of the 
      functions operate). Added a cache of the value (so that it's constant throughout
      the execution of the query). Note that the cache also caches NULL values.
      Updated an obsolete related test suite (variables-big) and the code to test the 
      result type of system variables (as per bug 74).
      489ad44a
    • Mats Kindahl's avatar
      Bug #34707: Row based replication: slave creates table within wrong database · 70b18065
      Mats Kindahl authored
      The failure was caused by executing a CREATE-SELECT statement that creates a
      table in another database than the current one. In row-based logging, the
      CREATE statement was written to the binary log without the database, hence
      creating the table in the wrong database, causing the following inserts to
      fail since the table didn't exist in the given database.
      
      Fixed the bug by adding a parameter to store_create_info() that will make
      the function print the database name before the table name and used that
      in the calls that write the CREATE statement to the binary log. The database
      name is only printed if it is different than the currently selected database.
      
      The output of SHOW CREATE TABLE has not changed and is still printed without
      the database name.
      70b18065
  25. 07 Oct, 2008 3 commits
  26. 02 Oct, 2008 1 commit
    • Mats Kindahl's avatar
      Bug #38360: BLACKHOLE replication with RBR is broken · 43fb8633
      Mats Kindahl authored
      The Blackhole engine did not support row-based replication
      since the delete_row(), update_row(), and the index and range
      searching functions were not implemented.
      
      This patch adds row-based replication support for the
      Blackhole engine by implementing the two functions mentioned
      above, and making the engine pretend that it has found the
      correct row to delete or update when executed from the slave
      SQL thread by implementing index and range searching functions.
      
      It is necessary to only pretend this for the SQL thread, since
      a SELECT executed on the Blackhole engine will otherwise never
      return EOF, causing a livelock.
      43fb8633
  27. 15 Sep, 2008 1 commit
  28. 03 Sep, 2008 2 commits
    • Mats Kindahl's avatar
      Bug #32709: Assertion failed: trx_data->empty(), file log.cc · 9755f072
      Mats Kindahl authored
      The assertion indicates that some data was left in the transaction
      cache when the server was shut down, which means that a previous
      statement did not commit or rollback correctly.
      
      What happened was that a bug in the rollback of a transactional
      table caused the transaction cache to be emptied, but not reset.
      The error can be triggered by having a failing UPDATE or INSERT,
      on a transactional table, causing an implicit rollback.
      
      Fixed by always flushing the pending event to reset the state
      properly.
      9755f072
    • Andrei Elkin's avatar
      Bug#36099 replicate-do-db affects replaying RBR events with mysqlbinlog · 21a08eab
      Andrei Elkin authored
            
      The replication filtering rules were inappropiately applied when
      executing BINLOG pseudo-query.  The rules are supposed to be active
      only at times when the slave's sql thread executes an event.
                  
      Fixed with correcting a condition to call replication rules only if
      the slave sql thread executes the event.
      21a08eab
  29. 01 Sep, 2008 1 commit
  30. 26 Aug, 2008 2 commits