1. 17 Sep, 2018 6 commits
  2. 16 Sep, 2018 2 commits
  3. 14 Sep, 2018 2 commits
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 171fbbb9
      Marko Mäkelä authored
      171fbbb9
    • Marko Mäkelä's avatar
      MDEV-17196 Crash during instant ADD COLUMN with long DEFAULT value · aba5c72b
      Marko Mäkelä authored
      A debug assertion would fail if an instant ADD COLUMN operation
      involves splitting the leftmost leaf page and storing a default
      value off-page. Another debug assertion could fail if the
      default value does not fit in an undo log page.
      
      btr_cur_pessimistic_update(): Invoke rec_offs_make_valid()
      in order to prevent rec_offs_validate() assertion failure.
      
      innobase_add_instant_try(): Invoke btr_cur_pessimistic_update()
      with the BTR_KEEP_POS_FLAG, which is the correct course of action
      when BLOBs may need to be written. Whenever returning true,
      ensure that my_error() will have been called.
      aba5c72b
  4. 13 Sep, 2018 2 commits
    • Jacob Mathew's avatar
      MDEV-16912: Spider Order By column[datatime] limit 5 returns 3 rows · 30d22569
      Jacob Mathew authored
      The problem occurs in 10.2 and earlier releases of MariaDB Server because the
      Partition Engine was not pushing the engine conditions to the underlying
      storage engine of each partition.  This caused Spider to return the first 5
      rows in the table with the data provided by the customer.  2 of the 5 rows
      did not qualify the WHERE clause, so they were removed from the result set by
      the server.
      
      To fix the problem, I have back-ported support for engine condition pushdown
      in the Partition Engine from MariaDB Server 10.3 to 10.2 and 10.1.  In 10.3
      and 10.4 I have merged the comments and the test case.
      
      Author:
        Jacob Mathew.
      
      Reviewer:
        Kentoku Shiba.
      
      Cherry-Picked:
        Commit ed49f9aa on branch 10.3
      30d22569
    • Jacob Mathew's avatar
      MDEV-16912: Spider Order By column[datatime] limit 5 returns 3 rows · ed49f9aa
      Jacob Mathew authored
      The problem occurs in 10.2 and earlier releases of MariaDB Server because the
      Partition Engine was not pushing the engine conditions to the underlying
      storage engine of each partition.  This caused Spider to return the first 5
      rows in the table with the data provided by the customer.  2 of the 5 rows
      did not qualify the WHERE clause, so they were removed from the result set by
      the server.
      
      To fix the problem, I have back-ported support for engine condition pushdown
      in the Partition Engine from MariaDB Server 10.3 to 10.2 and 10.1.  In 10.3
      and 10.4 I have merged the comments and the test case.
      
      Author:
        Jacob Mathew.
      
      Reviewer:
        Kentoku Shiba.
      
      Merged:
        Commit eb2ca3d4 on branch bb-10.2-MDEV-16912
      ed49f9aa
  5. 12 Sep, 2018 3 commits
  6. 11 Sep, 2018 7 commits
    • Marko Mäkelä's avatar
      MDEV-17138 Reduce redo log volume for undo tablespace initialization · 5567a8c9
      Marko Mäkelä authored
      Implement a 10.4 redo log format, which extends the 10.3 format
      by introducing the MLOG_MEMSET record.
      
      MLOG_MEMSET: A new redo log record type for filling an area with a byte.
      
      mlog_memset(): Write the MLOG_MEMSET record.
      
      mlog_parse_nbytes(): Handle MLOG_MEMSET as well.
      
      trx_rseg_header_create(): Reduce the redo log volume by making use of
      mlog_memset() and the zero-initialization that happens inside page
      allocation.
      
      fil_addr_null: Remove.
      
      flst_init(): Create a variant that takes a zero-initialized
      buf_block_t* as a parameter, and only writes the FIL_NULL using
      mlog_memset().
      
      flst_zero_addr(): A variant of flst_write_addr() that writes
      a null address using mlog_memset() for the FIL_NULL.
      
      The following fixes are replacing some use of MLOG_WRITE_STRING
      with the more compact MLOG_MEMSET record, or eliminating
      redundant redo log writes:
      
      btr_store_big_rec_extern_fields(): Invoke mlog_memset() for
      zero-initializing the tail of the ROW_FORMAT=COMPRESSED BLOB page.
      
      trx_sysf_create(), trx_rseg_format_upgrade(): Invoke mlog_memset()
      for zero-initializing the page trailer.
      
      fsp_header_init(), trx_rseg_header_create():
      Remove redundant zero-initializations.
      5567a8c9
    • Marko Mäkelä's avatar
      MDEV-13564: Remove old crash-upgrade logic in 10.4 · 09af00cb
      Marko Mäkelä authored
      Stop supporting the additional *trunc.log files that were
      introduced via MySQL 5.7 to MariaDB Server 10.2 and 10.3.
      
      DB_TABLESPACE_TRUNCATED: Remove.
      
      purge_sys.truncate: A new structure to track undo tablespace
      file truncation.
      
      srv_start(): Remove the call to buf_pool_invalidate(). It is
      no longer necessary, given that we no longer access things in
      ways that violate the ARIES protocol. This call was originally
      added for innodb_file_format, and it may later have been necessary
      for the proper function of the MySQL 5.7 TRUNCATE recovery, which
      we are now removing.
      
      trx_purge_cleanse_purge_queue(): Take the undo tablespace as a
      parameter.
      
      trx_purge_truncate_history(): Rewrite everything mostly in a
      single function, replacing references to undo::Truncate.
      
      recv_apply_hashed_log_recs(): If any redo log is to be applied,
      and if the log_sys.log.subformat indicates that separately
      logged truncate may have been used, refuse to proceed except if
      innodb_force_recovery is set. We will still refuse crash-upgrade
      if TRUNCATE TABLE was logged. Undo tablespace truncation would
      only be logged in undo*trunc.log files, which we are no longer
      checking for.
      09af00cb
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 67fa97dc
      Marko Mäkelä authored
      67fa97dc
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 1bf3e8ab
      Marko Mäkelä authored
      1bf3e8ab
    • Jan Lindström's avatar
      Merge pull request #850 from HeMan/10.3 · 8dda6d79
      Jan Lindström authored
      Return code from starting MariaDB.
      8dda6d79
    • Jan Lindström's avatar
      Merge pull request #858 from codership/10.3-MDEV-16052 · ffd583bb
      Jan Lindström authored
      MDEV-16052 galera mtr galera_certification_double_failure fails with deadlock
      ffd583bb
    • Jan Lindström's avatar
      Merge pull request #857 from codership/10.3-MDEV-15845 · 4d93fea4
      Jan Lindström authored
      MDEV-15845 Test failure on galera.galera_concurrent_ctas
      4d93fea4
  7. 10 Sep, 2018 6 commits
    • Teodor Mircea Ionita's avatar
      README.md: Break off long line · f5bebaf1
      Teodor Mircea Ionita authored
      f5bebaf1
    • Teodor Mircea Ionita's avatar
    • Marko Mäkelä's avatar
      6b61f1bb
    • Marko Mäkelä's avatar
      MDEV-17161 TRUNCATE TABLE fails after upgrade from 10.1 · fc34e4c0
      Marko Mäkelä authored
      With the TRUNCATE by rename, create, drop (MDEV-13564),
      old tables with invalid ROW_FORMAT attribute could not be
      truncated. Introduce a sloppy mode for allowing the TRUNCATE.
      
      create_table_info_t::prepare_create_table(): Add the parameter
      strict=true.
      
      ha_innobase::create(): Pass strict=false if trx!=NULL
      (the create is part of TRUNCATE).
      fc34e4c0
    • Marko Mäkelä's avatar
      b02c722e
    • Marko Mäkelä's avatar
      MDEV-17158 TRUNCATE is not atomic after MDEV-13564 · 75f8e86f
      Marko Mäkelä authored
      It turned out that ha_innobase::truncate() would prematurely
      commit the transaction already before the completion of the
      ha_innobase::create(). All of this must be atomic.
      
      innodb.truncate_crash: Use the correct DEBUG_SYNC point, and
      tolerate non-truncation of the table, because the redo log
      for the TRUNCATE transaction commit might be flushed due to
      some InnoDB background activity.
      
      dict_build_tablespace_for_table(): Merge to the function
      dict_build_table_def_step().
      
      dict_build_table_def_step(): If a table is being created during
      an already started data dictionary transaction (such as TRUNCATE),
      persistently write the table_id to the undo log header before
      creating any file. In this way, the recovery of TRUNCATE will be
      able to delete the new file before rolling back the rename of
      the original table.
      
      dict_table_rename_in_cache(): Add the parameter replace_new_file,
      used as part of rolling back a TRUNCATE operation.
      
      fil_rename_tablespace_check(): Add the parameter replace_new.
      If the parameter is set and a file identified by new_path exists,
      remove a possible tablespace and also the file.
      
      create_table_info_t::create_table_def(): Remove some debug assertions
      that no longer hold. During TRUNCATE, the transaction will already
      have been started (and performed a rename operation) before the
      table is created. Also, remove a call to dict_build_tablespace_for_table().
      
      create_table_info_t::create_table(): Add the parameter create_fk=true.
      During TRUNCATE TABLE, do not add FOREIGN KEY constraints to the
      InnoDB data dictionary, because they will also not be removed.
      
      row_table_add_foreign_constraints(): If trx=NULL, do not modify
      the InnoDB data dictionary, but only load the FOREIGN KEY constraints
      from the data dictionary.
      
      ha_innobase::create(): Lock the InnoDB data dictionary cache only
      if no transaction was passed by the caller. Unlock it in any case.
      
      innobase_rename_table(): Add the parameter commit = true.
      If !commit, do not lock or unlock the data dictionary cache.
      
      ha_innobase::truncate(): Lock the data dictionary before invoking
      rename or create, and let ha_innobase::create() unlock it and
      also commit or roll back the transaction.
      
      trx_undo_mark_as_dict(): Renamed from trx_undo_mark_as_dict_operation()
      and declared global instead of static.
      
      row_undo_ins_parse_undo_rec(): If table_id is set, this must
      be rolling back the rename operation in TRUNCATE TABLE, and
      therefore replace_new_file=true.
      75f8e86f
  8. 09 Sep, 2018 5 commits
  9. 08 Sep, 2018 1 commit
  10. 07 Sep, 2018 6 commits
    • Marko Mäkelä's avatar
      MDEV-13564 Mariabackup does not work with TRUNCATE · 5a1868b5
      Marko Mäkelä authored
      This is a merge from 10.2, but the 10.2 version of this will not
      be pushed into 10.2 yet, because the 10.2 version would include
      backports of MDEV-14717 and MDEV-14585, which would introduce
      a crash recovery regression: Tables could be lost on
      table-rebuilding DDL operations, such as ALTER TABLE,
      OPTIMIZE TABLE or this new backup-friendly TRUNCATE TABLE.
      The test innodb.truncate_crash occasionally loses the table due to
      the following bug:
      
      MDEV-17158 log_write_up_to() sometimes fails
      5a1868b5
    • Marko Mäkelä's avatar
      MDEV-14717: Prevent crash-downgrade to earlier MariaDB 10.2 · 980d1bf1
      Marko Mäkelä authored
      A crash-downgrade of a RENAME (or TRUNCATE or table-rebuilding
      ALTER TABLE or OPTIMIZE TABLE) operation to an earlier 10.2 version
      would trigger a debug assertion failure during rollback,
      in trx_roll_pop_top_rec_of_trx(). In a non-debug build, the
      TRX_UNDO_RENAME_TABLE record would be misinterpreted as an
      update_undo log record, and typically the file name would be
      interpreted as DB_TRX_ID,DB_ROLL_PTR,PRIMARY KEY. If a matching
      record would be found, row_undo_mod() would hit ut_error in
      switch (node->rec_type). Typically, ut_a(table2 == NULL) would
      fail when opening the table from SQL.
      
      Because of this, we prevent a crash-downgrade to earlier MariaDB 10.2
      versions by changing the InnoDB redo log format identifier to the
      10.3 identifier, and by introducing a subformat identifier so that
      10.2 can continue to refuse crash-downgrade from 10.3 or later.
      After a clean shutdown, a downgrade to MariaDB 10.2.13 or later would
      still be possible thanks to MDEV-14909. A downgrade to older 10.2
      versions is only possible after removing the log files (not recommended).
      
      LOG_HEADER_FORMAT_CURRENT: Change to 103 (originally the 10.3 format).
      
      log_group_t: Add subformat. For 10.2, we will use subformat 1,
      and will refuse crash recovery from any other subformat of the
      10.3 format, that is, a genuine 10.3 redo log.
      
      recv_find_max_checkpoint(): Allow startup after clean shutdown
      from a future LOG_HEADER_FORMAT_10_4 (unencrypted only).
      We cannot handle the encrypted 10.4 redo log block format,
      which was introduced in MDEV-12041. Allow crash recovery from
      the original 10.2 format as well as the new format.
      In Mariabackup --backup, do not allow any startup from 10.3 or 10.4
      redo logs.
      
      recv_recovery_from_checkpoint_start(): Skip redo log apply for
      clean 10.3 redo log, but not for the new 10.2 redo log
      (10.3 format, subformat 1).
      
      srv_prepare_to_delete_redo_log_files(): On format or subformat
      mismatch, set srv_log_file_size = 0, so that we will display the
      correct message.
      
      innobase_start_or_create_for_mysql(): Check for format or subformat
      mismatch.
      
      xtrabackup_backup_func(): Remove debug assertions that were made
      redundant by the code changes in recv_find_max_checkpoint().
      980d1bf1
    • Marko Mäkelä's avatar
      MDEV-14585 Automatically remove #sql- tables in InnoDB dictionary during recovery · 73ed19e4
      Marko Mäkelä authored
      This is a backport of the following commits:
      commit b4165985
      commit 69e88de0
      commit 40f4525f
      commit 656f66de
      
      Now that MDEV-14717 made RENAME TABLE crash-safe within InnoDB,
      it should be safe to drop the #sql- tables within InnoDB during
      crash recovery. These tables can be one of two things:
      
      (1) #sql-ib related to deferred DROP TABLE (follow-up to MDEV-13407)
      or to table-rebuilding ALTER TABLE...ALGORITHM=INPLACE
      (since MDEV-14378, only related to the intermediate copy of a table),
      
      (2) #sql- related to the intermediate copy of a table during
      ALTER TABLE...ALGORITHM=COPY
      
      We will not drop tables whose name starts with #sql2, because
      the server can be killed during an ALGORITHM=COPY operation at
      a point where the original table was renamed to #sql2 but the
      finished intermediate copy was not yet renamed from #sql-
      to the original table name.
      
      If an old version of MariaDB Server before 10.2.13 (MDEV-11415)
      was killed while ALTER TABLE...ALGORITHM=COPY was in progress,
      after recovery there could be undo log records for some records that were
      inserted into an intermediate copy of the table. Due to these undo log
      records, InnoDB would resurrect locks at recovery, and the intermediate
      table would be locked while we are trying to drop it. This would cause
      a call to row_rename_table_for_mysql(), either from
      row_mysql_drop_garbage_tables() or from the rollback of a RENAME
      operation that was part of the ALTER TABLE.
      
      row_rename_table_for_mysql(): Do not attempt to parse FOREIGN KEY
      constraints when renaming from #sql-something to #sql-something-else,
      because it does not make any sense.
      
      row_drop_table_for_mysql(): When deferring DROP TABLE due to locks,
      do not rename the table if its name already starts with the #sql-
      prefix, which is what row_mysql_drop_garbage_tables() uses.
      Previously, the too strict prefix #sql-ib was used, and some
      tables were renamed unnecessarily.
      73ed19e4
    • Marko Mäkelä's avatar
      Follow-up to MDEV-13407 innodb.drop_table_background failed in buildbot with... · 8dcacd3b
      Marko Mäkelä authored
      Follow-up to MDEV-13407 innodb.drop_table_background failed in buildbot with "Tablespace for table exists"
      
      This is a backport of commit 88aff5f4.
      
      The InnoDB background DROP TABLE queue is something that we should
      really remove, but are unable to until we remove dict_operation_lock
      so that DDL and DML operations can be combined in a single transaction.
      
      Because the queue is not persistent, it is not crash-safe. We should
      in some way ensure that the deferred-dropped tables will be dropped
      after server restart.
      
      The existence of two separate transactions complicates the error handling
      of CREATE TABLE...SELECT. We should really not break locks in DROP TABLE.
      
      Our solution to these problems is to rename the table to a temporary
      name, and to drop such-named tables on InnoDB startup. Also, the
      queue will use table IDs instead of names from now on.
      
      check-testcase.test: Ignore #sql-ib*.ibd files, because tables may enter
      the background DROP TABLE queue shortly before the test finishes.
      
      innodb.drop_table_background: Test CREATE...SELECT and the creation of
      tables whose file name starts with #sql-ib.
      
      innodb.alter_crash: Adjust the recovery, now that the #sql-ib tables
      will be dropped on InnoDB startup.
      
      row_mysql_drop_garbage_tables(): New function, to drop all #sql-ib tables
      on InnoDB startup.
      
      row_drop_table_for_mysql_in_background(): Remove an unnecessary and
      misplaced call to log_buffer_flush_to_disk(). (The call should have been
      after the transaction commit. We do not care about flushing the redo log
      here, because the table would be dropped again at server startup.)
      
      Remove the entry from the list after the table no longer exists.
      
      If server shutdown has been initiated, empty the list without actually
      dropping any tables. They will be dropped again on startup.
      
      row_drop_table_for_mysql(): Do not call lock_remove_all_on_table().
      Instead, if locks exist, defer the DROP TABLE until they do not exist.
      If the table name does not start with #sql-ib, rename it to that prefix
      before adding it to the background DROP TABLE queue.
      8dcacd3b
    • Marko Mäkelä's avatar
      MDEV-14378 In ALGORITHM=INPLACE, use a common name for the intermediate tables or partitions · 754727bb
      Marko Mäkelä authored
      This is a backport of commit 07e9ff1f.
      
      Allow DROP TABLE `#mysql50##sql-...._.` to drop tables that were
      being rebuilt by ALGORITHM=INPLACE
      
      NOTE: If the server is killed after the table-rebuilding ALGORITHM=INPLACE
      commits inside InnoDB but before the .frm file has been replaced, then
      the recovery will involve something else than DROP TABLE.
      
      NOTE: If the server is killed in a true inplace ALTER TABLE commits
      inside InnoDB but before the .frm file has been replaced, then we
      are really out of luck. To properly handle that situation, we would
      need a transactional mysql.ddl_fixup table that directs recovery to
      rename or remove files.
      
      prepare_inplace_alter_table_dict(): Use the altered_table->s->table_name
      for generating the new_table_name.
      
      table_name_t::part_suffix: The start of the partition name suffix.
      
      table_name_t::dbend(): Return the end of the schema name.
      
      table_name_t::dblen(): Return the length of the schema name, in bytes.
      
      table_name_t::basename(): Return the name without the schema name.
      
      table_name_t::part(): Return the partition name, or NULL if none.
      
      row_drop_table_for_mysql(): Assert for #sql, not #sql-ib.
      754727bb
    • Marko Mäkelä's avatar
      MDEV-14717 RENAME TABLE in InnoDB is not crash-safe · cf2a4426
      Marko Mäkelä authored
      This is a backport of commit 0bc36758
      and commit 9eb3fcc9.
      
      InnoDB in MariaDB 10.2 appears to only write MLOG_FILE_RENAME2
      redo log records during table-rebuilding ALGORITHM=INPLACE operations.
      We must write the records for any .ibd file renames, so that the
      operations are crash-safe.
      
      If InnoDB is killed during a RENAME TABLE operation, it can happen that
      the transaction for updating the data dictionary will be rolled back.
      But, nothing will roll back the renaming of the .ibd file
      (the MLOG_FILE_RENAME2 only guarantees roll-forward), or for that matter,
      the renaming of the dict_table_t::name in the dict_sys cache. We introduce
      the undo log record TRX_UNDO_RENAME_TABLE to fix this.
      
      fil_space_for_table_exists_in_mem(): Remove the parameters
      adjust_space, table_id and some code that was trying to work around
      these deficiencies.
      
      fil_name_write_rename(): Write a MLOG_FILE_RENAME2 record.
      
      dict_table_rename_in_cache(): Invoke fil_name_write_rename().
      
      trx_undo_rec_copy(): Set the first 2 bytes to the length of the
      copied undo log record.
      
      trx_undo_page_report_rename(), trx_undo_report_rename():
      Write a TRX_UNDO_RENAME_TABLE record with the old table name.
      
      row_rename_table_for_mysql(): Invoke trx_undo_report_rename()
      before modifying any data dictionary tables.
      
      row_undo_ins_parse_undo_rec(): Roll back TRX_UNDO_RENAME_TABLE
      by invoking dict_table_rename_in_cache(), which will take care
      of both renaming the table and the file.
      
      ha_innobase::truncate(): Remove a work-around.
      cf2a4426