1. 02 Aug, 2007 5 commits
    • unknown's avatar
      mysqld.cc: · 059e2e70
      unknown authored
        Post merge changes.
      
      
      sql/mysqld.cc:
        Post merge changes.
      059e2e70
    • unknown's avatar
      sql_class.h: · db455352
      unknown authored
        After merge changes.
      
      
      sql/sql_class.h:
        After merge changes.
      db455352
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/24989-bug-5.0-opt-mysql · 8a84dc32
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/mysqld.cc:
        SCCS merged
      8a84dc32
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/24989-bug-5.0-opt-mysql · 62938b6d
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/handler.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_rcontext.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      mysql-test/include/read_many_rows.inc:
        Manually merged
      mysql-test/r/read_many_rows_innodb.result:
        Manually merged
      sql/sql_class.cc:
        Manually merged
      sql/sql_class.h:
        Manually merged
      storage/innobase/handler/ha_innodb.cc:
        Manually merged
      62938b6d
    • unknown's avatar
      Addendum to bug 29325 · 2b9607c7
      unknown authored
      keep_files_on_create made a startup option
      
      
      sql/mysqld.cc:
        Addendum to bug #29325
        keep_files_on_create made a startup option
      2b9607c7
  2. 31 Jul, 2007 22 commits
    • unknown's avatar
      Addendum to bug 27417: poor test results fixes. · 087853ca
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Addendum to bug 27417: removed tests for another bug
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        Addendum to bug 27417: removed tests for another bug
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Addendum to bug 27417: changes to non-transactional tables 
        should be logged even on rollback.
      087853ca
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bd3481e5
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/24989-bug-5.0-opt-mysql
      
      bd3481e5
    • unknown's avatar
      ha_innodb.cc: · 8a66bc2e
      unknown authored
        Warning fixed.
      
      
      sql/ha_innodb.cc:
        Warning fixed.
      8a66bc2e
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · dfdb46df
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27417-5.0-opt
      
      
      sql/handler.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      dfdb46df
    • unknown's avatar
      Post-merge fixes · a2c0a707
      unknown authored
      a2c0a707
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · c96b22f5
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27417-5.1-opt
      
      
      sql/sp_head.cc:
        Auto merged
      c96b22f5
    • unknown's avatar
      merge of the fix for bug 17417 5.0-opt->5.1-opt · 6761c94c
      unknown authored
      6761c94c
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27417-5.0-opt · 61df7e71
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B27417-5.1-opt
      
      
      sql/sql_update.cc:
        Auto merged
      61df7e71
    • unknown's avatar
      addendum for the fix for bug 27417: · fe6fa48c
      unknown authored
      extend the assert so it will run the testsuite
      
      fe6fa48c
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 13ac96c6
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.0-bug29582
      
      
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      13ac96c6
    • unknown's avatar
      BUG#29582: huge memory consumption with union, subselect, joins: · b4c0044e
      unknown authored
      - Don't call mysql_select() several times for the select that enumerates
        a temporary table with the results of the UNION. Making this call for
        every subquery execution caused O(#enumerated-rows-in-the-outer-query) 
        memory allocations.
      - Instead, call join->reinit() and join->exec(), and
        = disable constant table detection for such joins,  
        = provide special handling for table-less constant subqueries.
      
      
      sql/sql_select.cc:
        BUG#29582: huge memory consumption with union, subselect, joins:
         - Don't mark tables as constant if JOIN::no_const_tables flag is set
      sql/sql_select.h:
        BUG#29582: huge memory consumption with union, subselect, joins:
         - Don't mark tables as constant if JOIN::no_const_tables flag is set
      sql/sql_union.cc:
        BUG#29582: huge memory consumption with union, subselect, joins:
        - Don't call mysql_select() several times for the select that enumerates
          a temporary table with UNION results. 
        - Instead, call join->reinit() and join->exec().
        - Provide special handling for table-less constant subqueries.
      b4c0044e
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 5e5fdc0f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      5e5fdc0f
    • unknown's avatar
      sql_yacc.yy, sp.result, disabled.def: · cae1bff7
      unknown authored
        Post-merge fix.
      
      
      mysql-test/t/disabled.def:
        Post-merge fix.
      mysql-test/r/sp.result:
        Post-merge fix.
      sql/sql_yacc.yy:
        Post-merge fix.
      cae1bff7
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-30120 · 84f05952
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/sp.result:
        Merge with 5.0-opt.
      mysql-test/t/sp.test:
        Merge with 5.0-opt.
      84f05952
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 53887d05
      unknown authored
      into  mysql.com:/home/hf/work/29717/my50-29717
      
      53887d05
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-30120 · a91df80c
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      a91df80c
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 80748c21
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      80748c21
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29717/my50-29717 · fb2fb117
      unknown authored
      into  mysql.com:/home/hf/work/29717/my51-29717
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/insert_select.result:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      mysql-test/t/insert_select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      fb2fb117
    • unknown's avatar
      merging · f568a416
      unknown authored
      f568a416
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29717/my41-29717 · 9000e83c
      unknown authored
      into  mysql.com:/home/hf/work/29717/my50-29717
      
      
      mysql-test/t/insert_select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/group_by.result:
        merging
      mysql-test/r/insert_select.result:
        merging
      mysql-test/t/group_by.test:
        merging
      sql/sql_select.h:
        merging
      9000e83c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/029717/my41-29717 · 19d55095
      unknown authored
      into  mysql.com:/home/hf/work/29717/my41-29717
      
      
      sql/sql_select.cc:
        Auto merged
      19d55095
    • unknown's avatar
      Bug #29717 INSERT INTO SELECT inserts values even if · 86ae8436
      unknown authored
       SELECT statement itself returns empty.
      
      As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY'
      can return one row instead of an empty result set.
      
      When GROUP BY only has fields of constant tables
      (with a single row), the optimizer deletes the group_list.
      After that we lose the information about whether we had an
      GROUP BY statement. Though it's important
      as SELECT min(x) from empty_table; and
         SELECT min(x) from empty_table GROUP BY y; have to return
      different results - the first query should return one row,
      second - an empty result set.
      So here we add the 'group_optimized_away' flag to remember this case
      when GROUP BY exists in the query and is removed
      by the optimizer, and check this flag in end_send_group()
      
      
      mysql-test/r/group_by.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/r/insert_select.result:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test result
      mysql-test/t/group_by.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        This is additional testcase that is more basic than the
        original bug's testcase and has the same reason.
      mysql-test/t/insert_select.test:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        test case
      sql/sql_select.cc:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        Remember the 'GROUP BY was optimized away' case in the JOIN::group_optimized
        and check this in the end_send_group()
      sql/sql_select.h:
        Bug #29717 INSERT INTO SELECT inserts values even if
         SELECT statement itself returns empty.
        
        JOIN::group_optimized member added to remember the 'GROUP BY optimied away'
        case
      86ae8436
  3. 30 Jul, 2007 7 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 38435ea9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/t/bigint.test:
        Auto merged
      38435ea9
    • unknown's avatar
      bigint.test: · 1feff728
      unknown authored
        Fixing a typo in the test case.
      
      
      mysql-test/t/bigint.test:
        Fixing a typo in the test case.
      1feff728
    • unknown's avatar
      (Pushing for Andrei) · 47965f56
      unknown authored
      Merge magare.gmz:/home/kgeorge/mysql/work/B27417-5.0-opt
      into  magare.gmz:/home/kgeorge/mysql/work/B27417-5.1-opt
      
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/log.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/set_var.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sp_head.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sql_delete.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sql_insert.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sql_load.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sql_parse.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      sql/sql_update.cc:
        merge of bug 27471 from 5.0-opt to 5.1-opt
      47965f56
    • unknown's avatar
      (pushing for Andrei) · 817a05a6
      unknown authored
      Bug #27417 thd->no_trans_update.stmt lost value inside of SF-exec-stack
        
      Once had been set the flag might later got reset inside of a stored routine 
      execution stack.
      The reason was in that there was no check if a new statement started at time 
      of resetting.
      The artifact affects most of binlogable DML queries. Notice, that multi-update 
      is wrapped up within
        bug@27716 fix, multi-delete bug@29136.
        
      Fixed with saving parent's statement flag of whether the statement modified 
      non-transactional table, and unioning (merging) the value with that was gained 
      in mysql_execute_command.
        
      Resettling thd->no_trans_update members into thd->transaction.`member`;
      Asserting code;
      Effectively the following properties are held.
        
      1. At the end of a substatement thd->transaction.stmt.modified_non_trans_table
         reflects the fact if such a table got modified by the substatement.
         That also respects THD::really_abort_on_warnin() requirements.
      2. Eventually thd->transaction.stmt.modified_non_trans_table will be computed as
         the union of the values of all invoked sub-statements.
         That fixes this bug#27417;
      
      Computing of thd->transaction.all.modified_non_trans_table is refined to base to 
      the stmt's value for all the case including insert .. select statement which 
      before the patch had an extra issue bug@28960.
      Minor issues are covered with mysql_load, mysql_delete, and binloggin of insert in
      to temp_table select. 
        
      The supplied test verifies limitely, mostly asserts. The ultimate testing is defered
      for bug@13270, bug@23333.
      
      
      mysql-test/r/mix_innodb_myisam_binlog.result:
        results changed
      mysql-test/t/mix_innodb_myisam_binlog.test:
        regression test incl the related bug#28960.
      sql/ha_ndbcluster.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/handler.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/handler.h:
        new member added
      sql/log.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/set_var.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sp_head.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
        
        and saving and merging stmt's flag at the end of a substatement.
      sql/sql_class.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_class.h:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_delete.cc:
        correcting basic delete incl truncate branch and multi-delete queries to set
        stmt.modified_non_trans_table;
        optimization to set the flag at the end of per-row loop;
        multi-delete still has an extra issue similar to bug#27716 of multi-update 
        - to be address with bug_29136 fix.
      sql/sql_insert.cc:
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_load.cc:
        eliminating a separate issue where the stmt flag was saved and re-stored after 
        write_record that actually could change it and the change would be lost but 
        should remain permanent;
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      sql/sql_parse.cc:
        initialization to transaction.stmt.modified_non_trans_table at the common part 
        of all types of statements processing - mysql_execute_command().
      sql/sql_table.cc:
        moving the reset up to the mysql_execute_command() caller
      sql/sql_update.cc:
        correcting update query case (multi-update part of the issues covered by other 
        bug#27716 fix)
        thd->transaction.{all,stmt}.modified_non_trans_table
        instead of
        thd->no_trans_update.{all,stmt}
      817a05a6
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · aab601af
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/24989-bug-5.0-opt-mysql
      
      
      sql/ha_innodb.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      aab601af
    • unknown's avatar
      Bug#24989: The DEADLOCK error is improperly handled by InnoDB. · 7186a2d7
      unknown authored
      When innodb detects a deadlock it calls ha_rollback_trans() to rollback the 
      main transaction. But such action isn't allowed from inside of triggers and
      functions. When it happen the 'Explicit or implicit commit' error is thrown
      even if there is no commit/rollback statements in the trigger/function. This
      leads to the user confusion.
      
      Now the convert_error_code_to_mysql() function doesn't call the 
      ha_rollback_trans() function directly but rather calls the
      mark_transaction_to_rollback function and returns an error.
      The sp_rcontext::find_handler() now doesn't allow errors to be caught by the
      trigger/function error handlers when the thd->is_fatal_sub_stmt_error flag
      is set. Procedures are still allowed to catch such errors.
      The sp_rcontext::find_handler function now accepts a THD handle as a parameter.
      The transaction_rollback_request and the is_fatal_sub_stmt_error flags are 
      added to the THD class. The are initialized by the THD class constructor.
      Now the ha_autocommit_or_rollback function rolls back main transaction
      when not in a sub statement and the thd->transaction_rollback_request
      is set.
      The THD::restore_sub_statement_state function now resets the 
      thd->is_fatal_sub_stmt_error flag on exit from a sub-statement.
      
      
      sql/ha_innodb.cc:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        Now the convert_error_code_to_mysql() function doesn't call the
        ha_rollback_trans() function directly but rather calls the
        mark_transaction_to_rollback function and returns an error.
      sql/handler.cc:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        Now the ha_autocommit_or_rollback function rolls back main transaction
        when not in a sub statement and the thd->transaction_rollback_request
        is set.
      mysql-test/r/innodb-big.result:
        Added a test case for the bug#24989: The DEADLOCK error is improperly handled by
        InnoDB.
      mysql-test/t/innodb-big.test:
        Added a test case for the bug#24989: The DEADLOCK error is improperly handled by
        InnoDB.
      sql/sql_class.h:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        The transaction_rollback_request and the is_fatal_sub_stmt_error flags are 
        added to the THD class.
      sql/sql_class.cc:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        Initialization of the transaction_rollback_request and the
        is_fatal_sub_stmt_error flags are added to the THD class constructor.
        The mark_transaction_to_rollback function is added.
        The THD::restore_sub_statement_state function now resets the
        thd->is_fatal_sub_stmt_error flag on exit from a sub-statement.
      sql/sp_rcontext.h:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        The sp_rcontext::find_handler function now accepts a THD handle as a parameter.
        The in_sub_stmt flag is added to the sp_rcontext class.
      sql/sp_rcontext.cc:
        Bug#24989: The DEADLOCK error is improperly handled by InnoDB.
        The sp_rcontext::find_handler() now doesn't allow errors to be caught by the
        trigger/function error handlers when the thd->is_fatal_sub_stmt_error flag
        is set. Instead it tries to find a most inner procedure that isn't called
        directly or indirectly from any function/trigger.
        Procedures are still allowed to catch such errors.
        The sp_rcontext::find_handler function now accepts a THD handle as a parameter.
      7186a2d7
    • unknown's avatar
      Moved the DBUG_ASSERT from bug 28983 to · 137a2fb6
      unknown authored
      a place where it would not obstruct
      correct multithreading.
      
      137a2fb6
  4. 29 Jul, 2007 4 commits
    • unknown's avatar
      Fixed bug #30120. · bfea827a
      unknown authored
      SP with local variables with non-ASCII names crashed the server.
      
      The server replaces SP local variable names with NAME_CONST calls
      when putting statements into the binary log. It used UTF8-encoded
      item names as variable names for the replacement inside NAME_CONST
      calls. However, statement string may be encoded by any
      known character set by the SET NAMES statement.
      The server used byte length of UTF8-encoded names to increment
      the position in the query string that led to array index overrun.
      
      
      sql/item.cc:
        Fixed bug #30120.
        The Item_splocal class constructor has been modified to
        accept new parameter `len_in_q': the byte length of
        variable name in the query string.
      sql/item.h:
        Fixed bug #30120.
        The Item_splocal class has been modified to keep new
        field `len_in_query': the byte length of variable name in
        the query string.
      sql/sp_head.cc:
        Fixed bug #30120.
        The subst_spvars function has been modified to increment
        position in the query string by the lengths of not
        encoded variable names instead of byte length of names
        encoded to UTF-8.
      sql/sql_yacc.yy:
        Fixed bug #30120.
        The simple_ident rule action has been modified to
        pass the byte length of the local variable name token
        to the Item_splocal object constructor.
      mysql-test/t/sp.test:
        Updated test case for bug #30120.
      mysql-test/r/sp.result:
        Updated test case for bug #30120.
      bfea827a
    • unknown's avatar
      disabled.def: · a26d2bab
      unknown authored
        ddl_i18n_koi8r.test has been disabled to ignore bug #30120.
      
      
      mysql-test/t/disabled.def:
        ddl_i18n_koi8r.test has been disabled to ignore bug #30120.
      a26d2bab
    • unknown's avatar
      sp_head.cc: · da1c98da
      unknown authored
        Post-merge fix.
      
      
      sql/sp_head.cc:
        Post-merge fix.
      da1c98da
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 8056fcc7
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/sp_head.cc:
        Merge with 5.0-opt.
      8056fcc7
  5. 28 Jul, 2007 2 commits