1. 27 Oct, 2021 3 commits
  2. 26 Oct, 2021 1 commit
    • Eugene Kosov's avatar
      MDEV-18543 IMPORT TABLESPACE fails after instant DROP COLUMN · d74d9596
      Eugene Kosov authored
      ALTER TABLE IMPORT doesn't properly handle instant alter metadata.
      This patch makes IMPORT read, parse and apply instant alter metadata at the
      very beginning of operation. So, cases when source table has some metadata
      and destination table doesn't have it now works fine.
      
      DISCARD already removes instant metadata so importing normal table into
      instant table worked fine before this patch.
      
      decrypt_decompress(): decrypts and decompresses page if needed
      
      handle_instant_metadata(): this should be the first thing to read source
      table. Basically, it applies instant metadata to a destination
      dict_table_t object. This is the first thing to read FSP flags so
      all possible checks of it were moved to this function.
      
      PageConverter::update_index_page(): it doesn't now read instant metadata.
      This logic were moved into handle_instant_metadata()
      
      row_import::match_flags(): this is a first part row_import::match_schema().
      As a separate function it's used by handle_instant_metadata().
      
      fil_space_t::is_full_crc32_compressed(): added convenient function
      
      ha_innobase::discard_or_import_tablespace(): do not reload table definition
      to read instant metadata because handle_instant_metadata() does it better.
      The reverted code was originally added in
      4e7ee166
      
      ANONYMOUS_VAR: this is a handy thing to use along with make_scope_exit()
      
      full_crc32_import.test shows different results, because no
      dict_table_close() and dict_table_open_on_id() happens.
      Thus, SHOW CREATE TABLE shows a little bit older table definition.
      d74d9596
  3. 21 Oct, 2021 15 commits
  4. 20 Oct, 2021 8 commits
    • Marko Mäkelä's avatar
    • Nikita Malyavin's avatar
      MDEV-20131 Assertion `!pk->has_virtual()' failed · d10c42b4
      Nikita Malyavin authored
      Assertion `!pk->has_virtual()' failed in dict_index_build_internal_clust
      while creating PRIMARY key longer than possible to store in the page.
      
      This happened because the key was wrongly deduced as Long UNIQUE supported,
      however PRIMARY KEY cannot be of that type. The main reason is that
      only 8 bytes are used to store the hash, see HA_HASH_FIELD_LENGTH.
      
      This is also why HA_NOSAME flag is removed (and caused the assertion in
      turn) in open_table_from_share:
            if (key_info->algorithm == HA_KEY_ALG_LONG_HASH)
            {
              key_part_end++;
              key_info->flags&= ~HA_NOSAME;
            }
      
      To make it unique, the additional check is done by
      check_duplicate_long_entries call from ha_write_row, and similar one from
      ha_update_row.
      
      PRIMARY key is already forbidden, which is checked by the first test in
      main.long_unique, however is_hash_field_needed was wrongly deduced to true
      in mysql_prepare_create_table in this particular case.
      
      FIX:
      
      * Improve the check for Key::PRIMARY type
      * Simplify is_hash_field_needed deduction for a more neat reading
      d10c42b4
    • Marko Mäkelä's avatar
      Update libmariadb · 69b3de83
      Marko Mäkelä authored
      69b3de83
    • Marko Mäkelä's avatar
      MDEV-22627 Failing assertion: dict_tf2_is_valid(flags, flags2) · b06e8167
      Marko Mäkelä authored
      create_table_info_t::innobase_table_flags(): Refuse to create
      a PAGE_COMPRESSED table with PAGE_COMPRESSION_LEVEL=0 if also
      innodb_compression_level=0.
      
      The parameter value innodb_compression_level=0 was only somewhat
      meaningful for testing or debugging ROW_FORMAT=COMPRESSED tables.
      For the page_compressed format, it never made any sense, and the
      check in dict_tf_is_valid_not_redundant() that was added in
      72378a25 (MDEV-12873) would cause
      the server to crash.
      b06e8167
    • Nikita Malyavin's avatar
      MDEV-22445 Crash on HANDLER READ NEXT after XA PREPARE · caebe151
      Nikita Malyavin authored
      The assertion is absolutely correct since no data access is possible after
      XA PREPARE.
      
      The check is added in mysql_ha_read.
      caebe151
    • Nikita Malyavin's avatar
      MDEV-26262 frm is corrupted after ER_EXPRESSION_REFERS_TO_UNINIT_FIELD · 1811fd51
      Nikita Malyavin authored
      This is a duplicate of MDEV-18278 89936f11, but I will add an
      additional assertion
      
      Description:
      
      The frm corruption should not be reported during CREATE TABLE. Normally
      it doesn't, and the data to fill TABLE is taken by open_table_from_share
      call. However, the vcol data is stored as SQL string in
      table->s->vcol_defs.str and is anyway parsed on each table open.
      It is impossible [or hard] to avoid, because it's hard to clone the
      expression tree in general (it's easier to parse).
      
      Normally parse_vcol_defs should only fail on semantic errors. If so,
      error_reported is set to true. Any other failure is not expected during
      table creation. There is either unhandled/unacknowledged error, or
      something went really wrong, like memory reject. This all should be
      asserted anyway.
      
      Solution:
      * Set *error_reported=true for the forward references check;
      * Assert for every unacknowledged error during table creation.
      1811fd51
    • Nikita Malyavin's avatar
    • Daniel Black's avatar
      MDEV-26363 Passwords incorrectly expiring after MySQL5.7 -> MariaDB10.3 -> 10.4+ upgrades · 4590f8b4
      Daniel Black authored
      MySQL-5.7 mysql.user tables have a last_password_changed field.
      
      Because before MariaDB-10.4 remained oblivious to this, the act of creating
      users or otherwise changing a users row left the last_password_field with 0.
      
      Running a MariaDB-10.4 instance on this would work correctly, until mysql_upgrade
      is run, when this 0 value immediately translates to password expired
      state.
      
      MySQL-5.7 relied on the password_expired enum to indicate password
      expiry so we aren't going to activate password that were expired in
      MySQL-5.7.
      
      Thanks Hans Borresen for the bug report and review of the fix.
      4590f8b4
  5. 19 Oct, 2021 5 commits
    • Vicențiu Ciorbaru's avatar
      Fix Groonga crash on MIPS: Correctly link to libatomic · 1388845e
      Vicențiu Ciorbaru authored
      MIPS (and possibly other) platforms require linking against libatomic to
      support 64-bit atomic integers. Groonga was failing to do so and all related
      tests were failing with an atomics relocation error on MIPS.
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      1388845e
    • Vicențiu Ciorbaru's avatar
      Fix MIPS build failure: Handle unaligned buffers in connect's TYPBLK class · a33c1082
      Vicențiu Ciorbaru authored
      On MIPS platforms (and probably others) unaligned memory access results in a
      bus error. In the connect storage engine, block data for some data formats is
      stored packed in memory and the TYPBLK class is used to read values from it.
      Since TYPBLK does not have special handling for this packed memory, it can
      quite easily result in unaligned memory accesses.
      
      The simple way to fix this is to perform all accesses to the main buffer
      through memcpy. With GCC and optimizations turned on, this call to memcpy is
      completely optimized away on architectures where unaligned accesses are ok
      (like x86).
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      a33c1082
    • Vicențiu Ciorbaru's avatar
      Link with libatomic to enable C11 atomics support · f502ccbc
      Vicențiu Ciorbaru authored
      Some architectures (mips) require libatomic to support proper
      atomic operations. Check first if support is available without
      linking, otherwise use the library.
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      Jessica Clarke <jrtc27@debian.org>
      Vicențiu Ciorbaru <vicentiu@mariadb.org>
      f502ccbc
    • Alexey Botchkov's avatar
      MDEV-24585 Assertion `je->s.cs == nice_js->charset()' failed in json_nice. · 1a54cf62
      Alexey Botchkov authored
      We should set the charset in
      Item_func_json_format::fix_length_and_dec().
      1a54cf62
    • Marko Mäkelä's avatar
      MDEV-14804 innodb.update_time failed in buildbot with wrong result · 53167031
      Marko Mäkelä authored
      Let us use a minimal-size buffer pool to ensure that page flushing
      will be slow enough so that LRU eviction cannot be avoided.
      53167031
  6. 18 Oct, 2021 5 commits
    • Oleksandr Byelkin's avatar
      MDEV-26299: Some views force server (and mysqldump) to generate invalid SQL for their definitions · 27bf57fd
      Oleksandr Byelkin authored
      Do not print illegal table field names for non-top-level SELECT list,
      they will not be refered in any case but create problem for parsing
      of printed result.
      27bf57fd
    • Brandon Nesterenko's avatar
      MDEV-25284: Assertion `info->type == READ_CACHE || info->type == WRITE_CACHE' failed · 2291f8ef
      Brandon Nesterenko authored
      Problem:
      ========
      This patch addresses two issues.
      
      First, if a CHANGE MASTER command is issued and an error happens
      while locating the replica’s relay logs, the logs can be put into an
      invalid state where future updates fail and future CHANGE MASTER
      calls crash the server. More specifically, right before a replica
      purges the relay logs (part of the `CHANGE MASTER TO` logic), the
      relay log is temporarily closed with state LOG_TO_BE_OPENED. If the
      server errors in-between the temporary log closure and purge, i.e.
      during the function find_log_pos, the log should be closed.
      MDEV-25284 reveals the log is not properly closed.
      
      Second, upon issuing a RESET SLAVE ALL command, a slave’s GTID
      filters are not cleared (DO_DOMAIN_IDS, IGNORE_DOMIAN_IDS,
      IGNORE_SERVER_IDS). MySQL had a similar bug report, Bug #18816897,
      which fixed this issue to clear IGNORE_SERVER_IDS after issuing
      RESET SLAVE ALL in version 5.7.
      
      Solution:
      =========
      
      To fix the first problem, the CHANGE MASTER error handling logic was
      extended to transition the relay log state to LOG_CLOSED from
      LOG_TO_BE_OPENED.
      
      To fix the second problem, the RESET SLAVE ALL logic is extended to
      clear the domain_id filter and ignore_server_ids.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      2291f8ef
    • Oleksandr Byelkin's avatar
      MDEV-26650: Failed ALTER USER/GRANT statement removes the password from the cache · c9a9ae65
      Oleksandr Byelkin authored
      Starting from 10.4 AUTH is not part of ACL_USER so changes have to be done
      over a copy, and bring in the cache only in case of success.
      c9a9ae65
    • Nayuta Yanagisawa's avatar
      MDEV-19866 follow-up · 39f63156
      Nayuta Yanagisawa authored
      Cherry-picking the fix for MDEV-19866 changes the behavior of
      the Spider slightly. So, I modified a existing test to match
      the new behavior.
      39f63156
    • Kentoku SHIBA's avatar
      MDEV-19866 With a Spider table, a SELECT with WHERE involving primary key... · a4666509
      Kentoku SHIBA authored
      MDEV-19866 With a Spider table, a SELECT with WHERE involving primary key breaks following SELECTs (#1356)
      
      Change checking scanning partitions from part_spec to part_info->read_partitions
      a4666509
  7. 15 Oct, 2021 2 commits
    • Alexander Barkov's avatar
      A clean-up patch for MDEV-23408: fixing test failure on Windows · 5f63f5dc
      Alexander Barkov authored
      Schema and table names in a veiw FRM files are:
      - in upper case on Linux
      - in lower case on Windows
      
      Using the LOWER() function when displaying an FRM file fragment,
      to avoid the OS-specific difference.
      5f63f5dc
    • Vicențiu Ciorbaru's avatar
      MDEV-17964: Assertion `status == 0' failed in add_role_user_mapping_action · 9e6c3838
      Vicențiu Ciorbaru authored
      This happens upon CREATE USER and DROP ROLE.
      
      The underlying problem is that our HASH implementation shuffles elements
      around when performing an update or delete. This means that when doing a
      scan through the HASH table by index, in search of elements to delete or
      update one must restart the scan to make sure nothing is missed if at least
      one delete / update happened.
      
      More specifically, what happened in this case:
      The hash has 131 element, DROP ROLE removes the element
      [119]. Its [119]->next was element [129], so [129] is moved to [119].
      Now we need to compact the hash, removing the last element [130]. It
      gets one bit off its hash value and becomes element [2]. The existing
      element [2] is moved to [129], and old [130] is moved to [2].
      
      We cannot simply move [130] to [129] and make [2]->next=130, it won't
      work if [2] is itself in the collision list and doesn't belong in [2].
      
      The handle_grant_struct code assumed that it is safe to continue by only
      reexamining the currently modified / deleted element index, but that is
      not true.
      
      Missing to delete an element in the hash triggered the assertion in
      the test case. DROP ROLE would not clear all necessary role->role or
      role->user mappings.
      
      To fix the problem we ensure that the scan is restarted, only if an
      element was deleted / updated, similar to how bubble-sort keeps sorting
      until it finds no more elements to swap.
      9e6c3838
  8. 14 Oct, 2021 1 commit
    • Alexander Barkov's avatar
      MDEV-23408 Wrong result upon query from I_S and further Assertion `!alias_arg... · a2a42f4e
      Alexander Barkov authored
      MDEV-23408 Wrong result upon query from I_S and further Assertion `!alias_arg || strlen(alias_arg->str) == alias_arg->length' failed with certain connection charset
      
      There were two independent problems which lead to the crash
      and to the non-relevant records returned in I_S queries:
      
      - The code in the I_S implementation was not secure
        about values with 0x00 bytes.
        It's fixed by using check_db_name() and check_table_name()
        inside make_table_name_list(), and by adding the test for
        0x00 inside check_table_name().
      
      - The code in Item_string::print() did not convert
        strings without introducers when restoring
        the CREATE VIEW statement from an Item tree.
        This made wrong literals inside the "query" line in the view FRM file
        in cases when the VIEW parse time
        character_set_client!=character_set_connection.
        That's fixed by adding a proper conversion.
      
        This change also fixed a similar problem in SHOW PROCEDURE CODE -
        the literals were displayed in wrong character set in SP instructions
        in cases when the SP parse time
        character_set_client!=character_set_connection.
      a2a42f4e