1. 14 Jun, 2007 4 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · 0662a9b7
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.1-opt
      
      
      client/mysqltest.c:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/include/mix1.inc:
        merging
      mysql-test/r/innodb_mysql.result:
        merging
      sql/sql_select.cc:
        merging
      0662a9b7
    • unknown's avatar
      Merge mysql.com:/d2/hf/mrg/mysql-5.0-opt · 167751b3
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.1-opt
      
      
      mysql-test/r/type_decimal.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      167751b3
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · dcd779cb
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28991-5.1-opt
      
      
      dcd779cb
    • unknown's avatar
      Bug #28991: rpl_events failure in pushbuild · 37559e3d
      unknown authored
      In tests waiting on a timeout is not deterministic enough
      to make sure that an event actually finished executing.
      Fixed the test by waiting in a loop and checking the effect
      that the event is supposed to produce.
      
      
      mysql-test/include/rpl_events.inc:
        Bug #28991: wait until event has taken effect
      37559e3d
  2. 13 Jun, 2007 2 commits
    • unknown's avatar
      Fixed bug #28980: the result of ROUND(<decimal expr>,<int column>) · c0ebdff9
      unknown authored
      was erroneously converted to double, while the result of
      ROUND(<decimal expr>, <int literal>) was preserved as decimal.
      As a result of such a conversion the value of ROUND(D,A) could
      differ from the value of ROUND(D,val(A)) if D was a decimal expression.
      
      Now the result of the ROUND function is never converted to 
      double if the first argument is decimal.  
      
      
      mysql-test/r/type_decimal.result:
        Added a test case for bug #28980.
      mysql-test/t/type_decimal.test:
        Added a test case for bug #28980.
      c0ebdff9
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 1ab7b066
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/autopush/5.1o-bug27634
      
      
      1ab7b066
  3. 12 Jun, 2007 12 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · ab84fb1d
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27816-5.1-opt
      
      
      sql/sql_table.cc:
        Auto merged
      ab84fb1d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · 04447645
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-opt
      
      
      04447645
    • unknown's avatar
      5.0-opt -> 5.1-opt merge · 95ef943b
      unknown authored
      95ef943b
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · e53dfc6d
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-opt
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/item_func.cc:
        merge of 5.0-opt -> 5.1-opt
      sql/sql_insert.cc:
        merge of 5.0-opt -> 5.1-opt
      sql/structs.h:
        merge of 5.0-opt -> 5.1-opt
      tests/mysql_client_test.c:
        merge of 5.0-opt -> 5.1-opt
      e53dfc6d
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · acc7614a
      unknown authored
      into  mysql.com:/home/hf/work/28757/my51-28757
      
      
      acc7614a
    • unknown's avatar
      Bug #28757 Test program / embedded server crash in test "unsafe_binlog_innodb" · 0a67a6e5
      unknown authored
      the reported test failure is fixed by the patch to 28333,
      but there's a bit more to fix in the test itself - to
      drop tables created in this test at the test's beginning.
      
      
      mysql-test/include/unsafe_binlog.inc:
        remove tables created later in this test
        number error codes changed with the appropriate ER_something
      mysql-test/r/unsafe_binlog_innodb.result:
        test result fixed
      0a67a6e5
    • unknown's avatar
      Bug#27634: group_by test fails · a8bb10ac
      unknown authored
      On many architectures, e.g. 68000, x86, the double registers have higher precision 
      than the IEEE standard prescribes. When compiled with flags -O and higher, some double's 
      go into registers and therefore have higher precision. In one test case the cost 
      information of the best and second-best key were close enough to be influenced by this 
      effect, causing a failed test in distribution builds.
      
      Fixed by removing some rows from the table in question so that cost information is not
      influenced by decimals beyond standard definition of double.
      
      
      mysql-test/r/group_by.result:
        Bug#27634: Altered test reslut. The only difference in the results is in the 'rows' column.
      mysql-test/t/group_by.test:
        Bug#27634: Altered test case to avoid the corner case where excess precision causes 
        non-minimum costs to appear minimal.
      a8bb10ac
    • unknown's avatar
      removed compilation warning · 119412f8
      unknown authored
      119412f8
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · e4cd7e98
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28992-5.0-opt
      
      
      e4cd7e98
    • unknown's avatar
      Bug #28992: trigger fails in pushbuild · 030bb02b
      unknown authored
       - fixed wrong test case for bug 20903
       - closed the dangling connections in trigger.test
       - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
       - fixed an omission in GET_LOCK() : assign the thread_id when
          acquiring the lock.
      
      
      mysql-test/r/trigger.result:
        Bug #28992: test case updated
      mysql-test/t/trigger.test:
        Bug #28992: test case updated. dangling connections closed.
      sql/item_func.cc:
        Bug #28992: 
         - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
         - fixed an omission in GET_LOCK() : assign the thread_id when
            acquiring the lock.
      030bb02b
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e43380e8
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28934-5.0-opt
      
      
      e43380e8
    • unknown's avatar
      Bug #28934: server crash when receiving malformed com_execute packets · e164c08e
      unknown authored
       Sometimes a parameter slot may not get a value because of the protocol
       data being plain wrong.
       Such cases should be detected and handled by returning an error.
       Fixed by checking data stream constraints where possible (like maximum
       length) and reacting to the case where a value cannot be constructed.
      
      
      sql/sql_prepare.cc:
        Bug #28934: 
         - check for a parameter slot not being set because 
            of wrong data
         - check if the length read from the stream is not
            greater than the maximum length of the field
      tests/mysql_client_test.c:
        Bug #28934: test case
      e164c08e
  4. 11 Jun, 2007 6 commits
    • unknown's avatar
      Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't. · ccf393b6
      unknown authored
      When the INSERT .. ON DUPLICATE KEY UPDATE has to update a matched row but
      the new data is the same as in the record then it returns as if
      no rows were inserted or updated. Nevertheless the row is silently
      updated. This leads to a situation when zero updated rows are reported 
      in the case when data has actually been changed.
      
      Now the write_record function updates a row only if new data differs from
      that in the record.
      
      
      sql/sql_insert.cc:
        Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't.
        Now the write_record function updates a row only if new data differs from
        that in the record.
      mysql-test/r/insert_update.result:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      mysql-test/t/insert_update.test:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      ccf393b6
    • unknown's avatar
      grant2.result: · 023f3dd0
      unknown authored
        Post merge fix.
      
      
      mysql-test/r/grant2.result:
        Post merge fix.
      023f3dd0
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · bbef78f4
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/grant2.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/r/grant2.result:
        SCCS merged
      mysql-test/r/information_schema.result:
        SCCS merged
      mysql-test/t/information_schema.test:
        SCCS merged
      sql/sql_table.cc:
        SCCS merged
      bbef78f4
    • unknown's avatar
      error_simulation.result, item.cc, subselect.result, error_simulation.test: · 2b42067f
      unknown authored
        Post merge fix.
      
      
      mysql-test/t/error_simulation.test:
        Post merge fix.
      mysql-test/r/subselect.result:
        Post merge fix.
      mysql-test/r/error_simulation.result:
        Post merge fix.
      sql/item.cc:
        Post merge fix.
      2b42067f
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 68a530d4
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/filesort.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manually merged
      mysql-test/t/subselect.test:
        Manually merged
      68a530d4
    • unknown's avatar
      item_cmpfunc.cc, field.cc, sql_insert.cc, sql_class.h, sql_yacc.yy: · 8becfb5f
      unknown authored
        Post merge fix.
      
      
      sql/sql_yacc.yy:
        Post merge fix.
      sql/sql_insert.cc:
        Post merge fix.
      sql/sql_class.h:
        Post merge fix.
      sql/item_cmpfunc.cc:
        Post merge fix.
      sql/field.cc:
        Post merge fix.
      8becfb5f
  5. 10 Jun, 2007 1 commit
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 237a1d22
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Manually merged
      mysql-test/r/innodb_mysql.result:
        Manually merged
      mysql-test/r/type_datetime.result:
        Manually merged
      mysql-test/t/type_datetime.test:
        Manually merged
      sql/field.h:
        Manually merged
      sql/sql_select.cc:
        Manually merged
      sql/sql_yacc.yy:
        Manually merged
      tests/mysql_client_test.c:
        Manually merged
      237a1d22
  6. 09 Jun, 2007 10 commits
    • unknown's avatar
      compiler warning fix · 59d139eb
      unknown authored
      59d139eb
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 9c93c5b9
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      9c93c5b9
    • unknown's avatar
      Bug#28149 overflow in some "SHOW STATUS"-variables · 71aa571d
      unknown authored
      changed bytes_received, bytes_sent status variables to longlong
      
      
      sql/mysqld.cc:
        changed bytes_received, bytes_sent status variables to longlong
      sql/sql_class.h:
        changed bytes_received, bytes_sent status variables to longlong
      sql/sql_show.cc:
        changed bytes_received, bytes_sent status variables to longlong
      sql/structs.h:
        changed bytes_received, bytes_sent status variables to longlong
      71aa571d
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6329053f
      unknown authored
      into  mysql.com:/home/hf/work/28333/my50-28333
      
      
      6329053f
    • unknown's avatar
      Bug#28266 IS_UPDATABLE field on VIEWS table in I_S database is wrong · ce4e9f75
      unknown authored
      IS_UPDATABLE flag is set to 'yes' when the view has at least one updatable column and
      the algorithm is not 'temporary'.
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/r/view.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      mysql-test/t/view.test:
        test case
      sql/sql_show.cc:
        IS_UPDATABLE flag is set to 'yes' when the view has at least one updatable column and
        the algorithm is not 'temporary'.
      ce4e9f75
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · a7f51325
      unknown authored
      into  mysql.com:/home/hf/work/28333/my51-28333
      
      
      a7f51325
    • unknown's avatar
      compilation error fix · f65930a9
      unknown authored
      
      mysql-test/include/have_archive.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_blackhole.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_csv.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_exampledb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_federated_db.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_innodb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_multi_ndb.inc:
        test fix(according to new 'support' column values)
      mysql-test/include/have_ndb.inc:
        test fix(according to new 'support' column values)
      mysql-test/r/information_schema.result:
        result fix
      f65930a9
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · cb460d88
      unknown authored
      into  mysql.com:/home/hf/work/28333/my50-28333
      
      
      cb460d88
    • unknown's avatar
      Merge mysql.com:/home/hf/work/28333/my50-28333 · c3684150
      unknown authored
      into  mysql.com:/home/hf/work/28333/my51-28333
      
      
      client/mysqltest.c:
        Auto merged
      c3684150
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d1a8d7f4
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28754-5.0-opt
      
      
      d1a8d7f4
  7. 08 Jun, 2007 5 commits
    • unknown's avatar
      Bug #28333 Test "flush" tries to create a new thread - on only one platform · 99b4321a
      unknown authored
      on PPC/Debian Linux default stack size for a thread is too big.
      As we use default thread settings in mysqltest, the
      thread creation fails if we create lots of threads (as it
      happens in flush.test). So now stack size is explicitly specified
      for the mysqltest
      
      
      client/mysqltest.c:
        Bug #28333 Test "flush" tries to create a new thread - on only one platform
        
        specify appropriate stack size for the 'query' thread
      99b4321a
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 22d488e4
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28811
      
      
      22d488e4
    • unknown's avatar
      Bug #27816: Log tables ran with partitions crashes the server · a9ce1388
      unknown authored
       when logging is enabled.
      Currently the partition engine doesn't allow log tables to
      be partitioned. But this was not checked and the server crashed.
      Fixed by adding a check in ALTER TABLE to disable partitioning the
      log tables.
      While working on the cause of the problem improved the way the log
      thread structures are initialized before opening the log tables.
      
      
      mysql-test/r/partition.result:
        Bug #27816: test case
      mysql-test/t/partition.test:
        Bug #27816: test case
      sql/log.cc:
        Bug #27816: optional
         Improved initialization of the log threads before opening 
         the log table.
         Remedies problems that arise from open_table() et. al. 
         depending on a correctly initialized thd.
         Prerequisite for handling partitioned log tables :
         they call the parser while reading the .frm file.
      sql/sql_table.cc:
        Bug #27816: throw an error when paritioning the log tables : 
         not supported by the partition engine.
      a9ce1388
    • unknown's avatar
      Bug#27684 undocumented difference between SHOW ENGINES and I_S.ENGINES · 4c2f2ac5
      unknown authored
      Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
      made SHOW ENGINES work via the common function iter_schema_engines.
      There in no test case because an engine (except of MyISAM) may be not compiled or disabled
      which may affect the test result.
      
      
      sql/sql_parse.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      sql/sql_show.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
        For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
        made SHOW ENGINES work via the common function iter_schema_engines.
      4c2f2ac5
    • unknown's avatar
      Bug #28754: RPM builds differ from tar.gz in "ALTER ... RENAME" on views · 2b274a60
      unknown authored
       When constructing the path to the original .frm file ALTER .. RENAME
       was unnecessary (and incorrectly) lowercasing the whole path when not 
       on a case-insensitive filesystem.
       This path should not be modified because of lower_case_table_names
       as it is already in the correct case according to that setting.
       Fixed by removing the lowercasing.
       Unfortunately testing this would require running the tests on a case
       sensitive filesystem in a directory that has uppercase letters.
       This cannot be guaranteed in all setups so no test case added.
      
      
      sql/sql_table.cc:
        Bug #28754: don't downcase the .frm path
      2b274a60