1. 04 May, 2022 1 commit
    • Anel Husakovic's avatar
      MDEV-28391: table_exists procedure fails when arguments contain escaped... · 06a4193c
      Anel Husakovic authored
      MDEV-28391: table_exists procedure fails when arguments contain escaped backticks as an quoted identifiers
      
      - When arguments to the procedure contain quote in the name, procedure fails with parsing error.
        The reason was because additional quoting is done when testing TEMPORARY table with the same name.
      - Reviewed by: <wlad@mariadb.com>
      06a4193c
  2. 03 May, 2022 3 commits
    • Marko Mäkelä's avatar
      MDEV-28465 Some calls to btr_pcur_close() are unnecessary · bc113b87
      Marko Mäkelä authored
      The function btr_pcur_close() is being invoked on local variables
      even when no cleanup needs to be done. In particular, for B-tree
      indexes (not SPATIAL INDEX), unless btr_pcur_store_position()
      was invoked in the past, there is no need to invoke btr_pcur_close().
      
      On purge and rollback, we will retain btr_pcur_close(&pcur)
      because otherwise some ./mtr --suite=innodb_gis tests would leak memory.
      bc113b87
    • Marko Mäkelä's avatar
      c844a588
    • Marko Mäkelä's avatar
      MDEV-28454 Latching order violation (and hang) in ibuf_insert_low · caa985e6
      Marko Mäkelä authored
      Since commit 2ca11234 (MDEV-26217)
      the function trx_t::commit(std::vector<pfs_os_file_t>&)
      holds exclusive lock_sys.latch while invoking fil_delete_tablespace(),
      which in turn may wait for change buffer tree latches in
      ibuf_delete_for_discarded_space().
      
      ibuf_insert_low(): If a shared lock_sys.latch cannot be acquired
      without waiting, refuse to buffer the insert. In this way, a
      deadlock with a DDL operation will be avoided.
      
      ibuf_insert_to_index_page(), ibuf_delete(): Remove redundant calls to
      record locking. In ibuf_insert_low() we already ensured that no record
      locks existed on the page. No locks can be added before the buffered
      changes have been merged.
      caa985e6
  3. 02 May, 2022 2 commits
  4. 30 Apr, 2022 2 commits
  5. 29 Apr, 2022 3 commits
    • Marko Mäkelä's avatar
      MDEV-28445 Secondary index locking invokes costly trx_sys.get_min_trx_id() · b6e41e38
      Marko Mäkelä authored
      lock_sec_rec_read_check_and_lock(): Remove a redundant check
      for trx_sys.get_min_trx_id(). This would be checked in
      lock_sec_rec_some_has_impl() anyway. Also, test the
      cheapest conditions first.
      
      lock_sec_rec_some_has_impl(): Replace trx_sys.get_min_trx_id()
      with trx_sys.find_same_or_older() that is much easier to evaluate.
      
      Inspired by mysql/mysql-server@0a0c0db97e9c9705f4dffc629a770fb87a60cb22
      b6e41e38
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-28443: MDEV-15250 causes latch order violation · 0f717d03
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =======
      Index page latches must be acquired before undo page latches.
      In trx_t::apply_log(), InnoDB acquired undo log page latch
      before an index page latch.
      
      Solution:
      ========
      In trx_t::apply_log(), InnoDB should copy the undo log
      record and release the undo log block before applying
      it on online indexes.
      0f717d03
    • Marko Mäkelä's avatar
      MDEV-27274: DROP TABLE does not delete detached InnoDB files · 8c1c6130
      Marko Mäkelä authored
      In commit 1bd681c8 (MDEV-25506 part 3)
      the way how DDL transactions delete files was rewritten.
      Only files that are actually attached to InnoDB tablespaces would be
      deleted, and only after the DDL transaction was durably committed.
      
      After a failed ALTER TABLE...IMPORT TABLESPACE, any data files that
      the user might have moved to the data directory will not be attached
      to the InnoDB data dictionary. Therefore, DROP TABLE would not
      attempt to delete those files, and a subsequent CREATE TABLE would
      fail. The logic was that the user who created the files outside the
      DBMS is still the owner of those files, and InnoDB should not delete
      those files because an "ownership transfer" (IMPORT TABLESPACE) was
      not successfully completed.
      
      However, not deleting those detached files could surprise users.
      
      ha_innobase::delete_table(): Even if no tablespace exists, try to
      delete any files that might match the table name.
      
      Reviewed by: Thirunarayanan Balathandayuthapani
      8c1c6130
  6. 27 Apr, 2022 1 commit
  7. 26 Apr, 2022 11 commits
  8. 25 Apr, 2022 7 commits
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-15250 UPSERT during ALTER TABLE results in 'Duplicate entry' error for alter · 4b80c11f
      Thirunarayanan Balathandayuthapani authored
      - InnoDB DDL results in `Duplicate entry' if concurrent DML throws
      duplicate key error. The following scenario explains the problem
      
      connection con1:
        ALTER TABLE t1 FORCE;
      
      connection con2:
        INSERT INTO t1(pk, uk) VALUES (2, 2), (3, 2);
      
      In connection con2, InnoDB throws the 'DUPLICATE KEY' error because
      of unique index. Alter operation will throw the error when applying
      the concurrent DML log.
      
      - Inserting the duplicate key for unique index logs the insert
      operation for online ALTER TABLE. When insertion fails,
      transaction does rollback and it leads to logging of
      delete operation for online ALTER TABLE.
      While applying the insert log entries, alter operation
      encounters 'DUPLICATE KEY' error.
      
      - To avoid the above fake duplicate scenario, InnoDB should
      not write any log for online ALTER TABLE before DML transaction
      commit.
      
      - User thread which does DML can apply the online log if
      InnoDB ran out of online log and index is marked as completed.
      Set online log error if apply phase encountered any error.
      It can also clear all other indexes log, marks the newly
      added indexes as corrupted.
      
      - Removed the old online code which was a part of DML operations
      
      commit_inplace_alter_table() : Does apply the online log
      for the last batch of secondary index log and does frees
      the log for the completed index.
      
      trx_t::apply_online_log: Set to true while writing the undo
      log if the modified table has active DDL
      
      trx_t::apply_log(): Apply the DML changes to online DDL tables
      
      dict_table_t::is_active_ddl(): Returns true if the table
      has an active DDL
      
      dict_index_t::online_log_make_dummy(): Assign dummy value
      for clustered index online log to indicate the secondary
      indexes are being rebuild.
      
      dict_index_t::online_log_is_dummy(): Check whether the online
      log has dummy value
      
      ha_innobase_inplace_ctx::log_failure(): Handle the apply log
      failure for online DDL transaction
      
      row_log_mark_other_online_index_abort(): Clear out all other
      online index log after encountering the error during
      row_log_apply()
      
      row_log_get_error(): Get the error happened during row_log_apply()
      
      row_log_online_op(): Does apply the online log if index is
      completed and ran out of memory. Returns false if apply log fails
      
      UndorecApplier: Introduced a class to maintain the undo log
      record, latched undo buffer page, parse the undo log record,
      maintain the undo record type, info bits and update vector
      
      UndorecApplier::get_old_rec(): Get the correct version of the
      clustered index record that was modified by the current undo
      log record
      
      UndorecApplier::clear_undo_rec(): Clear the undo log related
      information after applying the undo log record
      
      UndorecApplier::log_update(): Handle the update, delete undo
      log and apply it on online indexes
      
      UndorecApplier::log_insert(): Handle the insert undo log
      and apply it on online indexes
      
      UndorecApplier::is_same(): Check whether the given roll pointer
      is generated by the current undo log record information
      
      trx_t::rollback_low(): Set apply_online_log for the transaction
      after partially rollbacked transaction has any active DDL
      
      prepare_inplace_alter_table_dict(): After allocating the online
      log, InnoDB does create fulltext common tables. Fulltext index
      doesn't allow the index to be online. So removed the dead
      code of online log removal
      
      Thanks to Marko Mäkelä for providing the initial prototype and
      Matthias Leich for testing the issue patiently.
      4b80c11f
    • Marko Mäkelä's avatar
      1a66e3f8
    • Marko Mäkelä's avatar
      Remove redundant innodb-page_compression_ tests · cba13079
      Marko Mäkelä authored
      These were replaced with innodb.innodb_page_compressed
      in commit 35095c45
      cba13079
    • Marko Mäkelä's avatar
      Clean up the page_compressed tests · 35095c45
      Marko Mäkelä authored
      It suffices to test compression with one record. Restarting the
      server is not really needed; we are exercising the log based recovery
      in other tests, such as mariabackup.page_compression_level.
      35095c45
    • Marko Mäkelä's avatar
      Cleanup: Remove IF_VALGRIND · 4faef6e2
      Marko Mäkelä authored
      The purpose of the compress() wrapper my_compress_buffer() was twofold:
      silence Valgrind warnings about uninitialized memory access before
      zlib 1.2.4, and have PERFORMANCE_SCHEMA instrumentation of some zlib
      related memory allocation. Because of PERFORMANCE_SCHEMA, we cannot
      trivially replace my_compress_buffer() with compress().
      
      az_open(): Remove a crc32() call. Any CRC of the empty string is 0.
      4faef6e2
    • Marko Mäkelä's avatar
      Do not disable --symbolic-links on Valgrind (or MSAN) · 232af0c7
      Marko Mäkelä authored
      The option --symbolic-links was originally disabled by default under
      Purify (and later Valgrind) in 51156c5a
      without any explanation.
      232af0c7
    • Alexander Barkov's avatar
      MDEV-27690 Crash on `CHARACTER SET csname COLLATE DEFAULT` in column definition · 4ed30b2a
      Alexander Barkov authored
      Adding a 10.6 specific test from the MDEV
      4ed30b2a
  9. 22 Apr, 2022 1 commit
    • Marko Mäkelä's avatar
      MDEV-27094 Debug builds include useless InnoDB "disabled" options · c009ce7d
      Marko Mäkelä authored
      This is a backport of commit 4489a89c
      in order to remove the test innodb.redo_log_during_checkpoint
      that would cause trouble in the DBUG subsystem invoked by
      safe_mutex_lock() via log_checkpoint(). Before
      commit 7cffb5f6
      these mutexes were of different type.
      
      The following options were introduced in
      commit 2e814d47 (mariadb-10.2.2)
      and have little use:
      
      innodb_disable_resize_buffer_pool_debug had no effect even in
      MariaDB 10.2.2 or MySQL 5.7.9. It was introduced in
      mysql/mysql-server@5c4094cf4971eebab89da4ee4ae92c71f69cd524
      to work around a problem that was fixed in
      mysql/mysql-server@2957ae4f990bf3aed25822b0ce15d3ccad0b54b6
      (but the parameter was not removed).
      
      innodb_page_cleaner_disabled_debug and innodb_master_thread_disabled_debug
      are only used by the test innodb.redo_log_during_checkpoint
      that will be removed as part of this commit.
      
      innodb_dict_stats_disabled_debug is only used by that test,
      and it is redundant because one could simply use
      innodb_stats_persistent=OFF or the STATS_PERSISTENT=0 attribute
      of the table in the test to achieve the same effect.
      c009ce7d
  10. 21 Apr, 2022 9 commits