1. 21 Aug, 2005 2 commits
    • unknown's avatar
      Cleanup during review of new pushed code · 0776999d
      unknown authored
      
      include/my_global.h:
        Safer macros to avoid possible overflows
      sql/item_cmpfunc.cc:
        Simple optimization
      sql/sp_head.cc:
        Indentation fixes
        Remove not needed "else" levels
        Added error checking for 'new'
        Simpler reseting of thd->spcont in execute_procedure
      sql/sql_base.cc:
        Faster new
      sql/sql_lex.cc:
        Use 'TRUE' instead of 'true'
      sql/sql_parse.cc:
        Faster new
      sql/sql_view.cc:
        No need to set 'tables' as it's not used
      sql/table.cc:
        Simpler DBUG_ASSERT()
      0776999d
    • unknown's avatar
      Merge mishka.local:/tmp/skr99/mysql-5.0 · 916e1938
      unknown authored
      into  mishka.local:/home/my/mysql-5.0
      
      
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      916e1938
  2. 20 Aug, 2005 1 commit
    • unknown's avatar
      Fixes during review of new pushed code · 8cc25933
      unknown authored
      Fixed new bug when running a SP without a default database
      
      
      mysql-test/r/information_schema.result:
        Added test to cover changes made in default handling
      mysql-test/r/sp-security.result:
        Added test when executing SP without a default database
      mysql-test/t/information_schema.test:
        Added test to cover changes made in default handling
      mysql-test/t/sp-security.test:
        Added test when executing SP without a default database
      sql/item_strfunc.cc:
        Removed wrong push
      sql/mysqld.cc:
        Indentation fix
      sql/sql_base.cc:
        Use share->db instead of share->table_cache_key
        Remove assert that can never fail (because of test in previous row)
      sql/sql_db.cc:
        Allow empty database name when called from SP
        (To allow on run without a default database)
      sql/sql_parse.cc:
        Added comment
      sql/sql_show.cc:
        Indentation fixes
        Simplified code by checking for 'wrong' condition first and doing continue instead of going down one level
        Simplified precision and decimal handling
      8cc25933
  3. 19 Aug, 2005 16 commits
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1a6a2322
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      1a6a2322
    • unknown's avatar
      Fix for BUG#10957 "stop instance, issued after flush instances causes IM to crash" · d539d713
      unknown authored
      Recommited with post-review fixes
      
      
      server-tools/instance-manager/instance.cc:
        fix behaviour of monitoring routines: they should not  rely on the fact that instance object
        which was used when the instances started exists at stop(). Instead routines should save the
        name of the instance and look for it in the instance_map when needed.
      server-tools/instance-manager/instance.h:
        new functions declared. functions, which were converted to static removed from the class.
      server-tools/instance-manager/instance_options.cc:
        fix valgrind warning
      d539d713
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · da9dd0e8
      unknown authored
      into  mysql.com:/home/timka/mysql/src/5.0-2486
      
      da9dd0e8
    • unknown's avatar
      A fix and a test case for "Bug #12168 'DECLARE CONTINUE HANDLER FOR · cf6736c8
      unknown authored
      NOT FOUND ...' in conditional handled incorrectly".
      
      Whenever we remove an instruction during optimization, we need to
      adjust instruction numbers (ip - instruction pointer) stored in all
      instructions. In addition to that, sp_instr_hpush_jump, which 
      corresponds to DECLARE CONTINUE HANDLER needs adjustment for m_handler,
      which holds the number of instruction with the continue handler.
      In the bug report, a wrong ip stored in m_handler was pointing at 
      FETCH, which resulted in an error message and abnormal SP termination.
      The fix is to just remove m_handler member from sp_instr_hpush_jump,
      as it's always points to the instruction next to the DECLARE
      statement itself (m_ip+1).
      
      
      mysql-test/r/sp.result:
        Test results fixed (Bug#12168)
      mysql-test/t/sp.test:
        A test case for Bug#12168 "'DECLARE CONTINUE HANDLER FOR NOT
        FOUND ...' in conditional handled incorrectly"
      sql/sp_head.cc:
        Remove m_handler (the number of continue handler instruction)
        as it always equal to m_ip+1
      sql/sp_head.h:
        Remove m_handler (the number of continue handler instruction)
        as it always equal to m_ip+1
      cf6736c8
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · 357514e0
      unknown authored
      into  mysql.com:/home/timka/mysql/src/5.0-2486
      
      357514e0
    • unknown's avatar
      WL#2486 - natural and using join according to SQL:2003 · 57e82913
      unknown authored
      - Corrected problem with N-way nested natural joins in PS mode.
      - Code cleanup
      - More asserts to check consistency of name resolution contexts
      - Fixed potential memory leak of name resolution contexts
      
      
      mysql-test/r/join.result:
        - Corrected problem with N-way nested natural joins in PS mode.
      mysql-test/t/join.test:
        - Corrected problem with N-way nested natural joins in PS mode.
      sql/item.h:
        - Fixed potential memory leak.
      sql/sql_base.cc:
        - the local context of Item_fields that participate in TABLE_LIST::on_cond for
          natural joins is correctly set to the tables where the corresponding fields
          originate from.
        - removed unused variables
        - correct allocation of contexts
      sql/sql_parse.cc:
        - correct allocation of contexts for JOIN ON conditions.
      sql/table.cc:
        - added asserts to check the consistency of name resolution contexts
      sql/table.h:
        - added asserts to check the consistency of name resolution contexts
      57e82913
    • unknown's avatar
      btr0sea.c: · ceb2d665
      unknown authored
        Add diagnostic code to track a crash in adaptive hash indexes; the crash may happen if block->index == NULL
      
      
      innobase/btr/btr0sea.c:
        Add diagnostic code to track a crash in adaptive hash indexes; the crash may happen if block->index == NULL
      ceb2d665
    • unknown's avatar
      fixed test after merge · d3c1f9ac
      unknown authored
      d3c1f9ac
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 66844025
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug2-5.0
      
      66844025
    • unknown's avatar
      row0sel.c: · 53d1232d
      unknown authored
        Temporarily remove error print if MySQL tries to do a SELECT even though trx->n_mysql_tables_in_use is 0. We must return the error print when the lock count of cursors is properly implemented (Bug #12456)
      
      
      innobase/row/row0sel.c:
        Temporarily remove error print if MySQL tries to do a SELECT even though trx->n_mysql_tables_in_use is 0. We must return the error print when the lock count of cursors is properly implemented (Bug #12456)
      53d1232d
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 293daaa8
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug2-5.0
      
      293daaa8
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.0 · ed00a3be
      unknown authored
      into lmy004.:/work/mysql-5.0-clean
      
      ed00a3be
    • unknown's avatar
      test fix for fix of 12591 · bb02f25b
      unknown authored
      
      mysql-test/r/innodb.result:
        fix result for fix of 12591
      mysql-test/t/innodb.test:
        fix test for fix of 12591
      bb02f25b
    • unknown's avatar
      changes in row operation · 57af2764
      unknown authored
      57af2764
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 86965de1
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug2-5.0
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      86965de1
    • unknown's avatar
      Merge jlindstrom@bk-internal.mysql.com:/home/bk/mysql-5.0 · 72657883
      unknown authored
      into  hundin.mysql.fi:/home/jan/mysql-5.0
      
      72657883
  4. 18 Aug, 2005 21 commits