1. 11 Jul, 2007 1 commit
    • unknown's avatar
      Fixed bug #29360. · 0920c75b
      unknown authored
      The special `zero' enum value was coerced to the normal
      empty string enum value during a field-to-field copy.
      This bug affected CREATE ... SELECT statements and
      SELECT aggregate GROUP BY enum field statements.
      
      Also this bug made unnecessary warnings during
      the execution of CREATE ... SELECT statements:
      Warning       1265    Data truncated for column...
      
      
      sql/field_conv.cc:
        Fixed bug #29360.
        The field_conv function has been modified to properly convert
        the special `zero' enum value between enum fields.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29360.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29360.
      mysql-test/r/type_ranges.result:
        Updated test case for bug #29360.
      0920c75b
  2. 10 Jul, 2007 3 commits
  3. 09 Jul, 2007 1 commit
    • unknown's avatar
      Bug #29070: Error in spatial index · 2ad26498
      unknown authored
      1. Threat MBR for a key as double[] and convert it only
      when about to store it on disk.
      2. Remove the redundant function get_double().
      
      
      myisam/sp_key.c:
        Bug #29070: 
        1. threat MBR for a key as double[] and convert it only
        when about to store it on disk.
        2. remove the redundant function get_double()
      mysql-test/r/gis-rtree.result:
        Bug #29070: test case
      mysql-test/t/gis-rtree.test:
        Bug #29070: test case
      2ad26498
  4. 08 Jul, 2007 3 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 25cba450
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29461-bug-5.0-opt-mysql
      
      
      25cba450
    • unknown's avatar
      Bug#29461: Sort order of the collation wasn't used when comparing characters · bfa027e7
      unknown authored
      with the space character.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      strings/ctype-simple.c:
        Bug#29461: Sort order of the collation wasn't used when comparing characters
        with the space character.Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      bfa027e7
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f045039d
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      f045039d
  5. 07 Jul, 2007 8 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 3561de50
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29417
      
      
      mysql-test/r/type_newdecimal.result:
        Manual merge.
      mysql-test/t/type_newdecimal.test:
        Manual merge.
      3561de50
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 7ec0820b
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      7ec0820b
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 79435f37
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      79435f37
    • unknown's avatar
      Fixed bug #29417. · 0671e30a
      unknown authored
      An assertion abort could occur for some grouping queries that employed 
      decimal user variables with assignments to them.
      
      The problem appeared the constructors of the class Field_new_decimal
      because the function my_decimal_length_to_precision did not guarantee
      returning decimal precision not greater than DECIMAL_MAX_PRECISION.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29417.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29417.
      sql/field.cc:
        Fixed bug #29417.
        An assertion abort could occur for some grouping queries that employed 
        decimal user variables with assignments to them.
        
        The problem appeared the constructors of the class Field_new_decimal
        because the function my_decimal_length_to_precision did not guarantee
        returning decimal precision not greater than DECIMAL_MAX_PRECISION.
        
        Now if the precision returned by calls to my_decimal_length_to_precision
        in the constructors of the class Field_new_decimal is greater than 
        DECIMAL_MAX_PRECISION the precision is set to this value.
      0671e30a
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 16fc3a27
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/t/innodb_mysql.test:
        Merge with 5.0 (main).
      16fc3a27
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1 · 95e4b2e3
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      
      95e4b2e3
    • unknown's avatar
      Fixed bug #29415. · 3756819e
      unknown authored
      The cast operation ignored the cases when the precision and/or the scale exceeded
      the limits, 65 and 30 respectively. No errors were reported in these cases.
      For some queries this may lead to an assertion abort.
      
      Fixed by throwing errors for such cases.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29415.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29415.
      3756819e
    • unknown's avatar
      Bug #29543 GCov information not written in case of crash. · 87e1a302
      unknown authored
      For GCov builds, if the server crashes, the normal exit handler for writing
      coverage information is not executed due to the abnormal termination.
      
      Fix this by explicitly calling the __gcov_flush function in our crash handler.
      
      
      87e1a302
  6. 06 Jul, 2007 7 commits
  7. 05 Jul, 2007 6 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 50373d1a
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      50373d1a
    • unknown's avatar
      Fixed bug #29442. · 725b4971
      unknown authored
      The SELECT INTO OUTFILE FIELDS ENCLOSED BY digit or minus sign,
      followed by the same LOAD DATA INFILE statement, used wrond encoding
      of non-string fields contained the enclosed character in their text
      representation.
      
      Example:
        SELECT 15, 9 INTO OUTFILE 'text' FIELDS ENCLOSED BY '5';
      
      Old encoded result in the text file:
        5155 595
               ^ was decoded as the 1st enclosing character of the 2nd field;
              ^ was skipped as garbage;
        ^    ^ was decoded as a pair of englosing characters of the 1st field;
            ^   was decoded as traling space of the first field;
          ^^ was decoded as a doubled enclosed character.
      
      New encoded result in the text file:
        51\55 595
        ^   ^ pair of enclosing characters of the 1st field;
          ^^ escaped enclosed character.
      
      
      
      sql/sql_class.h:
        Fixed bug #29442.
        The NUMERIC_CHARS macro constant has been defined to enumerate
        all possible characters of a numeric value text representation.
        The select_export::is_unsafe_field_sep boolean flag has been added
        to apply the encoding algorithm to non-string values when it is
        necessary.
      sql/sql_class.cc:
        Fixed bug #29442.
        The select_export::send_data method has been modified to encode text
        representation of fields of all data types like string fields.
      mysql-test/t/loaddata.test:
        Updated test case for bug #29442.
      mysql-test/r/loaddata.result:
        Updated test case for bug #29442.
      725b4971
    • unknown's avatar
      Bug #29166: · 6139d34c
      unknown authored
      AsText() needs to know the maximum number of
      characters a IEEE double precision value can
      occupy to make sure there's enough buffer space.
      The number was too small to hold all possible
      values and this caused buffer overruns.
      Fixed by correcting the calculation of the 
      maximum digits in a string representation of an
      IEEE double precision value as printed by 
      String::qs_append(double).
      
      
      mysql-test/r/gis.result:
        Bug #29166: test case
      mysql-test/t/gis.test:
        Bug #29166: test case
      sql/spatial.cc:
        Bug #29166: correct calculation of the maximum digits in
        a string representation of a double
      6139d34c
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-4.1-engines · dc308c51
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-5.0-engines
      
      
      mysys/hash.c:
        Auto merged
      dc308c51
    • unknown's avatar
      BUG#27564 - Valgrind: UDF does not cleanup correctly · b7bf9725
      unknown authored
      Dropping an user defined function may cause server crash in
      case this function is still in use by another thread.
      
      The problem was that our hash implementation didn't update
      hash link list properly when hash_update() was called.
      
      
      mysys/hash.c:
        The following requirement wasn't met by hash_update() function
        causing corruption of hash links list:
        
        After a record was unlinked from the old chain during update, it
        holds random position. By the chance this position is equal to
        position for the first element in the new chain. That means
        updated record is the only record in the new chain.
      b7bf9725
    • unknown's avatar
      Fixed bug #29392. · 5d88b654
      unknown authored
      This bug may manifest itself for select queries over a multi-table view
      that includes an ORDER BY clause in its definition. If the select list of 
      the query contains references to the same view column with different
      aliases the names of the columns in the result output will be nevertheless
      the same, coinciding with one of the alias.
      
      The bug happened because the method Item_ref::get_tmp_table_item that
      was inherited by the class Item_direct_view_ref ignored the fact that
      the name of the view column reference must be inherited by the fields
      of the temporary table that was created in order to get the result rows
      sorted.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #29392.
      mysql-test/t/view.test:
        Added a test case for bug #29392.
      sql/item.h:
        Fixed bug #29392.
        This bug may manifest itself for select queries over a multi-table view
        that includes an ORDER BY clause in its definition. If the select list of 
        the query contains references to the same view column with different
        aliases the names of the columns in the result output will be nevertheless
        the same, coinciding with one of the alias.
        
        The bug happened because the method Item_ref::get_tmp_table_item that
        was inherited by the class Item_direct_view_ref ignored the fact that
        the name of the view column reference must be inherited by the fields
        of the temporary table that was created in order to get the result rows
        sorted.
        
        Fixed by providing a proper implementation of the get_tmp_table_item 
        method for the Item_direct_view_ref class.
      5d88b654
  8. 04 Jul, 2007 2 commits
  9. 03 Jul, 2007 9 commits
    • unknown's avatar
      loaddata.result, loaddata.test: · 8d035c57
      unknown authored
        Updated test case for bug #29294.
      
      
      mysql-test/t/loaddata.test:
        Updated test case for bug #29294.
      mysql-test/r/loaddata.result:
        Updated test case for bug #29294.
      8d035c57
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · c700a776
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      mysql-test/r/loaddata.result:
        Merge with 4.1-opt.
      mysql-test/t/loaddata.test:
        Merge with 4.1-opt.
      c700a776
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · f57e4b99
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      
      f57e4b99
    • unknown's avatar
      loaddata.result, loaddata.test: · bc3e0086
      unknown authored
        Test case update for bug #29294.
      
      
      mysql-test/t/loaddata.test:
        Test case update for bug #29294.
      mysql-test/r/loaddata.result:
        Test case update for bug #29294.
      bc3e0086
    • unknown's avatar
      sql_class.cc: · 19a5d20c
      unknown authored
        Windows compilation error fix.
      
      
      sql/sql_class.cc:
        Windows compilation error fix.
      19a5d20c
    • unknown's avatar
      Fixed bug #29294. · 166d3c91
      unknown authored
      The `SELECT 'r' INTO OUTFILE ... FIELDS ENCLOSED BY 'r' ' statement
      encoded the 'r' string to a 4 byte string of value x'725c7272'
      (sequence of 4 characters: r\rr).
      The LOAD DATA statement decoded this string to a 1 byte string of
      value x'0d' (ASCII Carriage Return character) instead of the original
      'r' character.
      The same error also happened with the FIELDS ENCLOSED BY clause
      followed by special characters: 'n', 't', 'r', 'b', '0', 'Z' and 'N'.
      
      NOTE 1: This is a result of the undocumented feature: the LOAD DATA INFILE
      recognises 2-byte input sequences like \n, \t, \r and \Z in addition
      to documented 2-byte sequences: \0 and \N. This feature should be
      documented (here backspace character is a default ESCAPED BY character,
      in the real-life example it may be any ESCAPED BY character).
      
      NOTE 2, changed behaviour:
      Now the `SELECT INTO OUTFILE' statement with the `FIELDS ENCLOSED BY'
      clause followed by one of: 'n', 't', 'r', 'b', '0', 'Z' or 'N' characters
      encodes this special character itself by doubling it ('r' --> 'rr'),
      not by prepending it with an escape character.
      
      
      sql/sql_class.h:
        Fixed bug #29294.
        The ESCAPE_CHARS macro constant is defined to enumerate
        symbolic names of espace-sequences like  '\n', '\t' etc.
        The select_export::is_ambiguous_field_sep field has been added
        to distinguish special values of the field_sep field from
        another values (see ESCAPE_CHARS).
      sql/sql_class.cc:
        Fixed bug #29294.
        The select_export::send_data method has been modified to
        encode special values of the field_sep field by
        doubling of those values instead of prepending them with a
        value of the escape_char field.
        Example: The SELECT 'r' INTO OUTFILE FIELDS ENCLOSED BY 'r'
        now produces the 'rr' output string instead of x'5c72'
        (i.e. instead of sequence of 2 bytes: \ and r).
      sql/sql_load.cc:
        Fixed bug #29294.
        Added commentary for the READ_INFO::unescape method.
      mysql-test/t/loaddata.test:
        Updated test case for bug #29294.
      mysql-test/r/loaddata.result:
        Updated test case for bug #29294.
      166d3c91
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 7edcebc9
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.0.b27345
      
      
      7edcebc9
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 81194444
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28983-2-5.0-opt
      
      
      81194444
    • unknown's avatar
      Bug #28983: 'reset master' in multiple threads and innodb tables · 841cf405
      unknown authored
      asserts debug binary
      
      We can't reliably check if the binary log is opened without 
      acquiring its mutex. 
      Fixed by removing this check.
      
      
      sql/log.cc:
        Bug #28983: 
        can't reliably check if bin_log is open outside of its mutex
      841cf405