1. 20 Dec, 2007 2 commits
  2. 11 Dec, 2007 1 commit
    • unknown's avatar
      Bug#31990: MINUTE() and SECOND() return bogus results when used on a DATE · 77b1f323
      unknown authored
      HOUR(), MINUTE(), ... returned spurious results when used on a DATE-cast.
      This happened because DATE-cast object did not overload get_time() method
      in superclass Item. The default method was inappropriate here and
      misinterpreted the data.
      
      Patch adds missing method; get_time() on DATE-casts now returns SQL-NULL
      on NULL input, 0 otherwise. This coincides with the way DATE-columns
      behave.
      
      Also fixes similar bug in Date-Field now.
      
      
      mysql-test/r/cast.result:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      mysql-test/r/type_date.result:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-fields.
      mysql-test/t/cast.test:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      mysql-test/t/type_date.test:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-fields.
      sql/field.cc:
        Add get_time() method to DATE-field object to overload
        the method in Field superclass that would return spurious
        results. Return zero-result.
      sql/field.h:
        Add get_time() declaration to date-field class
      sql/item_timefunc.cc:
        Add get_time() method to DATE-cast object to overload
        the method in Item superclass that would return spurious
        results. Return zero-result; flag NULL if input was NULL.
      sql/item_timefunc.h:
        Add get_time() declaration to DATE-cast object.
      77b1f323
  3. 10 Dec, 2007 1 commit
    • unknown's avatar
      Bug #31177: Server variables can't be set to their current values · 82162aa5
      unknown authored
      fixes for SLES10
      
      
      mysql-test/r/change_user.result:
        It's unsigned.
      mysys/my_getopt.c:
        Failsafe no longer needed, we handle signedness correctly now.
      sql/set_var.cc:
        ha_rows can be derived from all kinds of types, but
        they're all unsigned. Display it as such.
      tests/mysql_client_test.c:
        cannot easily check this here due to types.
        check with Alik whether we need this on top
        of change_user.test.
      82162aa5
  4. 06 Dec, 2007 4 commits
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · 1d3d3893
      unknown authored
      initialise limits properly for getopt_ll_limit()
      (fixes falcon_opt test)
      
      
      sql/sql_plugin.cc:
        initialise limits properly for getopt_ll_limit()
      1d3d3893
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 631b58d8
      unknown authored
      into  mysql.com:/misc/mysql/31177/51-31177
      
      631b58d8
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31177/50-31177 · a65665af
      unknown authored
      into  mysql.com:/misc/mysql/31177/51-31177
      
      
      BitKeeper/deleted/.del-ps_6bdb.result:
        Auto merged
      mysys/my_getopt.c:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        manual merge
      mysql-test/r/ps_3innodb.result:
        manual merge
      mysql-test/r/ps_4heap.result:
        manual merge
      mysql-test/r/ps_5merge.result:
        manual merge
      mysql-test/suite/ndb/r/ps_7ndb.result:
        manual merge
      mysql-test/t/variables.test:
        manual merge
      sql/mysqld.cc:
        NULL
      sql/item_func.cc:
        Signedness is already propagated properly for user-vars in 5.1.
      sql/set_var.cc:
        add correct handling of signedness when assigning 64-bit
        values to sysvars.
      sql/set_var.h:
        cleanliness.
      a65665af
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · 240f0f27
      unknown authored
      additional fixes for BDB and correct assignment of both signed
      and unsigned 64-bit data to unsigned system variables
      
      
      mysql-test/r/ps_2myisam.result:
        account for UNSIGNED_FLAG
      mysql-test/r/ps_3innodb.result:
        account for UNSIGNED_FLAG
      mysql-test/r/ps_4heap.result:
        account for UNSIGNED_FLAG
      mysql-test/r/ps_5merge.result:
        account for UNSIGNED_FLAG
      mysql-test/r/ps_6bdb.result:
        account for UNSIGNED_FLAG
      mysql-test/r/ps_7ndb.result:
        account for UNSIGNED_FLAG
      mysys/my_getopt.c:
        We have correct signed/unsigned information now, so we no longer
        need to err on the side of caution.
      sql/item_func.cc:
        Copy unsigned info over from entry so the item's data
        correctly describe it.
      sql/mysqld.cc:
        BDB log buffer size: default can't be less than minimum
      sql/set_var.cc:
        Handle signedness of in-values correctly when assigning to
        unsigned types, all the way up to 64-bit. Use handler from
        all three unsigned sysvar types.
      sql/set_var.h:
        thd_ulonglong: Override default check with one for unsigned types
      240f0f27
  5. 04 Dec, 2007 3 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · f671f07e
      unknown authored
      into  dl145s.mysql.com:/data0/mhansson/my51-bug30234
      
      f671f07e
    • unknown's avatar
      test case fix · 739b8555
      unknown authored
      739b8555
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · b2af1235
      unknown authored
      additional fixes for 64-bit
      ---
      Merge mysql.com:/misc/mysql/31177/50-31177
      into  mysql.com:/misc/mysql/31177/51-31177
      ---
      Bug#31177: Server variables can't be set to their current values
      
      additional 5.1 fixes (for plugins)
      
      
      mysql-test/t/variables.test:
        replace 32-bit and 64-bit values
        ---
        manual merge
      mysys/my_getopt.c:
        'mod' no longer used.
        on 64-bit, limit to (signed) (LONG)LONG_MAX to prevent badness
        in classes using longlong.
      sql/sql_plugin.cc:
        handle signedness in plugin-vars so we won't hit an assert()
        in getopt_*_limit_value()
      b2af1235
  6. 03 Dec, 2007 5 commits
  7. 02 Dec, 2007 2 commits
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · 522dee3c
      unknown authored
      extra 5.1 fixes
      
      
      mysql-test/t/order_fill_sortbuf-master.opt:
        If we set the variable below minimum, we'll get a warning
        at start-up that we don't want in the tests.
      522dee3c
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · e617ba3f
      unknown authored
      into  mysql.com:/misc/mysql/31177/51-31177
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/index_merge_myisam.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/type_bit.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      e617ba3f
  8. 01 Dec, 2007 6 commits
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · 549abb44
      unknown authored
      5.1+ specific fixes (plugins etc.)
      
      
      include/my_getopt.h:
        make both ull and ll global
      mysql-test/r/index_merge_myisam.result:
        we throw warnings to the client, yea, verily
      mysql-test/r/innodb.result:
        we throw warnings to the client, yea, verily
      mysql-test/r/variables.result:
        we throw warnings to the client, yea, verily
      mysql-test/t/variables.test:
        correct result, is multiple of variable's block_size now
      mysys/my_getopt.c:
        export getopt_ll_limit_value(), check for integer wrap-around
        in it, same as in ull variant.  Only print warnings to reporter
        when caller didn't ask for diagnostics, otherwise assume caller
        will handle any warnings (id est, throw them client-wards)
      sql/mysqld.cc:
        correct signedness of "concurrent-insert"
      sql/sql_plugin.cc:
        Throw sys-var out-of-range warnings client-wards for
        plugins, too.
      549abb44
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31177/50-31177 · ae789bd6
      unknown authored
      into  mysql.com:/misc/mysql/31177/51-31177
      
      
      include/m_string.h:
        Auto merged
      include/my_getopt.h:
        Auto merged
      mysql-test/r/delayed.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/key_cache.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/type_bit.result:
        Auto merged
      mysql-test/r/type_bit_innodb.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      BitKeeper/deleted/.del-index_merge.result:
        Auto merged
      sql/set_var.cc:
        Auto merged
      mysql-test/r/variables.result:
        manual merge
      client/mysql.cc:
        manual merge
      client/mysqltest.c:
        manual merge
      mysql-test/r/subselect.result:
        manual merge
      mysys/my_getopt.c:
        manual merge
      sql/mysqld.cc:
        manual merge
      ae789bd6
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 31b601b8
      unknown authored
      into  mysql.com:/misc/mysql/32707/51-32707
      
      
      sql/protocol.cc:
        Auto merged
      31b601b8
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 978757a8
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my51-mrg
      
      978757a8
    • unknown's avatar
      merging · 98d7aa32
      unknown authored
      98d7aa32
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 6f6ad7ad
      unknown authored
      into  mysql.com:/misc/mysql/32180/51-32180
      
      6f6ad7ad
  9. 30 Nov, 2007 15 commits
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/my50-mrg · b492cb09
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my51-mrg
      
      
      sql/mysqld.cc:
        Auto merged
      sql/protocol.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      include/mysql_com.h:
        merging
      libmysqld/lib_sql.cc:
        merging
      mysql-test/r/federated.result:
        merging
      mysql-test/t/federated.test:
        merging
      storage/federated/ha_federated.h:
        mergin
      b492cb09
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/my41-mrg · 31549fa8
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my50-mrg
      
      
      include/mysql_com.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      31549fa8
    • unknown's avatar
      Merge mysql.com:/home/hf/work/32624/my50-32624 · 46be75f8
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my50-mrg
      
      46be75f8
    • unknown's avatar
      Merge mysql.com:/home/hf/work/32374/my50-32374 · b7c0474b
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my50-mrg
      
      b7c0474b
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31890/my51-31890 · 9f20f559
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my51-mrg
      
      
      mysql-test/r/partition.result:
        SCCS merged
      mysql-test/t/partition.test:
        merging
      9f20f559
    • unknown's avatar
      Merge mysql.com:/home/hf/work/30430/my51-30430 · 4034fd11
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my51-mrg
      
      4034fd11
    • unknown's avatar
      Bug #30430 crash:./mtr --embedded-server --ps-protocol cache_innodb func_misc... · 8c18a8d0
      unknown authored
      PS-protocol data is stored in different format - the MYSQL_RECORDS->data
      contains the link to the record content, not to array of the links to
      the field's contents. So we have to handle it separately for
      embedded-server query cache.
      
      
      libmysqld/emb_qcache.cc:
        Bug #30430 crash:./mtr --embedded-server --ps-protocol cache_innodb func_misc...
        
        ps_protocol data now stored in it's particular way.
      libmysqld/emb_qcache.h:
        Bug #30430 crash:./mtr --embedded-server --ps-protocol cache_innodb func_misc...
        
        Querycache_stream::load_char/store_char  ->
          load_uchar/store_uchar
      mysql-test/r/func_misc.result:
        Bug #30430 crash:./mtr --embedded-server --ps-protocol cache_innodb func_misc...
        
        test result
      mysql-test/t/func_misc.test:
        Bug #30430 crash:./mtr --embedded-server --ps-protocol cache_innodb func_misc...
        
        the test uses t2 table, so let's make sure it doesn't exist befor the start
      8c18a8d0
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31900/my41-31900 · ffb2c59c
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my41-mrg
      
      ffb2c59c
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug9481/my51-bug9481 · d31817dd
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      d31817dd
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug9481/my50-bug9481 · 59b32666
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug9481/my51-bug9481
      
      
      sql/sql_class.h:
        Null merge.
      sql/sql_insert.cc:
        Null merge.
      tests/mysql_client_test.c:
        Null merge.
      59b32666
    • unknown's avatar
      Bug#32775 problems with SHOW EVENTS and Information_Schema · 93a1bac5
      unknown authored
      removed unnecessary privilege checks for I_S schema
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/events.cc:
        There is no events in I_S so we don't need to execute check_access here.
      sql/sql_parse.cc:
        removed unnecessary check
      93a1bac5
    • unknown's avatar
      Bug #32374 crash with filesort when selecting from federated table and view. · 17b47894
      unknown authored
      filesort() uses file->estimate_rows_upper_bound() call to allocate
      internal buffers. If this function returns a value smaller than
      a number of row that will be returned later in find_all_keys(),
      that can cause server crash.
      Fixed by implementing ha_federated::estimate_rows_upper_bound() to
      return maximum possible number of rows.
      Present estimation for FEDERATED always returns 0 if the linked to the VIEW.
      
      
      mysql-test/r/federated.result:
        Bug #32374 crash with filesort when selecting from federated table and view.
        
        test result
      mysql-test/t/federated.test:
        Bug #32374 crash with filesort when selecting from federated table and view.
        
        test case
      sql/ha_federated.cc:
        Bug #32374 crash with filesort when selecting from federated table and view.
        
        ha_federated::estimate_rows_upper_bound() implemented
      sql/ha_federated.h:
        Bug #32374 crash with filesort when selecting from federated table and view.
        
        ha_federated::estimate_rows_upper_bound() interface
      17b47894
    • unknown's avatar
      Merge mysql.com:/misc/mysql/32707/50-32707 · ebb51b92
      unknown authored
      into  mysql.com:/misc/mysql/32707/51-32707
      
      
      sql/protocol.cc:
        manual merge
      ebb51b92
    • unknown's avatar
      Merge mysql.com:/misc/mysql/32707/41-32707 · fcec20ee
      unknown authored
      into  mysql.com:/misc/mysql/32707/50-32707
      
      
      sql/protocol.cc:
        manual merge
      fcec20ee
    • unknown's avatar
      Bug#31177: Server variables can't be set to their current values · a7ff6e90
      unknown authored
      Default values of variables were not subject to upper/lower bounds
      and step, while setting variables was. Bounds and step are also
      applied to defaults now; defaults are corrected quietly, values
      given by the user are corrected, and a correction-warning is thrown
      as needed. Lastly, very large values could wrap around, starting
      from 0 again. They are bounded at the maximum value for the
      respective data-type now if no lower maximum is specified in the
      variable's definition.
      
      
      client/mysql.cc:
        correct maxima in options array
      client/mysqltest.c:
        adjust minimum for "sleep" option so default value is no longer
        out of bounds.
      include/m_string.h:
        ullstr() - the unsigned brother of llstr()
      include/my_getopt.h:
        Flag if we bounded the value (that is, correct anything aside from
        making value a multiple of block-size)
      mysql-test/r/delayed.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/index_merge.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/innodb.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/innodb_mysql.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/key_cache.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/packet.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/ps.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/subselect.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/type_bit.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/type_bit_innodb.result:
        We throw a warning now when we adjust out of range parameters.
      mysql-test/r/variables.result:
        correct results: bounds and step apply to variables' default values, too
      mysql-test/t/variables.test:
        correct results: bounds and step apply to variables' default values, too
      mysys/my_getopt.c:
        - apply bounds/step to default values of variables (based on work by serg)
        - print complaints about incorrect values for variables (truncation etc.,
          by requestion of consulting)
        - if no lower maximum is specified in variable definition, bound unsigned
          values at their maximum to prevent wrap-around
        - some calls to error_reporter had a \n, some didn't. remove \n from calls,
          let reporter-function handle it, so the default reporter behaves like that
          in mysqld
      sql/mysql_priv.h:
        correct RANGE_ALLOC_BLOCK_SIZE (cleared with monty)
      sql/mysqld.cc:
        correct maxima to correct data-type.
        correct minima where higher than default.
        correct range-alloc-block-size.
        correct inno variables so GET_* corresponds to actual variable's type.
      sql/set_var.cc:
        When the new value for a variable is out of bounds, we'll send the
        client a warning (but not if the value was simply not a multiple of
        'blocksize').  sys_var_thd_ulong had this, sys_var_long_ptr_global
        didn't; broken out and streamlined to avoid duplication of code.
      strings/llstr.c:
        ullstr() - the unsigned brother of llstr()
      a7ff6e90
  10. 29 Nov, 2007 1 commit
    • unknown's avatar
      Bug #29085 A small double precision number becomes zero. · a8dada1e
      unknown authored
      Denormalized DOUBLE-s can't be properly handled by old MIPS processors.
      So we need to enable specific mode for them so IRIX will do use
      software round to handle such numbers. 
      
      
      sql/mysqld.cc:
        Bug #29085 A small double precision number becomes zero.
        
        reset_floating_point_exeption() renamed as set_proper_floating_point_mode()
        #ifdef __sgi code added to enable denormalized DOUBLE-s on IRIX
      a8dada1e