An error occurred fetching the project authors.
  1. 06 Feb, 2005 1 commit
    • patg@krsna.patg.net's avatar
      WL# 2094 · 0a48c5b5
      patg@krsna.patg.net authored
      This patch contains all that my previous patch (1.1814) contained, with the addition of using cli_fetch_lengths for
      handling binary data (Bar noted this on the review of 1.1814, Guilhem suggested using cli_fetch_lenghts by 
      making available via removal of static in method definition and declaration in mysql.h, but
      Konstantin had some reservations, but he said to commit the patch using this anyway,
      and I suppose this can be discussed. I abandoned 1.1814 because Monty made a couple
      fixes to my code as well as formatting changes, and I thought it would just be easier
      to hand-edit my changes into a fresh clone and then make a patch. 
      
      The reason for using cli_fetch_lengths is so that I can correctly get the length of
      the field I am setting into the field. I was previously using 'strlen' but Bar pointed out this
      won't correctly get the length of binary data and is also less effecient. Upon testing,
      it was in fact verified that binary data in a blob table was being inserted correctly,
      but not being retrieved correctly, all due to not having the correct value for the
      field:
      
      (*field)->store(row[x], strlen(row[x]), &my_charset_bin);
      
      was changed to:
      
      (*field)->store(row[x], lengths[x], &my_charset_bin);
      
      lengths being a unsigned long pointer to the values of the field lengths from a 
      MYSQL_ROW.
      
      Since the server doesn't have the function "mysql_fetch_lengths" available, I tried 
      to use "result->lengths", but this isn't set, so I finally successfully used 
      cli_fetch_lenghts, which does give the correct lengths, and now the binary data gets
      retrieved correctly.
      
      I've also run the code through indent-ex and am using Brian's vimrc to ensure correct formatting!
      
      This code passes the entire test suite, without any errors or warning on both my 
      workstation and build.mysql.com
      0a48c5b5
  2. 04 Feb, 2005 2 commits
    • guilhem@mysql.com's avatar
      Backport of ChangeSet 1.1845 05/02/04 13:53:16 guilhem@mysql.com +1 -0 from 5.0. · 3f9c4a91
      guilhem@mysql.com authored
      Proposal to fix this problem: when using libmysqlclient, you must call mysql_server_end() to nicely free memory at the end
      of your program; it however sounds weird to call a function named *SERVER_end* when you're the CLIENT (you're not ending the server, you're ending
      your ability to talk to servers). So here I add two defines which should be more generic names. Our manual
      mentions these functions only for libmysqld API so needs some fixing, and then we can close BUG#8099 and BUG#6149.
      3f9c4a91
    • guilhem@mysql.com's avatar
      Proposal to fix this problem: when using libmysqlclient, you must call... · cb23d3d0
      guilhem@mysql.com authored
      Proposal to fix this problem: when using libmysqlclient, you must call mysql_server_end() to nicely free memory at the end of your program; it however
      sounds weird to call a function named *SERVER_end* when you're the CLIENT (you're not ending the server, you're ending your ability to talk to servers).
      So here I add two defines which should be more generic names. This was longly discussed with Konstantin, Serg, Brian. The problem started from
      a post on valgrind-users list: http://sourceforge.net/mailarchive/forum.php?thread_id=5778035&forum_id=32038 ; our manual mentions these functions
      only for libmysqld API so needs some fixing, and then we can close BUG#8099 and BUG#6149.
      cb23d3d0
  3. 17 Dec, 2004 1 commit
  4. 16 Dec, 2004 1 commit
  5. 10 Nov, 2004 1 commit
  6. 08 Nov, 2004 1 commit
    • bar@mysql.com's avatar
      mysql.h: · a83f8e60
      bar@mysql.com authored
        Adding a prototype for the new function.
      a83f8e60
  7. 01 Nov, 2004 1 commit
  8. 19 Oct, 2004 1 commit
    • monty@mishka.local's avatar
      Review of all code pushed since last review · 04c23808
      monty@mishka.local authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      04c23808
  9. 25 Aug, 2004 1 commit
  10. 19 Aug, 2004 1 commit
  11. 03 Aug, 2004 1 commit
  12. 22 Jul, 2004 1 commit
    • hf@deer.(none)'s avatar
      Fixes for bugs in embedded library: · 94bfeb83
      hf@deer.(none) authored
      #4700 (Unsigned value returned as signed)
          just no appropriate checking
      #4701 (Errors returned earlier than expected)
          all errors returned from send_command()
      #4702 (Result isn't freed properly if there's no retrieval)
          flush_use_result has only 'client' version and should
          be made 'virtual'
      94bfeb83
  13. 25 Jun, 2004 2 commits
  14. 24 Jun, 2004 1 commit
    • konstantin@mysql.com's avatar
      Fix for Bug#4030 "Client side conversion string -> date type doesn't · a30fcdc6
      konstantin@mysql.com authored
      work (prepared statements)" and after-review fixes:
      - str_to_TIME renamed to str_to_datetime to pair with str_to_time
      - functions str_to_time and str_to_TIME moved to sql-common
      - send_data_str now supports MYSQL_TYPE_TIME, MYSQL_TIME_DATE,
        MYSQL_TIME_DATETIME types of user input buffers.
      - few more comments in the client library
      - a test case added.
      a30fcdc6
  15. 23 Jun, 2004 1 commit
  16. 16 Jun, 2004 1 commit
  17. 15 Jun, 2004 1 commit
    • guilhem@mysql.com's avatar
      API change: mysql_shutdown() now needs a 2nd parameter, the shutdown level. · f1fda638
      guilhem@mysql.com authored
      Server will however still accept shutdown without specified level; so that old
      mysqladmin can still shut server down.
      I would like your comments on the names of shutdown level which I chose. You
      are welcome to propose better names. Please however check WL#709 before.
      Reason for the names I propose is to be accurate, thus leaving possibility
      for other levels which we may imagine in the future; that's why I have rejected
      names like "fast", "smart", "graceful" so far. My position is that WAIT_ALL_BUFFERS
      or WAIT_CRITICAL_BUFFERS say what the shutdown does, whereas for "smart", "fast" you
      need to remember what it does.
      This should be pushed in 4.1.3 but only after your comments.
      f1fda638
  18. 05 Jun, 2004 1 commit
  19. 04 Jun, 2004 1 commit
  20. 31 May, 2004 1 commit
  21. 26 May, 2004 1 commit
  22. 07 May, 2004 1 commit
  23. 01 May, 2004 1 commit
  24. 30 Apr, 2004 1 commit
  25. 29 Apr, 2004 2 commits
  26. 31 Mar, 2004 1 commit
  27. 28 Mar, 2004 1 commit
  28. 25 Mar, 2004 1 commit
  29. 23 Mar, 2004 1 commit
  30. 18 Mar, 2004 1 commit
  31. 15 Mar, 2004 1 commit
    • konstantin@mysql.com's avatar
      Intermediate commit of client library (cleanups + fixes of 3 items from · 420c956d
      konstantin@mysql.com authored
      flaws list)
      TODO: 
       * verify that no sequence of API calls produces SIGSEGV.
       That is, verify that mysql_stmt_init  -> mysql_stmt_fetch is OK,
       or mysql_stmt_prepare -> mysql_stmt_fetch_column is OK and sets
       meaningful error.
       * remove alloc_stmt_fields call
       * revise stmt->state codes and statement states.
       * there are other items in prepared statements 'to fix' document.
      
      Done:
       - cleanups and comments
       - revision of prepared statement error codes.
       - mysql_stmt_prepare is now can always be called (that is, you can reprepare
         a statement)
       - new implementation of mysql_stmt_close and fetch cancellation
      420c956d
  32. 10 Mar, 2004 1 commit
  33. 05 Mar, 2004 1 commit
    • konstantin@mysql.com's avatar
      New call mysql_stmt_init() introduced. · 7753c6b9
      konstantin@mysql.com authored
      Renames:
      mysql_bind_param      -> mysql_stmt_bind_param
      mysql_bind_result     -> mysql_stmt_bind_result
      mysql_execute         -> mysql_stmt_execute
      mysql_fetch           -> mysql_stmt_fetch
      mysql_fetch_column    -> mysql_stmt_fetch_column
      mysql_get_metadata    -> mysql_stmt_result_metadata
      mysql_param_count     -> mysql_stmt_param_count
      mysql_param_result    -> mysql_stmt_param_metadata
      mysql_prepare         -> mysql_stmt_prepare
      mysql_send_long_data  -> mysql_stmt_send_long_data
      
      client_test.c cleaned up from memory leaks
      7753c6b9
  34. 16 Feb, 2004 1 commit
  35. 14 Feb, 2004 1 commit
  36. 10 Feb, 2004 2 commits