1. 11 Sep, 2008 3 commits
  2. 10 Sep, 2008 2 commits
  3. 09 Sep, 2008 1 commit
  4. 06 Sep, 2008 4 commits
  5. 05 Sep, 2008 13 commits
  6. 04 Sep, 2008 1 commit
  7. 29 Aug, 2008 3 commits
  8. 28 Aug, 2008 4 commits
  9. 27 Aug, 2008 9 commits
    • Gleb Shchepa's avatar
      Bug #37799: SELECT with a BIT column in WHERE clause · a591f2cb
      Gleb Shchepa authored
                  returns unexpected result
      
      If:
        1. a table has a not nullable BIT column c1 with a length
           shorter than 8 bits and some additional not nullable
           columns c2 etc, and
        2. the WHERE clause is like: (c1 = constant) AND c2 ...,
      the SELECT query returns unexpected result set.
      
      
      The server stores BIT columns in a tricky way to save disk
      space: if column's bit length is not divisible by 8, the
      server places reminder bits among the null bits at the start
      of a record. The rest bytes are stored in the record itself,
      and Field::ptr points to these rest bytes.
      
      However if a bit length of the whole column is less than 8,
      there are no remaining bytes, and there is nothing to store in
      the record at its regular place. In this case Field::ptr points
      to bytes actually occupied by the next column in a record.
      If both columns (BIT and the next column) are NOT NULL,
      the Field::eq function incorrectly deduces that this is the
      same column, so query transformation/equal item elimination
      code (see build_equal_items_for_cond) may mix these columns
      and damage conditions containing references to them.
      
      
      mysql-test/r/type_bit.result:
        Added test case for bug #37799.
      mysql-test/t/type_bit.test:
        Added test case for bug #37799.
      sql/field.h:
        1. The Field::eq function has been modified to take types of
        comparing columns into account to distinguish between BIT and
        not BIT columns referencing the same bytes in a record.
        
        2. Unnecessary type comparison has been removed from the
        Field_bit::eq function (moved to Field::eq).
      a591f2cb
    • Mats Kindahl's avatar
      Merging 5.1 into 5.1-rpl-merge · e72e5cc9
      Mats Kindahl authored
      e72e5cc9
    • Georgi Kodinov's avatar
      merged 5.1-bugteam into B37548 tree · 6e948385
      Georgi Kodinov authored
      6e948385
    • Georgi Kodinov's avatar
      Bug#37548: result value erronously reported being NULL in certain subqueries · b7afb52d
      Georgi Kodinov authored
            
      When switching to indexed ORDER BY we must be sure to reset the index read
      flag if we are switching from a covering index to non-covering.
      
      mysql-test/r/subselect.result:
        Bug#37548: test case
      mysql-test/t/subselect.test:
        Bug#37548: test case
      sql/sql_select.cc:
        Bug#37548: update the index read flag if the index for indexed ORDER BY is not
            covering.
      b7afb52d
    • Mats Kindahl's avatar
      Automerge · 5383c4f5
      Mats Kindahl authored
      5383c4f5
    • Mats Kindahl's avatar
      Result file change. · 8b0133f9
      Mats Kindahl authored
      8b0133f9
    • Evgeny Potemkin's avatar
      Bug#38195: Incorrect handling of aggregate functions when loose index scan is · dcf82665
      Evgeny Potemkin authored
      used causes server crash.
            
      When the loose index scan access method is used values of aggregated functions
      are precomputed by it. Aggregation of such functions shouldn't be performed
      in this case and functions should be treated as normal ones.
      The create_tmp_table function wasn't taking this into account and this led to
      a crash if a query has MIN/MAX aggregate functions and employs temporary table
      and loose index scan.
      Now the JOIN::exec and the create_tmp_table functions treat MIN/MAX aggregate
      functions as normal ones when the loose index scan is used.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for the bug#38195.
      mysql-test/t/group_min_max.test:
        Added a test case for the bug#38195.
      sql/sql_select.cc:
        Bug#38195: Incorrect handling of aggregate functions when loose index scan is
        used causes server crash.
        The JOIN::exec and the create_tmp_table functions treat MIN/MAX aggregate
        functions as normal ones when the loose index scan is used.
      dcf82665
    • Mats Kindahl's avatar
      Automerging · 4dd16832
      Mats Kindahl authored
      4dd16832
    • Mats Kindahl's avatar
      Automerge · c94f3f43
      Mats Kindahl authored
      c94f3f43