1. 16 Jul, 2007 5 commits
    • unknown's avatar
      Fix ndb_cache* test failures in the -runtime tree. · 0d0dcd5b
      unknown authored
      Do not try to acquire structure_guard_mutex for the second time
      when invalidating a table from send_result_to_client.
      
      
      sql/sql_cache.cc:
        Do not try to acquire mutex when invalidating a table
        from send_result_to_client().
        A follow up patch for the patch for Bug#21074.
        Reuse code by moving locking-independent invalidation functionality
        into invalidate_table_internal.
      sql/sql_cache.h:
        Add a new declaration.
      0d0dcd5b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · c8961a5f
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/t/show_check.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/r/events_bugs.result:
        Manual merge.
      c8961a5f
    • unknown's avatar
      A follow up after the fix for Bug#21074 - fix NDB tests breaking on · 3014d481
      unknown authored
      asserts.
      The patch for Bug#21074 replaces acquisition of the global LOCK_open lock
      with exclusive locks on table names in such operations ad DROP TABLE
      and RENAME TABLE.
      Unfortunately, NDB internally assumes that LOCK_open is acquired and
      tries to release it.
      This dependency should be fixed by a separate (and significant in size)
      patch. For now we just satisfy it - after all, the original
      goal of the patch for Bug#21074 was to move query_cache_invalidate
      outside of the scope of LOCK_open, and we still can do that.
      
      This fixes some failing NDB tests in the runtime tree.
      
      
      sql/sql_rename.cc:
        Move release of LOCK_open after ha_ndbcluster::rename_tables to
        satisfy an assert in ndb_log_schema_op.
      3014d481
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · d7dc7640
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      d7dc7640
    • unknown's avatar
      Raise version number after cloning 5.0.46 · 127a1b49
      unknown authored
      127a1b49
  2. 15 Jul, 2007 1 commit
    • unknown's avatar
      A fix for Bug#27406 Events: failure only causes a warning. Update test · 4aadca45
      unknown authored
      results.
      When executing a CREATE EVENT statement with ON COMPLETION NOT PRESERVE 
      clause (explicit or implicit) and completion date in the past, we do not 
      create the event. Or, put it differently, we create it and then drop 
      immediately.
      A warning is issued in this case, not an error -- we want to load 
      successfully old database dumps, and such dumps may contain events
      that are no longer valid.
      
      Update the warning text to not imply an erroneous condition. 
      
      
      mysql-test/r/events_bugs.result:
        Update the test results (Bug#27406)
      sql/share/errmsg.txt:
        Fix Bug#27406 "Events: failure only causes a warning" -- update the error
        message to not imply that there was a failure.
      4aadca45
  3. 14 Jul, 2007 2 commits
  4. 13 Jul, 2007 1 commit
    • unknown's avatar
      A follow up after the patch for Bug#21074 - even though · f434f45d
      unknown authored
      we now have exclusive name lock on the table name in mysql_rm_table_part2,
      we still should keep LOCK_open - some storage engines are not
      ready for locking scope change and assume that LOCK_open is kept.
      Still, the binary logging and query cache invalidation calls
      moved out of LOCK_open scope.
      Fixes some of the broken 5.1-runtime tests (tests break on asserts).
      
      
      sql/ha_ndbcluster.cc:
        Do not lock LOCK_open for mysql_rm_table_part2 - it does that
        for us now.
      sql/mysql_priv.h:
        Remove an unused flag.
      sql/sql_class.h:
        Fix an unrelated compiler warning.
      sql/sql_db.cc:
        Adjust to the changed signature.
      sql/sql_table.cc:
        mysql_rm_table_part2: we need to keep LOCK_open while calling
        storage engine functions, even though now 
        we have an exclusive lock on the table name. Some of them assume that it's 
        kept and attempt to unlock it.
      f434f45d
  5. 12 Jul, 2007 1 commit
    • unknown's avatar
      Fix for 5.1 for BUG#10491: Server returns data as charset binary · 03cb6626
      unknown authored
      SHOW CREATE TABLE or SELECT FROM I_S.
      
      This is the last patch for this bug, which depends on the big
      CS patch and was pending.
      
      The problem was that SHOW CREATE statements returned original
      queries in the binary character set. That could cause the query
      to be unreadable.
      
      The fix is to use original character_set_client when sending
      the original query to the client. In order to preserve the query
      in mysqldump, 'binary' character set results should be set when
      issuing SHOW CREATE statement. If either source or destination
      character set is 'binary' , no conversion is performed.
      The idea is that since the source character set is no longer
      'binary', we fix the destination character set to still produce
      valid dumps.
      
      
      client/mysqldump.c:
        Switch character_set_results of mysqldump-connection before
        calling SHOW CREATE statements for the objects.
      mysql-test/r/show_check.result:
        Result file.
      mysql-test/t/show_check.test:
        Add test case for the part of BUG#10491.
      sql/events.cc:
        Send original query in the original character set.
      sql/sp_head.cc:
        Send original query in the original character set.
      sql/sql_show.cc:
        Send original query in the original character set.
      03cb6626
  6. 10 Jul, 2007 4 commits
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 816cc183
      unknown authored
      into  mysql.com:/home/ram/work/mysql-5.1-maint
      
      816cc183
    • unknown's avatar
      Fix for bug #29652: csv.test failure: two changes conflict after merge · 2166719e
      unknown authored
      Problem: we don't take into account the length of the data written
      to the temporary data file during update on a CSV table.
      
      Fix: properly calculate the data file length during update.
      
      
      mysql-test/r/csv.result:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - test result adjusted.
      storage/csv/ha_tina.cc:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - adjust local_saved_data_file_length in case of update as well.
      storage/csv/ha_tina.h:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - adjust local_saved_data_file_length in case of update as well.
      2166719e
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1-new-maint · 0361ba61
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-maint
      
      
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Auto merged
      0361ba61
    • unknown's avatar
      Bug #29570 · 0df2e765
      unknown authored
      - correct result files
      
      0df2e765
  7. 09 Jul, 2007 25 commits
  8. 08 Jul, 2007 1 commit