1. 27 Sep, 2007 1 commit
  2. 25 Sep, 2007 5 commits
    • unknown's avatar
      Merge dator6.(none):/home/mikael/mysql_clones/mysql-5.1-ndb · 9b428b9e
      unknown authored
      into  dator6.(none):/home/mikael/mysql_clones/bug30996
      
      
      9b428b9e
    • unknown's avatar
      ndb_rand.c: · 10fbce08
      unknown authored
        Rename: ndb/src/common/util/ndb_rand.c -> storage/ndb/src/common/util/ndb_rand.c
      ndb_rand.h:
        Rename: ndb/include/util/ndb_rand.h -> storage/ndb/include/util/ndb_rand.h
      
      
      storage/ndb/include/util/ndb_rand.h:
        Rename: ndb/include/util/ndb_rand.h -> storage/ndb/include/util/ndb_rand.h
      storage/ndb/src/common/util/ndb_rand.c:
        Rename: ndb/src/common/util/ndb_rand.c -> storage/ndb/src/common/util/ndb_rand.c
      10fbce08
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/ndb · 5fe076d6
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.1/ndb
      
      
      storage/ndb/src/common/util/Makefile.am:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Auto merged
      5fe076d6
    • unknown's avatar
      [PATCH] BUG#30379 Better randomise time before retry in timeout check (DBTC) · f7886540
      unknown authored
      timoOutLoopStartLab() checks if any transactions have been delayed
      for so long that we are forced to perform some action (e.g. abort,
      resend etc).
      
      It is *MEANT* to (according to the comment):
      > To avoid aborting both transactions in a deadlock detected by time-out
      > we insert a random extra time-out of upto 630 ms by using the lowest
      > six bits of the api connect reference.
      > We spread it out from 0 to 630 ms if base time-out is larger than 3 sec,
      > we spread it out from 0 to 70 ms if base time-out is smaller than 300 msec,
      > and otherwise we spread it out 310 ms.
      
      The comment (as all do) lies.
      
      the API connect reference is not very random, producing incredibly
      predictable "random" numbers. This could lead to both txns being
      aborted instead of just one.
      
      Before:
      timeout value: 123 3
      timeout value: 122 2
      timeout value: 122 2
      timeout value: 122 2
      timeout value: 123 3
      
      After:
      timeout value: 127 7
      timeout value: 126 6
      timeout value: 129 9
      timeout value: 139 19
      timeout value: 137 17
      timeout value: 151 31
      timeout value: 130 10
      timeout value: 132 12
      
      Index: ndb-work/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp
      ===================================================================
      
      
      ndb/src/common/util/Makefile.am:
        BUG#30379 Better randomise time before retry in timeout check (DBTC)
      ndb/include/util/ndb_rand.h:
        BUG#30379 Better randomise time before retry in timeout check (DBTC)
      ndb/src/common/util/ndb_rand.c:
        BUG#30379 Better randomise time before retry in timeout check (DBTC)
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        BUG#30379 Better randomise time before retry in timeout check (DBTC)
      f7886540
    • unknown's avatar
      Merge dator6.(none):/home/mikael/mysql_clones/mysql-5.1-ndb · 8e3581c7
      unknown authored
      into  dator6.(none):/home/mikael/mysql_clones/bug30996
      
      
      8e3581c7
  3. 19 Sep, 2007 1 commit
    • unknown's avatar
      NDBT_Thread.cpp: · bb7b00c9
      unknown authored
        Removed semicolon causing build syntax issues per pekka
      
      
      storage/ndb/test/src/NDBT_Thread.cpp:
        Removed semicolon causing build syntax issues per pekka
      bb7b00c9
  4. 15 Sep, 2007 1 commit
  5. 14 Sep, 2007 2 commits
  6. 13 Sep, 2007 7 commits
    • unknown's avatar
      BUG#30996: Committed too early when autocommit and lock table · 5f95f01b
      unknown authored
      Moved out a lot of code into functions from external_lock and
      start_stmt
      Fixed a crashing bug at memory alloc failure
      Merged the stmt and all variables into one trans variable
      Always register start of statement as according to the
      interface of the handlers.
      Also register for start of transaction when not statement commit
      == not autocommit AND no begin - commit ongoing
      Now that we registered in a proper manner we also needed to handle
      the commit call when end of statement and transaction is ongoing
      Added start_stmt_count to know when we have start of statement
      for first table
      
      
      mysql-test/suite/ndb/r/ndb_lock_table.result:
        Added a new test case for bug30996
      mysql-test/suite/ndb/t/ndb_lock_table.test:
        Added a new test case for bug30996
      sql/ha_ndbcluster.cc:
        Moved out a lot of code into functions from external_lock and
        start_stmt
        Fixed a crashing bug at memory alloc failure
        Merged the stmt and all variables into one trans variable
        Always register start of statement as according to the
        interface of the handlers.
        Also register for start of transaction when not statement commit
        == not autocommit AND no begin - commit ongoing
        Now that we registered in a proper manner we also needed to handle
        the commit call when end of statement and transaction is ongoing
        Added start_stmt_count to know when we have start of statement
        for first table
      sql/ha_ndbcluster.h:
        New functions and merged variables
      5f95f01b
    • unknown's avatar
      fix intermittant timing-related test failure · e34c1304
      unknown authored
      e34c1304
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · a0403f7a
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb
      
      
      a0403f7a
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.1-ndb · 577a1633
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.1-new-ndb
      
      
      577a1633
    • unknown's avatar
      Merge mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb · 39d84594
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.1-new-ndb
      
      
      sql/ha_ndbcluster_cond.cc:
        Auto merged
      39d84594
    • unknown's avatar
    • unknown's avatar
      Changes for pushbuild test runs and VSC compile warnings · fa12674c
      unknown authored
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        Fix test results for pushbuild
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        Fix test results for pushbuild
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        Fix test results for pushbuild
      storage/innobase/handler/ha_innodb.cc:
        resolve a VSC++ typecast compile warning.
      fa12674c
  7. 12 Sep, 2007 5 commits
    • unknown's avatar
      undo unneccessary change to ha_innodb.cc · 23227604
      unknown authored
      remove 'drop database' from new tests.
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/r/rpl_innodb_bug30919.result:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        remove "DROP DATABASE test"
      mysql-test/suite/rpl/t/rpl_innodb_bug30919.test:
        remove "DROP DATABASE test"
      storage/innobase/handler/ha_innodb.cc:
        undo unneccessary edits.
      23227604
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb-bj · 6bead54d
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb-bj
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      storage/ndb/src/common/debugger/EventLogger.cpp:
        Auto merged
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      6bead54d
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb · 85b4a64c
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb-bj
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      85b4a64c
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb · 46bca215
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb-bj
      
      
      46bca215
    • unknown's avatar
      BUG#23354 revert · 2ef5838c
      unknown authored
      2ef5838c
  8. 11 Sep, 2007 3 commits
  9. 09 Sep, 2007 1 commit
    • unknown's avatar
      Bug#30919 · db1f9468
      unknown authored
        "Rows not deleted from innodb partitioned tables if --innodb_autoinc_lock_mode=0"
      
        Due to a previous bugfix which initializes a previously uninitialized
        variable, ha_partition::get_auto_increment() may fail to operate
        correctly when the storage engine reports that it is only reserving
        one value and one or more partitions have a different 'next-value'.
        Currently, only affects Innodb's new-style auto-increment code which
        reserves larger blocks of values and has less inter-thread contention.
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        Fix results - previous results shows symptoms of Bug30919
      sql/ha_partition.cc:
        Bug30919
        
        ha_partition::write_row()
          Do not insert a row if a failure occurred while generating
          auto-increment value.
        
        ha_partition::get_auto_increment()
          If there is an empty 'intersection' of auto-increment values, perform
          a second pass before failing because partitions may have different
          auto-increment 'next-value' attributes.
      storage/innobase/handler/ha_innodb.cc:
        Bug30919
          Only set *first_value if it is less than autoinc value. This allows
          a higher value to be hinted when operating as a partitioned table.
      mysql-test/suite/rpl/r/rpl_innodb_bug30919.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug30919.result''
      mysql-test/suite/rpl/t/rpl_innodb_bug30919-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30919-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug30919.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30919.test''
      db1f9468
  10. 08 Sep, 2007 2 commits
    • unknown's avatar
      perform explicit cleanup · 67a8e6a0
      unknown authored
      add missing opt file
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        explicit post-test cleanup
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        explicit post-test cleanup
      mysql-test/suite/rpl/t/rpl_innodb_bug28430-slave.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430-slave.opt''
      67a8e6a0
    • unknown's avatar
      Bug#30907 · bec076f4
      unknown authored
        "Regression: "--innodb_autoinc_lock_mode=0" (off) not same as older releases"
      Bug#28430
        "Failure in replication of innodb partitioned tables on row/mixed format"
      Bug#30888
        "Innodb table + stored procedure + row deletion = server crash"
      
        Apply Oracle patch from Sunny
        Include tests cases by Omer
        Ensure that innobase_read_and_init_auto performs table autoinc lock when lock_mode = 0
        No need for "if" guard around row_unlock_table_autoinc_for_mysql() because
        it already performs same check.
        Make autoinc_lock_mode variable read-only for duration of running mysqld process.
      
      
      storage/innobase/handler/ha_innodb.cc:
        Bug30907/28430
          "Regression: "--innodb_autoinc_lock_mode=0" (off) not same as older releases"
          "Failure in replication of innodb partitioned tables on row/mixed format"
          Apply Oracle patch from Sunny
          Ensure that innobase_read_and_init_auto performs table autoinc lock when lock_mode = 0
          No need for "if" guard around row_unlock_table_autoinc_for_mysql() because
          it already performs same check.
          Make autoinc_lock_mode variable read-only for duration of running mysqld process.
      storage/innobase/row/row0sel.c:
        Bug30888
          "Innodb table + stored procedure + row deletion = server crash"
        
          Remove endian-specific code.
          Fix function row_search_autoinc_read_column() to handle any integer size up to 8 bytes.
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug28430.result''
      mysql-test/suite/rpl/r/rpl_innodb_bug30888.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_innodb_bug30888.result''
      mysql-test/suite/rpl/t/rpl_innodb-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug28430-master.opt:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430-master.opt''
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug28430.test''
      mysql-test/suite/rpl/t/rpl_innodb_bug30888.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_innodb_bug30888.test''
      bec076f4
  11. 07 Sep, 2007 4 commits
    • unknown's avatar
      ha_partition.cc, listener.h, listener.cc, ha_partition.h: · aff30b40
      unknown authored
        Initiate static const outside class definition
      
      
      server-tools/instance-manager/listener.cc:
        Initiate static const outside class definition
      server-tools/instance-manager/listener.h:
        Initiate static const outside class definition
      sql/ha_partition.cc:
        Initiate static const outside class definition
      sql/ha_partition.h:
        Initiate static const outside class definition
      aff30b40
    • unknown's avatar
      azio.c, azlib.h: · f571ae9b
      unknown authored
        Don't use typedef 'voidpc' as later addition and not needed
      
      
      storage/archive/azlib.h:
        Don't use typedef 'voidpc' as later addition and not needed
      storage/archive/azio.c:
        Don't use typedef 'voidpc' as later addition and not needed
      f571ae9b
    • unknown's avatar
      Bug #11313 confusing/erroneous 4006 message · 821abeee
      unknown authored
      821abeee
    • unknown's avatar
      Modifications to funcs_1 files for 5.1.22rc release including: · 5fb2bdd7
      unknown authored
       - Updated row help count information
       - Added missing 'order by' clauses (altrady fixed in build tree)
       - Fixed isses with ndb_storeproc06/10 tests (added use database)
       - Corrected use of wrong engine in ndb tests (already fixed in build tree)
       - Update to ndb__datadict to replect additional fields in I_S (already corrected in build tree)
      
      
      mysql-test/suite/funcs_1/include/ndb_tb2.inc:
        Correction of wrong engine used for ndb test
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/innodb_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/memory_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/myisam_views.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb__datadict.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_cursors.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_func_view.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_06.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_07.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_08.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_storedproc_10.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_0102.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_03.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_03e.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_0407.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_08.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_09.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_trig_1011ext.result:
        Updated result file
      mysql-test/suite/funcs_1/r/ndb_views.result:
        Updated result file
      mysql-test/suite/funcs_1/storedproc/storedproc_06.inc:
        Updated test file enforcing 'use database' after connect
      mysql-test/suite/funcs_1/storedproc/storedproc_10.inc:
        Updated test file enforcing 'use database' after connect
      mysql-test/suite/funcs_1/views/views_master.inc:
        Adding order by clauses in missing places
      5fb2bdd7
  12. 06 Sep, 2007 2 commits
  13. 05 Sep, 2007 6 commits
    • unknown's avatar
      change printout to be a warning · d02df3b1
      unknown authored
      d02df3b1
    • unknown's avatar
      moving these tests to suite ndb_team · 91f14cdb
      unknown authored
      
      mysql-test/suite/ndb_team/t/ndb_autodiscover2-master.opt:
        Rename: mysql-test/suite/ndb/t/ndb_autodiscover2-master.opt -> mysql-test/suite/ndb_team/t/ndb_autodiscover2-master.opt
      mysql-test/suite/ndb_team/t/ndb_autodiscover2.test:
        Rename: mysql-test/suite/ndb/t/ndb_autodiscover2.test -> mysql-test/suite/ndb_team/t/ndb_autodiscover2.test
      mysql-test/suite/ndb_team/t/ndb_autodiscover.test:
        Rename: mysql-test/suite/ndb/t/ndb_autodiscover.test -> mysql-test/suite/ndb_team/t/ndb_autodiscover.test
      mysql-test/suite/ndb_team/t/ndb_autodiscover3.test:
        Rename: mysql-test/suite/ndb/t/ndb_autodiscover3.test -> mysql-test/suite/ndb_team/t/ndb_autodiscover3.test
      mysql-test/suite/ndb_team/r/ndb_autodiscover.result:
        Rename: mysql-test/suite/ndb/r/ndb_autodiscover.result -> mysql-test/suite/ndb_team/r/ndb_autodiscover.result
      mysql-test/suite/ndb_team/r/ndb_autodiscover2.result:
        Rename: mysql-test/suite/ndb/r/ndb_autodiscover2.result -> mysql-test/suite/ndb_team/r/ndb_autodiscover2.result
      mysql-test/suite/ndb_team/r/ndb_autodiscover3.result:
        Rename: mysql-test/suite/ndb/r/ndb_autodiscover3.result -> mysql-test/suite/ndb_team/r/ndb_autodiscover3.result
      mysql-test/suite/ndb_team/t/disabled.def:
        BitKeeper file /home/tomas/mysql-5.1-new-ndb/mysql-test/suite/ndb_team/t/disabled.def
      91f14cdb
    • unknown's avatar
      tests actually work in statement based · 4a3825c4
      unknown authored
      4a3825c4
    • unknown's avatar
      correct include file · f215ae97
      unknown authored
      f215ae97
    • unknown's avatar
      Merge lzhou@bk-internal.mysql.com:/home/bk/mysql-5.1-new-ndb-bj · c36bc160
      unknown authored
      into  dev3-63.(none):/home/zhl/mysql/mysql-5.1/bug27543
      
      
      storage/ndb/tools/restore/Restore.cpp:
        Remove additional space when merge
      c36bc160
    • unknown's avatar
      correct include file · cd2450a1
      unknown authored
      cd2450a1