1. 15 Aug, 2008 5 commits
    • Davi Arnaut's avatar
      Merge from mysql-5.1 main. · 0fc838d5
      Davi Arnaut authored
      0fc838d5
    • Davi Arnaut's avatar
      Bug#38560: valgrind warnings on PB due to query profiling · db87b3ce
      Davi Arnaut authored
      Fix for a valgrind warning due to a jump on a uninitialized
      variable. The problem was that the sql profile preparation
      function wasn't being called for all possible code paths
      of query execution.
      
      The solution is to ensure that query profiling is always
      started before dispatch_command function is called and to
      explicitly call the profile preparation function on bootstrap.
      
      
      
      sql/sql_parse.cc:
        Finish query profiling properly when executing bootstrap commands.
        Add query profiling to execute_init_command as it calls dispatch_command.
      db87b3ce
    • Sergey Glukhov's avatar
      Bug#36638 mysqld crashes when open file limit is passed and general query log enabled · 5aff1f3d
      Sergey Glukhov authored
      The problem:
      CSV storage engine open function returns success even
      thought it failed to open the data file
      The fix:
      return error
      Additional fixes:
      added MY_WME to my_open to avoid mysterious error message
      free share struct if open the file was unsuccessful
      
      
      mysql-test/r/csv.result:
        test result
      mysql-test/t/csv.test:
        test case
      storage/csv/ha_tina.cc:
        The problem:
        CSV storage engine open function returns success even
        thought it failed to open the data file
        The fix:
        return error
        Additional fixes:
        added MY_WME to my_open to avoid mysterious error message
        free share struct if open the file was unsuccessful
      5aff1f3d
    • Ramil Kalimullin's avatar
      Fix for bug#37537: myisamchk fails with Assertion failure with partitioned table · 2be2bf9e
      Ramil Kalimullin authored
      Problem: missed "break" in a switch leads to unexpected assertion failure
      of 'myisamchk compressed_table'.
      
      Fix: add the break.
      
      
      storage/myisam/mi_check.c:
        Fix for bug#37537: myisamchk fails with Assertion failure with partitioned table
        
        In the record links check function (chk_data_link()) 
        missed "break" for case COMPRESSED_RECORD was added.
      2be2bf9e
    • Ramil Kalimullin's avatar
      Fix for bug#37337: Function returns different results · 8010c601
      Ramil Kalimullin authored
      Problem: REGEXP in functions/PSs may return wrong results
      due to improper initialization.
      
      Fix: initialize required REGEXP params.
      
      
      sql/item_cmpfunc.cc:
        Fix for bug#37337: Function returns different results
        
        prev_regexp is used in the Item_func_regex::regcomp()
        to store previous regex and to avoid re-initialization 
        if given the same pattern.
        Shoud be deleted in the Item_func_regex::cleanup() where we
        clean up the regexp structure.
      8010c601
  2. 14 Aug, 2008 7 commits
  3. 13 Aug, 2008 13 commits
  4. 12 Aug, 2008 11 commits
    • Marc Alff's avatar
      Merge mysql-5.1-bugteam -> local bugfix branch · 9922445c
      Marc Alff authored
      9922445c
    • Marc Alff's avatar
      Bug#38296 (low memory crash with many conditions in a query) · f60bbd90
      Marc Alff authored
      This fix is for 5.1 only : back porting the 6.0 patch manually
      
      The parser code in sql/sql_yacc.yy needs to be more robust to out of
      memory conditions, so that when parsing a query fails due to OOM,
      the thread gracefully returns an error.
      
      Before this fix, a new/alloc returning NULL could:
      - cause a crash, if dereferencing the NULL pointer,
      - produce a corrupted parsed tree, containing NULL nodes,
      - alter the semantic of a query, by silently dropping token values or nodes
      
      With this fix:
      - C++ constructors are *not* executed with a NULL "this" pointer
      when operator new fails.
      This is achieved by declaring "operator new" with a "throw ()" clause,
      so that a failed new gracefully returns NULL on OOM conditions.
      
      - calls to new/alloc are tested for a NULL result,
      
      - The thread diagnostic area is set to an error status when OOM occurs.
      This ensures that a request failing in the server properly returns an
      ER_OUT_OF_RESOURCES error to the client.
      
      - OOM conditions cause the parser to stop immediately (MYSQL_YYABORT).
      This prevents causing further crashes when using a partially built parsed
      tree in further rules in the parser.
      
      No test scripts are provided, since automating OOM failures is not
      instrumented in the server.
      Tested under the debugger, to verify that an error in alloc_root cause the
      thread to returns gracefully all the way to the client application, with
      an ER_OUT_OF_RESOURCES error.
      f60bbd90
    • Davi Arnaut's avatar
      Merge and fix tree name. · faa54a07
      Davi Arnaut authored
      faa54a07
    • Davi Arnaut's avatar
      Merge and fix tree name. · 9fda5e47
      Davi Arnaut authored
      9fda5e47
    • Davi Arnaut's avatar
      Merge mysql-5.0-bugteam into mysql-5.0 · 17544370
      Davi Arnaut authored
      17544370
    • Mattias Jonsson's avatar
      merge · 7f78acdc
      Mattias Jonsson authored
      7f78acdc
    • Davi Arnaut's avatar
      Merge mysql-5.1-bugteam into mysql-5.1 main. · e1127015
      Davi Arnaut authored
      e1127015
    • Mattias Jonsson's avatar
      manual merge of bug#37402 · 8d0d9e87
      Mattias Jonsson authored
      8d0d9e87
    • He Zhenxing's avatar
      Apply tomas's patch to fix rpl_row_basic.test, this can fix BUG#37884, · c0b0a2df
      He Zhenxing authored
      BUG#38369, enable rpl_row_basic_7ndb test
      c0b0a2df
    • Mattias Jonsson's avatar
      Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that · 2ae9924a
      Mattias Jonsson authored
      partition is corrupt
      
      Updated result files after merge
      
      mysql-test/suite/parts/r/partition_alter1_1_2_innodb.result:
        Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that
        partition is corrupt
        
        Updated result file after merge
      mysql-test/suite/parts/t/disabled.def:
        Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that
        partition is corrupt
        
        Enabled two tests after fixing the bug.
      2ae9924a
    • Davi Arnaut's avatar
      a92cf7b6
  5. 11 Aug, 2008 4 commits