1. 14 Mar, 2007 2 commits
  2. 13 Mar, 2007 11 commits
    • unknown's avatar
      Removed tabs. · b7b0406b
      unknown authored
      b7b0406b
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 0a0dd81d
      unknown authored
      into  blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25460
      
      0a0dd81d
    • unknown's avatar
      Bug#25460 - High concurrency MyISAM access causes severe mysqld crash. · ec34f88c
      unknown authored
      The previous two patches for this bug worked together so that
      no permanent table was memory mapped. The first patch tried to
      avoid mapping while a table is in use. It allowed mapping only
      if there was exactly one lock on the table, assuming that the
      calling thread owned it. During mi_open(), a different call to
      memory mapping was coded, which did not have this limitation.
      
      The second patch tried to remove the code duplication and just
      called mi_extra() from mi_open() an thus inherited the limitation.
      But on open, a thread does not have a lock on the table...
      
      A possible solution would be to check for zero or one lock.
      But since I learned that it is safe to memory map a file while
      normal file I/O is done on it, I removed the restriction altogether
      and allow to memory map while a table is in use.
      
      No test case. I do not see a chance to verify with the test suite
      which kind of I/O is used on a table.
      
      
      storage/myisam/mi_extra.c:
        Bug#25460 - High concurrency MyISAM access causes severe mysqld crash.
        Allow to memory map while table is in use.
      ec34f88c
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines · 1335dd05
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      1335dd05
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-4.1-engines · e2a0109f
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines
      
      
      myisam/mi_create.c:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      sql/ha_myisam.cc:
        Auto merged
      sql/sql_parse.cc:
        Use local.
      mysql-test/r/merge.result:
        SCCS merged
      e2a0109f
    • unknown's avatar
      BUG#26881 - Large MERGE tables report incorrect specification when no · 4d7f2c22
      unknown authored
                  differences in tables
      Certain merge tables were wrongly reported as having incorrect definition:
      - Some fields that are 1 byte long (e.g. TINYINT, CHAR(1)), might
        be internally casted (in certain cases) to a different type on a
        storage engine layer. (affects 4.1 and up)
      - If tables in a merge (and a MERGE table itself) had short VARCHAR column (less
        than 4 bytes) and at least one (but not all) tables were ALTER'ed (even to an
        identical table: ALTER TABLE xxx ENGINE=yyy), table definitions went ouf of
        sync. (affects 4.1 only)
      
      This is fixed by relaxing a check for underlying conformance and setting
      field type to FIELD_TYPE_STRING in case varchar is shorter than 4
      when a table is created.
      
      
      myisam/mi_create.c:
        Added a comment.
      mysql-test/r/merge.result:
        A test case for bug#26881.
      mysql-test/t/merge.test:
        A test case for bug#26881.
      sql/ha_myisam.cc:
        Relaxed some checks performed by check_definition():
        As comparing of fulltext keys (and key segments) is not yet implemented,
        only return an error in case one of keys is fulltext and other is not.
        Otherwise, if both keys are fulltext, accept them as is.
        
        As comparing of spatial keys (and key segments) is not yet implemented,
        only return an error in case one of keys is spatial and other is not.
        Otherwise, if both keys are spatial, accept them as is.
        
        A workaround to handle situation when field is casted from FIELD_SKIP_ZERO
        to FIELD_NORMAL. This could happen only in case field length is 1 and row
        format is fixed.
      sql/sql_parse.cc:
        When a table that has varchar field shorter than 4 is created, field type is
        set to FIELD_TYPE_VAR_STRING. Later, when a table is modified using alter
        table, field type is changed to FIELD_TYPE_STRING (see Field_string::type).
        That means HA_OPTION_PACK_RECORD flag might be lost and thus null_bit might
        be shifted by alter table, in other words alter table doesn't create 100%
        equal table definition.
        
        This is usually not a problem, since when a table is created/altered,
        definition on a storage engine layer is based on one that is passed from
        sql layer. But it is a problem for merge engine - null_bit is shifted when
        a table (merge or underlying) is altered.
        
        Set field type to FIELD_TYPE_STRING in case FIELD_TYPE_VAR_STRING is shorter
        than 4 when a table is created as it is done in Field::type.
      4d7f2c22
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines · b84870d1
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines
      
      
      sql/field.h:
        Auto merged
      storage/myisam/rt_index.c:
        Auto merged
      b84870d1
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1 · 530f29d0
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.1-engines
      
      
      storage/myisam/mi_open.c:
        Use local.
      530f29d0
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-4.1-engines · 3f417f1a
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines
      
      3f417f1a
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.0 · 3792a3de
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-5.0-engines
      
      
      myisam/rt_index.c:
        Auto merged
      sql/field.h:
        Auto merged
      3792a3de
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-4.1 · e90872a4
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-4.1-engines
      
      e90872a4
  3. 10 Mar, 2007 7 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 8354916f
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.1-opt
      
      
      mysql-test/r/explain.result:
        Auto merged
      mysql-test/r/func_default.result:
        Auto merged
      mysql-test/r/func_regexp.result:
        Auto merged
      mysql-test/r/func_test.result:
        Auto merged
      mysql-test/r/having.result:
        Auto merged
      mysql-test/r/olap.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/r/varbinary.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      mysql-test/r/func_str.result:
        Manually merged
      mysql-test/t/func_str.test:
        Manually merged
      8354916f
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/15757-bug-5.0-opt-mysql · 1625806e
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/25373-bug-5.0-opt-mysql
      
      
      sql/item_strfunc.cc:
        Auto merged
      mysql-test/r/func_str.result:
        SCCS merged
      mysql-test/t/func_str.test:
        SCCS merged
      1625806e
    • unknown's avatar
      Bug#15757: Wrong SUBSTRING() result when a tmp table was employed. · e3cf2fa2
      unknown authored
      When the SUBSTRING() function was used over a LONGTEXT field the max_length of
      the SUBSTRING() result was wrongly calculated and set to 0. As the max_length
      parameter is used while tmp field creation it limits the length of the result
      field and leads to printing an empty string instead of the correct result.
      
      Now the Item_func_substr::fix_length_and_dec() function correctly calculates
      the max_length parameter.
      
      
      mysql-test/t/func_str.test:
        Added a test case for the bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
      mysql-test/r/func_str.result:
        Added a test case for the bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
      sql/item_strfunc.cc:
        Bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
        Now the Item_func_substr::fix_length_and_dec() function correctly calculates
        the max_length parameter.
      e3cf2fa2
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 492f3c34
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/25373-bug-5.0-opt-mysql
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      sql/item.cc:
        Auto merged
      492f3c34
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-engines · 765b28e7
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-bug25673
      
      765b28e7
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · d7eccf03
      unknown authored
      into  blade08.mysql.com:/data0/istruewing/autopush/mysql-5.0-bug25673
      
      d7eccf03
    • unknown's avatar
      Fixed bug #26830: a crash for the query with a subselect containing ROLLUP. · fe8951d6
      unknown authored
      Crash happened because the function get_best_group_min_max detected
      joins with ROLLUP incorrectly.
      
      
      mysql-test/r/olap.result:
        Added a test case for bug #26830.
      mysql-test/t/olap.test:
        Added a test case for bug #26830.
      fe8951d6
  4. 09 Mar, 2007 20 commits
    • unknown's avatar
      Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized · 9cc553a2
      unknown authored
      away.
      
      Additional fix for bug#22331. Now Item_field prints its value in the case of
      the const field.
      
      
      mysql-test/r/varbinary.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/union.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/subselect.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_test.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/having.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_regexp.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_str.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_default.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/explain.result:
        Corrected test case after fix for bug#22331.
      sql/sql_union.cc:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Cleanup of the SELECT_LEX::order_list list.
      sql/item.h:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Added the print() member function to the Item_field class.
      sql/item.cc:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Added the print() member function to the Item_field class.
      9cc553a2
    • unknown's avatar
      Merge bk://localhost:5556 · 90d303ee
      unknown authored
      into  blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25673
      
      90d303ee
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug25673 · 270016d8
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug25673
      
      
      storage/myisam/rt_index.c:
        Auto merged
      270016d8
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug25673 · 20d87068
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug25673
      
      
      myisam/rt_index.c:
        Auto merged
      20d87068
    • unknown's avatar
      Bug#25673 - spatial index corruption, error 126 incorrect key file for table · 1c5790bc
      unknown authored
      Fixed a compiler warning, deteced by pushbuild only.
      
      1c5790bc
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 8b3468ce
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      sql/item.cc:
        Auto merged
      8b3468ce
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 50ff3c62
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26281-5.0-opt
      
      50ff3c62
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · 95342119
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      95342119
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 38cd620f
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26281-5.0-opt
      
      
      sql/item_strfunc.cc:
        Auto merged
      mysql-test/r/func_str.result:
        resolved test merge conflicts
      mysql-test/t/func_str.test:
        resolved test merge conflicts
      38cd620f
    • unknown's avatar
      Bug #26281: · 77d751de
      unknown authored
       Fixed boundry checks in the INSERT() function:
       were one off.
      
      
      mysql-test/r/func_str.result:
        Bug #26281: test case
      mysql-test/t/func_str.test:
        Bug #26281: test case
      sql/item_strfunc.cc:
        Bug #26281: fixed boundry checks
      77d751de
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d9834d8b
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/item.cc:
        Auto merged
      d9834d8b
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 95d61b58
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug26661
      
      95d61b58
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · a0260258
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      a0260258
    • unknown's avatar
      Fixed bug #26661: crash when order by clause in a union · d738e0ea
      unknown authored
      construct references invalid name.
      Derived tables currently cannot use outer references.
      Thus there is no outer context for them.
      The 4.1 code takes this fact into account while the 
      Item_field::fix_outer_field code of 5.0 lost the check that blocks
      any attempts to resolve names in outer context for derived tables.
      
      
      mysql-test/r/union.result:
        Added a test case for bug #26661.
      mysql-test/t/union.test:
        Added a test case for bug #26661.
      sql/item.cc:
        Fixed bug #26661.
        Derived tables currently cannot use outer references.
        Thus there is no outer context for them.
        The 4.1 code takes this fact into account while the 
        Item_field::fix_outer_field code of 5.0 lost the check that blocks
        any attempts to resolve names in outer context for derived tables.
      d738e0ea
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 5fbc4d9d
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      5fbc4d9d
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · e7836808
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/order_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/order_by.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      mysql-test/t/func_str.test:
        merging
      mysql-test/t/view.test:
        merging
      e7836808
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · e504208f
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      e504208f
    • unknown's avatar
      aftermerge fix · c5082ada
      unknown authored
      
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      c5082ada
    • unknown's avatar
      aftermerge fix · 7ce5a98e
      unknown authored
      
      mysql-test/r/view.result:
        merging
      7ce5a98e
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 0406a56d
      unknown authored
      into  blade08.mysql.com:/data0/istruewing/autopush/mysql-5.1-bug25673
      
      0406a56d