1. 04 Oct, 2006 1 commit
    • unknown's avatar
      Bug#19356: Assert on undefined @uservar in prepared statement execute · 115121b1
      unknown authored
      The executing code had a safety assertion so that it refused to free Items
      that it didn't create.  However, there is a case, undefined user variables,
      which would put Items into the list to be freed.
      
      Instead, do something that is more risky in expectation that the code will 
      be refactored soon, as Kostja wants to do:  Remove the assertions from 
      prepare() and execute().  Put one assertion at a higher level, before 
      stmt->set_params_from_vars(), which may then create new to-be-freed Items .
      
      
      mysql-test/r/ps_11bugs.result:
        Create tests to prove that undefined variables work, as keys and not, and 
        that variables explicitly assigned to Null work.
      mysql-test/t/ps_11bugs.test:
        Create tests to prove that undefined variables work, as keys and not, and 
        that variables explicitly assigned to Null work.
      sql/sql_prepare.cc:
        Move a safety assertion up one level and higher, because there is 
        legitimately a case where thd->free_list is not NULL going into 
        Prepared_statement::{prepare,execute} methods.
        
        Kostja plans to refactor this code so that it is both safe and works.  
        (Now it works, but isn't very safe.)
      115121b1
  2. 29 Sep, 2006 3 commits
    • unknown's avatar
      Fix merge of __attribute__ cleanup. · 80b4a8e0
      unknown authored
      
      include/my_sys.h:
        Fix bad merge
      sql/set_var.cc:
        Fix bad __attribute__ usage.
      80b4a8e0
    • unknown's avatar
      Merge rama.(none):/home/jimw/my/mysql-4.1-clean · ceb91b56
      unknown authored
      into  rama.(none):/home/jimw/my/mysql-5.0-clean
      
      
      include/m_ctype.h:
        Auto merged
      include/m_string.h:
        Auto merged
      include/my_global.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      include/my_sys.h:
        Resolve conflict
      sql/mysql_priv.h:
        Resolve conflict
      sql/mysqld.cc:
        Resolve conflict
      sql/opt_range.cc:
        Resolve conflict
      sql/sql_acl.cc:
        Resolve conflict
      ceb91b56
    • unknown's avatar
      Merge rama.(none):/home/jimw/my/mysql-5.0-18246 · 5207747a
      unknown authored
      into  rama.(none):/home/jimw/my/mysql-5.0-clean
      
      5207747a
  3. 15 Sep, 2006 23 commits
  4. 14 Sep, 2006 6 commits
  5. 13 Sep, 2006 7 commits