1. 25 Jan, 2011 3 commits
    • Marko Mäkelä's avatar
      1434a3f1
    • Marko Mäkelä's avatar
      Bug#59707 Unused compression-related parameters in buffer pool functions · 57d33262
      Marko Mäkelä authored
      buf_block_alloc(): ulint zip_size is always 0.
      buf_LRU_get_free_block(): ulint zip_size is always 0.
      buf_LRU_free_block(): ibool* buf_pool_mutex_released is always NULL.
      
      Remove these parameters.
      
      buf_LRU_get_free_block(): Simplify the initialization of block->page.zip
      and release buf_pool_mutex() earlier.
      57d33262
    • Sunny Bains's avatar
      Fix Bug #59683 :InnoDB latch deadlock detector/violation debug code is very slow · 5f908ee4
      Sunny Bains authored
      There are two main pain points, one is lookup by thread id for sync_thread_t
      and the other is to do a lookup  by latch or level in sync_thread_t::levels.
      Changed the sync_thread_t::levels lookup and reserve operation from O(N)
      to O(1).
      
      Pure lookups are still O(N), the main change for pure lookup is that we no
      longer need to search up to SYNC_THREAD_N_LEVELS but only up to the number
      of slots actually ever used ie. it is possible some were used in the past
      but are now on the free list. If the in_use count drops to 0 we reset the
      free list too.
      
      Overload the sync_level_t::level field to track the free list. If
      sync_thread_t::latch == NULL then sync_thread_t::level contains the ordinal
      value of the previous free entry.
      
      rb://580 Approved by Jimmy Yang.
      5f908ee4
  2. 24 Jan, 2011 5 commits
  3. 20 Jan, 2011 3 commits
  4. 19 Jan, 2011 10 commits
  5. 18 Jan, 2011 19 commits
    • Libing Song's avatar
      Automerge · 7992b0a2
      Libing Song authored
      7992b0a2
    • Anitha Gopi's avatar
      automerge · 98fc54a0
      Anitha Gopi authored
      98fc54a0
    • Anitha Gopi's avatar
    • Libing Song's avatar
      Manual merge · d12d5584
      Libing Song authored
      d12d5584
    • Libing Song's avatar
      Bug#58546 test rpl_packet timeout failure sporadically on PB · 84e4bdbf
      Libing Song authored
                  
      rpl_packet got a timeout failure sporadically on PB when stopping
      slave. The real reason of this bug is that STOP SLAVE stopped
      IO thread first and then stopped SQL thread. It was
      possible that IO thread stopped after replicating part of a
      transaction which SQL thread was executing. SQL thread would
      be hung if the transaction could not be rolled back safely.
                  
      After this patch, STOP SLAVE will stop SQL thread first and then stop IO
      thread, which guarantees that IO thread will fetch the reset of the
      events of the transaction that SQL thread is executing, so that SQL
      thread can finish the transaction if it cannot be rolled back safely.
                  
      Added below auxiliary files to make the test code neater.
      restart_slave_sql.inc
      rpl_connection_master.inc
      rpl_connection_slave.inc
      rpl_connection_slave1.inc
      84e4bdbf
    • John H. Embretsen's avatar
      Post push test fix for show_check.test. · 72b448f0
      John H. Embretsen authored
      Fix for bug#45740 introduced test case using SHOW TABLE STATUS against a Memory table using latin1 character in table name.
      The test failed on Windows and FreeBSD due to a difference in the value for Avg_row_length.
      The average row length normally depends on the values for data length and row count. According to the 5.5 manual data length is approximate with Memory tables.
      With MyISAM and InnoDB the Avg_row_length is the same on Windows and Solaris.
      The solution implemented by this patch is to mask out the value for Avg_row_length, as it may vary when using Memory tables.
      72b448f0
    • Bjorn Munch's avatar
      upmerge undo of 59063 · e5effc9b
      Bjorn Munch authored
      e5effc9b
    • Bjorn Munch's avatar
      Bug #59063 rpl_migration_crash_safe fails on Windows · 0bb2c151
      Bjorn Munch authored
      Undoing the patch, it complicates the code but is not the solution
      
      I do not beleive newline mismatch could be the cause of this failure
      First, I cannot see how this could be a problem, mtr ignores the newline
        when reading the expect file, and the file is written and read on Windows.
      Second, if this really was the problem it should have been deterministic:
        either the newline is correctly interepreted or it is not.
      0bb2c151
    • Bjorn Munch's avatar
      oops forgot one file in last commit · 3565f4fd
      Bjorn Munch authored
      3565f4fd
    • Bjorn Munch's avatar
      Some more copyright fixes in mtr · 80fcb883
      Bjorn Munch authored
      80fcb883
    • Bjorn Munch's avatar
      Some more copyright fixes in mtr · 057eaa03
      Bjorn Munch authored
      057eaa03
    • Marko Mäkelä's avatar
      ebe817a5
    • Marko Mäkelä's avatar
      Bug#59579 rw_lock_debug_print outputs to stderr · 91125c30
      Marko Mäkelä authored
      rw_lock_debug_print(): Add parameter FILE* for specifying the output stream.
      rw_lock_list_print_info(): Invoke rw_lock_debug_print() on file, not stderr.
      91125c30
    • Bjorn Munch's avatar
      Fixed copyright headers in mtr src files · 41471223
      Bjorn Munch authored
      41471223
    • Bjorn Munch's avatar
      Fixed copyright headers in mtr src files · eb420d82
      Bjorn Munch authored
      eb420d82
    • Alexander Barkov's avatar
      Merging from 5.1. · 36e96e53
      Alexander Barkov authored
      36e96e53
    • Alexander Barkov's avatar
      Bug#44332 my_xml_scan reads behind the end of buffer · 19f4e4d6
      Alexander Barkov authored
      Problem: the scanner function tested for strings "<![CDATA[" and
      "-->" without checking input string boundaries, which led to valgrind's
      "Conditional jump or move depends on uninitialised value(s)" error.
      
      Fix: Adding boundary checking.
      
        @ mysql-test/r/xml.result
        @ mysql-test/t/xml.test
        Adding test
      
        @ strings/xml.c
        Adding a helper function my_xml_parser_prefix_cmp(),
        with input string boundary check.
      19f4e4d6
    • Vinay Fisrekar's avatar
      Merge from mysql-5.1 for · c70b239e
      Vinay Fisrekar authored
      sys_vars.innodb_max_dirty_pages_pct_func fails sporadically
            
      c70b239e
    • Vinay Fisrekar's avatar
      · 5302bb48
      Vinay Fisrekar authored
      BUG#58858 : sys_vars.innodb_max_dirty_pages_pct_func fails sporadically
      
      Committing After latest merge.      
      Modified check_pct procedure to check return value of wait condition instead 
      of calling "dirty_pct".
         
      Adding Review comments:
      1) Added comment for success variable value
      2) Procedure check_pct changed For Adding BOOLEAN input and SELECT QUERY Change
      5302bb48