1. 15 May, 2009 1 commit
    • Satya B's avatar
      Fix for BUG#10206 - InnoDB: Transaction requiring Max_BinLog_Cache_size > 4GB · 143d70a9
      Satya B authored
                          always rollsback.
      
      The global variable max_binlog_cache_size cannot be set more than 4GB on
      32 bit systems, limiting transactions of all storage engines to 4G of changes.
      
      The problem is max_binlog_cache_size is declared as ulong which is 4 bytes
      on 32 bit and 8 bytes on 64 bit machines.
      
      Fixed by using ulonglong for max_binlog_cache_size which is 8bytes on 32 
      and 64 bit machines.The range for max_binlog_cache_size on 32 bit and 64 bit
      systems is 4096-18446744073709547520 bytes.
      
      mysql-test/r/variables.result:
        Result file for BUG#10206
      mysql-test/t/variables.test:
        Testcase for BUG#10206
      sql/mysql_priv.h:
        change the extern declaration of max_binlog_cache_size to ulonglong
      sql/mysqld.cc:
        change the declaration of max_binlog_cache_size to ulonglong and the option is fixed to extend the range of max_binlog_cache_size
      sql/set_var.cc:
        change the variable declaration of max_binlog_cache_size to ulonglong
      143d70a9
  2. 02 May, 2009 1 commit
    • Serge Kozlov's avatar
      Bug#38077. · 57d7b826
      Serge Kozlov authored
      1. Replace waiting of SQL thread stop by waiting of SQL error on slave and stopped
      SQL thread.
      2. Remove debug code because it already implemented in MTR2.
      57d7b826
  3. 30 Apr, 2009 25 commits
  4. 29 Apr, 2009 9 commits
    • Martin Hansson's avatar
      merge · d1ebabdd
      Martin Hansson authored
      d1ebabdd
    • Vladislav Vaintroub's avatar
      merge · 2b438467
      Vladislav Vaintroub authored
      2b438467
    • Martin Hansson's avatar
      Bug#43737: Select query return bad result · f3c87bae
      Martin Hansson authored
            
      A bug in the initialization of key segment information made it point
      to the wrong bit, since a bit index was used when its int value
      was needed. This lead to misinterpretation of bit columns
      read from MyISAM record format when a NULL bit pushed them over
      a byte boundary.
      Fixed by using the int value of the bit instead.
      
      
      mysql-test/r/myisam.result:
        Bug#43737: Test result.
      mysql-test/t/myisam.test:
        Bug#43737: Test case.
      storage/myisam/mi_open.c:
        Bug#43737: fix.
      f3c87bae
    • Vladislav Vaintroub's avatar
      Bug#43932 myisam index corruption with large index and large · 2d626787
      Vladislav Vaintroub authored
      key_buffer_size.
      
      The cause of corruption was number overflow when multiplying 
      two ulong values, number of used keycache blocks with size
      of a single block. The result of multiplication exceeded ulong 
      range (4G) and this lead to incorrectly calculated  buffer offset
      in the key cache.
      
      The fix is to use size_t for multiplication result.
      
      This patch also fixes pointless cast in safemalloc 
      (size of allocated block to uint), that creates lot of false
      alarm warnings when using big keycache (> 4GB) in debug mode.
      2d626787
    • Narayanan V's avatar
      Bug#44337 Select query using index merge fails with MCH3601 · eda569e9
      Narayanan V authored
      The storage engine was not correctly handling the case in 
      which rnd_pos is executed for a handler without a preceding
      rnd_next or index read operation. As a result, an unitialized
      file handle was sometimes being passed to the QMY_READ API.
      
      The fix clears the rrnAssocHandle at the beginning of each
      read operation and then checks to see whether it has been
      set to a valid handle value before attempting to use it
      in rnd_pos. If rrnAssocHandle has not been set by a previous
      read operation, rnd_pos instead falls back to the use of the
      currently active handle.
      
      storage/ibmdb2i/ha_ibmdb2i.cc:
        Bug#44337 Select query using index merge fails with MCH3601
        
        - clear the rrnAssocHandle at the beginning of each
          read operation 
        - checks to see whether it has been set to a valid
          handle value before attempting to use it in rnd_pos
      eda569e9
    • Alexey Botchkov's avatar
      merging · d391695c
      Alexey Botchkov authored
      d391695c
    • Alexey Botchkov's avatar
      merging · 007c1e3a
      Alexey Botchkov authored
      007c1e3a
    • Alexey Botchkov's avatar
      merging · 4e14b369
      Alexey Botchkov authored
      4e14b369
    • Alexey Botchkov's avatar
      merging · fe1f6361
      Alexey Botchkov authored
      fe1f6361
  5. 28 Apr, 2009 4 commits