1. 29 Jun, 2005 1 commit
    • unknown's avatar
      ha_innodb.cc: · 14b71228
      unknown authored
        Let InnoDB use a consistent read when it initializes the auto-inc counter for a table: this will eliminate spurious deadlocks, but will ignore an UPDATE if that happens at the same time that we init the auto-inc counter; this has to be documented; this path also fixes most of Bug #11633, but not all: if ::external_lock() is not called on the table in SHOW TABLE STATUS, that might cause a crash if someone simultaneously DROPs the table
      
      
      sql/ha_innodb.cc:
        Let InnoDB use a consistent read when it initializes the auto-inc counter for a table: this will eliminate spurious deadlocks, but will ignore an UPDATE if that happens at the same time that we init the auto-inc counter; this has to be documented; this path also fixes most of Bug #11633, but not all: if ::external_lock() is not called on the table in SHOW TABLE STATUS, that might cause a crash if someone simultaneously DROPs the table
      14b71228
  2. 27 Jun, 2005 16 commits
    • unknown's avatar
      Fix typo in --default-store-engine help. (Bug #11534) · c3abc8f0
      unknown authored
      
      sql/mysqld.cc:
        Fix typo
      c3abc8f0
    • unknown's avatar
      Many files: · 118978eb
      unknown authored
        Remove compiler warnings on Windows - Bug #11580
      
      
      innobase/btr/btr0btr.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/btr/btr0cur.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/fil/fil0fil.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/ibuf/ibuf0ibuf.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/log/log0recv.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/os/os0file.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/page/page0page.c:
        Remove compiler warnings on Windows - Bug #11580
      innobase/row/row0upd.c:
        Remove compiler warnings on Windows - Bug #11580
      118978eb
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · f4a72069
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      f4a72069
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · 57c8f4ef
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      57c8f4ef
    • unknown's avatar
      Include <sys/wait.h> to get WEXITSTATUS · dca8f40c
      unknown authored
      dca8f40c
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · 9ef5c755
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      9ef5c755
    • unknown's avatar
      Add "#include <stdlib.h>" to define WEXITSTATUS · 952ad99c
      unknown authored
      952ad99c
    • unknown's avatar
      Simpler impl. · 51fa5733
      unknown authored
      
      sql/sql_parse.cc:
        Just do a simple sprintf to format error message.
      51fa5733
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · fed72117
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/bug10466
      
      
      mysql-test/r/alias.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_6bdb.result:
        Auto merged
      mysql-test/r/ps_7ndb.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/alias.test:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      fed72117
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 85c0b742
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      85c0b742
    • unknown's avatar
      Merge problem fixes · 69487da2
      unknown authored
      
      mysql-test/r/client_xml.result:
        Update testresult
      mysql-test/r/ndb_autodiscover.result:
        Moving order opf test results to match test execution order
      69487da2
    • unknown's avatar
      Fix the broken test suite in -debug build. · 3bcab50f
      unknown authored
      
      sql/sql_select.cc:
        If we use subqueries, we can have double-free of tmp_table_param.copy_field
        in JOIN::destroy and in JOIN::join_free because.
      3bcab50f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 778a9b56
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      778a9b56
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · a6ef5ed9
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      a6ef5ed9
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 9eb9eca7
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      9eb9eca7
    • unknown's avatar
      Fix for Intel compiler · fc88e43f
      unknown authored
      fc88e43f
  3. 25 Jun, 2005 1 commit
  4. 24 Jun, 2005 22 commits
    • unknown's avatar
      Free unused JOINs early even if using subqueries. · 04f08168
      unknown authored
      
      sql/sql_select.cc:
        According to the conclusion made in the previous patch, we can widen
        the range of cases when JOINs are fully freed early, and include 
        subqueries to it.
      04f08168
    • unknown's avatar
      Remove an unrelevant assert. · dab66aa3
      unknown authored
      
      sql/sql_select.cc:
        This assert is not relevant because:
        - the correct assert is DBUG_ASSERT(! (full && sl->uncacheable)) 
          (prevents freeing of uncacheable JOINs), it breaks view.test
        - it seems we can free internal JOINs, even if they are uncacheable:
          if the top level join is evaluated, we're not going to need  the
          internal joins any more
      dab66aa3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 072779c0
      unknown authored
      into mysql.com:/opt/local/work/mysql-5.0-join_free2push
      
      072779c0
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 820abd29
      unknown authored
      into mysql.com:/opt/local/work/mysql-5.0-join_free2push
      
      
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      820abd29
    • unknown's avatar
      - don't call JOIN::join_free(1) twice for every join in JOIN::cleanup(). · d662c283
      unknown authored
      The reason it happened was that both, JOIN::cleanup() and JOIN::join_free(),
      went over all nested joins and called cleanup/join_free for them.
      For that:
      - split recursive and non-recursive parts of JOIN::cleanup() and
      JOIN::join_free()
      - rename JOIN::cleanup to JOIN::destroy, as it actually destroys its
        argument
      - move the recursive part of JOIN::cleanup to st_select_lex::cleanup
      - move the non-recursive part of JOIN::join_free to the introduced
        method JOIN::cleanup().
      
      
      sql/sql_lex.h:
        Add st_select_lex::cleanup, a counterpart of st_select_lex_unit::cleanup()
      sql/sql_select.cc:
        - remove two unused arguments from return_zero_rows
        - split JOIN::join_free and JOIN::cleanup to recursive and non-recursive
          parts.
        - note, the assert in JOIN::join_free _does_ fail in having.test.
          We have two options: a) propagate `full' flag to the nested joins.
          We did it before, and this patch didn't change it. If so, we 
          can end up cleaning up an uncacheable JOIN (that is, the join that
          we might need again).
          b) evaluate own 'full' flag on every level. In this case, we might
          end up with tables freed in mysql_unlock_read_tables, but not
          cleaned up properly, and this may be even worse. The test suite
          passes with both approaches, but not with the assert.
      sql/sql_select.h:
        - declarations for JOIN::cleanup() and JOIN::join_free()
      sql/sql_union.cc:
        Add st_select_lex::cleanup, a counterpart of st_select_lex_unit::cleanup():
        move the recursive part of JOIN::cleanup to it.
      d662c283
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · f593a201
      unknown authored
      into mysql.com:/home/mydev/mysql-5.0-bug8321
      
      f593a201
    • unknown's avatar
      Bug#10178 - failure to find a row in heap table by concurrent UPDATEs · 3972a3d2
      unknown authored
      After merge fixes of test result.
      
      3972a3d2
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0-release · a744d53e
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      a744d53e
    • unknown's avatar
      Bug#10178 - failure to find a row in heap table by concurrent UPDATEs · 858cf840
      unknown authored
      Bug#10568 - Function 'LAST_DAY(date)' does not return NULL for invalid argument.
      Manual merge.
      
      
      include/my_global.h:
        Auto merged
      mysql-test/t/heap_hash.test:
        Auto merged
      sql/ha_heap.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      mysql-test/r/func_time.result:
        Manual merge.
        Used local for the backported fix for Bug#10568.
      mysql-test/r/heap_hash.result:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Manual merge.
      mysql-test/t/func_time.test:
        Manual merge.
        Used local for the backported fix for Bug#10568.
      sql/ha_heap.cc:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Manual merge.
      858cf840
    • unknown's avatar
      Merge · 32f26266
      unknown authored
      
      mysql-test/r/view.result:
        SCCS merged
      mysql-test/t/view.test:
        SCCS merged
      32f26266
    • unknown's avatar
      Bug#8321 - myisampack bug in compression algorithm · 2ee77549
      unknown authored
      Added 64-bit extensions, comments, extended statistics 
      and trace prints.
      
      
      include/my_base.h:
        Bug#8321 - myisampack bug in compression algorithm
        Added a comment.
      myisam/mi_packrec.c:
        Bug#8321 - myisampack bug in compression algorithm
        Fixed a function comment.
      myisam/myisampack.c:
        Bug#8321 - myisampack bug in compression algorithm
        Enlarged the variables which hold Huffman codes to
        ulonglong and adjusted the functions accordingly.
        Added test code for long Huffman codes.
        Enlarged the distinct column values buffer (tree_buff)
        and added checks to stay in its range.
        Added statistics and trace prints.
        Added a lot of comments.
      mysys/tree.c:
        Bug#8321 - myisampack bug in compression algorithm
        Added a check against overflow of the tree element count.
        The tree element count is only 31 bits, but sometimes
        used for big numbers. There is however no application yet,
        which relies on exact tree element counts.
      2ee77549
    • unknown's avatar
      mysql-test-run.pl: · c737ba47
      unknown authored
        Corrected master server id's
      
      
      mysql-test/mysql-test-run.pl:
        Corrected master server id's
      c737ba47
    • unknown's avatar
      Fix bug#11325 Wrong date comparison in views · 1c41c30f
      unknown authored
      Wrong comparing method were choosen which results in false comparison.
      
      Make Item_bool_func2::fix_length_and_dec() to get type and field from
      real_item() to make REF_ITEM pass the check. 
      
      
      sql/item_cmpfunc.cc:
        Fix bug#11325 Wrong date comparison in views
      mysql-test/t/view.test:
        Test case for bug#11325 Wrong date comparison in views.
      mysql-test/r/view.result:
        Test case for bug#11325 Wrong date comparison in views.
      1c41c30f
    • unknown's avatar
      Bug#10178 - failure to find a row in heap table by concurrent UPDATEs · 8f490b2c
      unknown authored
      Moved the key statistics update to info().
      The table is not locked in open(). This made wrong stats possible.
      
      No test case for the test suite.
      This happens only with heavy concurrency.
      A test script is added to the bug report.
      
      
      mysql-test/r/heap_hash.result:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Updated test results to reflect the new  statistics behaviour.
      mysql-test/t/heap_hash.test:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Added a FLUSH TABLES to avoid statistics differences between normal 
        and ps-protocol tests.
      sql/ha_heap.cc:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Moved the key statistics update to info().
        The table is not locked in open(). This made wrong stats possible.
      sql/ha_heap.h:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Added an element to track the validity of the key statistics.
      8f490b2c
    • unknown's avatar
      mysql-test-run.sh: · 76927517
      unknown authored
        Corrected path to CA certificate
      
      
      mysql-test/mysql-test-run.sh:
        Corrected path to CA certificate
      76927517
    • unknown's avatar
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · a2d53075
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-5.0
      
      a2d53075
    • unknown's avatar
      field.cc: · 58f17a16
      unknown authored
        Correction after manula merge.
      
      
      sql/field.cc:
        Correction after manula merge.
      58f17a16
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-release · f60cc405
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-release
      
      f60cc405
    • unknown's avatar
      an improvement (bug #7851: C++ 'new' conflicts with kernel header asm/system.h). · 5eef0d8c
      unknown authored
      
      include/my_global.h:
        an improvement (bug #7851: C++ 'new' conflicts with kernel header asm/system.h).
        redefine 'new' before #include <asm/atomic.h> in any case.
      5eef0d8c
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · c6415c97
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-bug3-5.0
      
      c6415c97
    • unknown's avatar
      Merge tkatchaounov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 231f70fb
      unknown authored
      into mysql.com:/home/timka/mysql/src/5.0-virgin
      
      231f70fb