1. 30 Nov, 2022 7 commits
  2. 29 Nov, 2022 2 commits
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-30119 INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION.NAME is NULL for undo tablespaces · bb29712b
      Thirunarayanan Balathandayuthapani authored
      - Information_schema.innodb_tablespaces_encryption should print
      undo tablespace name as innodb_undo001, innodb_undo002 and soon.
      
      - Encryption test should include undo tablespaces count when
      the tests are waiting for the condition to check whether all
      tables are encrypted or decrypted.
      bb29712b
    • anson1014's avatar
      Extend GitLab CI with build and test jobs for sanitizers (#2174) · c1de3776
      anson1014 authored
      Add a build and test job for each of ASAN, MSAN, TSAN, and UBSAN to the
      GitLab pipeline such that current vulnerabilities will be more easily
      visible and on each new commit, we can ensure that there are no
      additional errors introduced. Furthermore, sanitizer test runs are run
      separate from the existing mysql-test-run to isolate sanitizer error
      from functional errors.
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer
      Amazon Web Services, Inc.
      c1de3776
  3. 28 Nov, 2022 6 commits
    • Daniel Black's avatar
      MDEV-23230 wsrep files installed when built without WSREP (#2334) · 7b44d0ba
      Daniel Black authored
      Prevent wsrep files from being installed if WITH_WSREP=OFF.
      
      Reviewed by Daniel Black
      Additionally excluded #include wsrep files and galera* files
      along with galera/wsrep tests.
      
      mysql-test/include/have_wsrep.inc remainds as its used by
      a few isolated tests.
      Co-authored-by: default avatarChris Ross <cross2@cisco.com>
      7b44d0ba
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · fdc582fd
      Marko Mäkelä authored
      fdc582fd
    • Marko Mäkelä's avatar
      MDEV-24412 InnoDB: Upgrade after a crash is not supported · bd694bb7
      Marko Mäkelä authored
      recv_log_recover_10_4(): Widen the operand of bitwise and to 64 bits,
      so that the upgrade check will work when the redo log record is located
      more than 4 gigabytes from the start of the first file.
      bd694bb7
    • Marko Mäkelä's avatar
      MDEV-30106 InnoDB fails to validate the change buffer on startup · db14eb16
      Marko Mäkelä authored
      ibuf_init_at_db_start(): Validate the change buffer root page.
      A later version may stop creating a change buffer, and this
      validation check will prevent a downgrade from such later versions.
      
      ibuf_max_size_update(): If the change buffer was not loaded, do nothing.
      
      dict_boot(): Merge the local variable "error" to "err". Ignore
      failures of ibuf_init_at_db_start() if innodb_force_recovery>=4.
      db14eb16
    • Marko Mäkelä's avatar
      MDEV-30089 Metrics not incremented for 1st iteration in buf_LRU_free_from_common_LRU_list() · e0d672f3
      Marko Mäkelä authored
      In commit a03dd94b as well as
      mysql/mysql-server@6ef8c343445a26aaf9ebd76d72cf57db44b481f5
      the iterations were changed so that the variable "scanned"
      would remain 0 when the first list item qualifies for eviction.
      
      buf_LRU_free_from_unzip_LRU_list(), buf_LRU_free_from_common_LRU_list():
      Increment "scanned" when a block can be freed.
      
      buf_LRU_free_from_common_LRU_list(): Remove a redundant condition.
      Whenever this function is invoked, buf_pool.LRU should be nonempty,
      hence something should always be scanned.
      
      Thanks to Jean-François Gagné for reporting this.
      e0d672f3
    • Daniel Black's avatar
      MDEV-25417: Remove innodb buffer pool load throttling · 183ca823
      Daniel Black authored
      The very lightest of load would decimate any buffer pool loading
      to ~1 page per second. As seen in MDEV-29343 this resulting in
      a load taking over an hour on a high end system.
      
      Since MDEV-26547 the fetching is asynchronous, however the loading
      has equal access to the IO as the SQL queries.
      183ca823
  4. 25 Nov, 2022 3 commits
    • Brandon Nesterenko's avatar
      MDEV-29607: binlog.binlog_checkpoint fails in buildbot with result content mismatch · 812443c2
      Brandon Nesterenko authored
      Problem:
      ========
      There is a race condition in binlog.binlog_checkpoint between the
      binlog background thread creating a binlog checkpoint event, and the
      connection thread binlogging a query event for creating a table.
      Because the test outputs the events for validation, the order
      between these two events can be different, resulting in a failed
      test.
      
      Solution:
      ========
      Instead of outputting the binlog events, use assert_grep to validate
      the content of the binlog is correct.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      812443c2
    • Daniel Black's avatar
      Query cache: removed unused THD from few functions · 7919b143
      Daniel Black authored
      A few query cache functions don't use THD pointer
      so its removed from their interface.
      7919b143
    • Daniel Black's avatar
      MDEV-29760: DROP DATABASE hangs when particular query cache is present · 7141c260
      Daniel Black authored
      Fix the regression introduced in
      dfb41fdd.
      
      In the restructure of mysql_rm_table_no_locks the early condition
      of !frm_error that enabled non_tmp_table_deleted, and hence the
      query cache invalidation, was removed.
      
      The query_cache_invalidate1(thd, dbnorm) called after
      mysql_rm_table_no_locks depends on the query cache removal
      (for unexamined reasons).
      
      Under DROP DATABASE, in mysql_rm_table_no_locks, dont_log_query
      is true preventing the late setting of non_tmp_table_deleted
      (which retained one of its purposes as a replication deletion
      of temporary tables, but not query cache invalidation).
      
      The non_temp_tables_count however can still be used to invalidate
      the query cache.
      7141c260
  5. 24 Nov, 2022 3 commits
  6. 23 Nov, 2022 2 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 6d40274f
      Marko Mäkelä authored
      6d40274f
    • Marko Mäkelä's avatar
      MDEV-30009 InnoDB shutdown hangs when the change buffer is corrupted · 165564d3
      Marko Mäkelä authored
      The InnoDB change buffer (ibuf.index, stored in the system tablespace)
      and the change buffer bitmaps in persistent tablespaces could get out
      of sync with each other: According to the bitmap, no changes exist for
      a page, while there actually exist buffered entries in ibuf.index.
      
      InnoDB performs lazy deletion of buffered changes. When a secondary
      index leaf page is freed (possibly as part of DROP INDEX), any
      buffered changes will not be deleted. Instead, they would be deleted
      on a subsequent buf_page_create_low().
      
      One scenario where InnoDB failed to delete buffered changes is
      as follows:
      1. Some changes were buffered for a secondary index leaf page.
      2. The index page had been freed.
      3. ibuf_read_merge_pages() invoked ibuf_merge_or_delete_for_page(),
      which noticed that the page had been freed, and reset the change buffer
      bits, but did not delete the records from ibuf.index.
      4. The index page was reallocated for something else.
      5. The index page was removed from the buffer pool.
      6. Some changes were buffered for the newly created page.
      7. Finally, the buffered changes from both 1. and 6. were merged.
      8. The index is corrupted.
      
      An alternative outcome is:
      4. Shutdown with innodb_fast_shutdown=0 gets into an infinite loop.
      
      An alternative scenario is:
      3. ibuf_set_bitmap_for_bulk_load() reset the IBUF_BITMAP_BUFFERED bit
      but did not delete the ibuf.index records for that page number.
      
      The shutdown hang was already once fixed in
      commit d7a24017, refactored for
      10.5 in commit 77e8a311 and
      disabled in commit 310dff5d
      due to corruption.
      
      We will fix this as follows:
      
      ibuf_delete_recs(): Delete all ibuf.index entries for the specified page.
      
      ibuf_merge_or_delete_for_page(): When the change buffer bitmap bits
      were set and the page had been freed, and the page does not belong
      to ibuf.index itself, invoke ibuf_delete_recs(). This prevents the
      corruption from occurring when a DML operation is allocating a
      previously freed page for which changes had been buffered.
      
      ibuf_set_bitmap_for_bulk_load(): When the change buffer bitmap bits
      were set, invoke ibuf_delete_recs(). This prevents the corruption
      from occurring when CREATE INDEX is reusing a previously freed page.
      
      ibuf_read_merge_pages(): On slow shutdown, remove the orphan records
      by invoking ibuf_delete_recs(). This fixes the hang when the change
      buffer had become corrupted. We also remove the dops[] accounting,
      because nothing can monitor it during shutdown. We invoke
      ibuf_delete_recs() if:
      (a) buf_page_get_gen() failed to load the page or merge changes
      (b) the page is not a valid index leaf page
      (c) the page number is out of tablespace bounds
      
      srv_shutdown(): Invoke ibuf_max_size_update(0) to ensure that
      the race condition that motivated us to disable the code in
      ibuf_read_merge_pages() in commit 310dff5d
      is no longer possible. That is, during slow shutdown, both the
      rollback of transactions and the purge of history will return
      early from ibuf_insert_low().
      
      ibuf_merge_space(), ibuf_delete_for_discarded_space(): Cleanup:
      Do not allocate a memory heap.
      
      This was implemented by Thirunarayanan Balathandayuthapani
      and tested with innodb_change_buffering_debug=1 by Matthias Leich.
      165564d3
  7. 22 Nov, 2022 3 commits
  8. 21 Nov, 2022 5 commits
  9. 20 Nov, 2022 4 commits
  10. 17 Nov, 2022 3 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 9aea7d83
      Marko Mäkelä authored
      9aea7d83
    • Marko Mäkelä's avatar
      MDEV-29982 fixup: Relax the test · 41028d70
      Marko Mäkelä authored
      The log overwrite warnings are not being reliably emitted in all
      debug-instrumented environments. It may be related to the
      scheduling of some InnoDB internal activity, such as the purging
      of committed transaction history.
      41028d70
    • Marko Mäkelä's avatar
      MDEV-29603 btr_cur_open_at_index_side() is missing some consistency checks · 24fe5347
      Marko Mäkelä authored
      btr_cur_t: Zero-initialize all fields in the default constructor.
      
      btr_cur_t::index: Remove; it duplicated page_cur.index.
      
      Many functions: Remove arguments that were duplicating
      page_cur_t::index and page_cur_t::block.
      
      page_cur_open_level(), btr_pcur_open_level(): Replaces
      btr_cur_open_at_index_side() for dict_stats_analyze_index().
      At the end, release all latches except the dict_index_t::lock
      and the buf_page_t::lock on the requested page.
      
      dict_stats_analyze_index(): Rely on mtr_t::rollback_to_savepoint()
      to release all uninteresting page latches.
      
      btr_search_guess_on_hash(): Simplify the logic, and invoke
      mtr_t::rollback_to_savepoint().
      
      We will use plain C++ std::vector<mtr_memo_slot_t> for mtr_t::m_memo.
      In this way, we can avoid setting mtr_memo_slot_t::object to nullptr
      and instead just remove garbage from m_memo.
      
      mtr_t::rollback_to_savepoint(): Shrink the vector. We will be needing this
      in dict_stats_analyze_index(), where we will release page latches and
      only retain the index->lock in mtr_t::m_memo.
      
      mtr_t::release_last_page(): Release the last acquired page latch.
      Replaces btr_leaf_page_release().
      
      mtr_t::release(const buf_block_t&): Release a single page latch.
      Used in btr_pcur_move_backward_from_page().
      
      mtr_t::memo_release(): Replaced with mtr_t::release().
      
      mtr_t::upgrade_buffer_fix(): Acquire a latch for a buffer-fixed page.
      This replaces the double bookkeeping in btr_cur_t::open_leaf().
      
      Reviewed by: Vladislav Lesin
      24fe5347
  11. 16 Nov, 2022 2 commits
    • Sergei Golubchik's avatar
      MDEV-25625 Test sys_vars.wsrep_on_without_provider fails: mysqltest: At line... · 4b3b1eb8
      Sergei Golubchik authored
      MDEV-25625 Test sys_vars.wsrep_on_without_provider fails: mysqltest: At line 8: query 'SET GLOBAL wsrep_on=ON' failed with wrong errno 1193: 'Unknown system variable 'wsrep_on'', instead of 1210...
      4b3b1eb8
    • Marko Mäkelä's avatar
      MDEV-29603: Implement btr_cur_t::open_leaf() · 89ec4b53
      Marko Mäkelä authored
      btr_cur_t::open_leaf(): Replaces btr_cur_open_at_index_side() for
      most calls, except dict_stats_analyze_index(), which is the only
      place where we need to open a page at the non-leaf level.
      Use btr_block_get() for better error handling.
      
      Also, use the enumeration type btr_latch_mode wherever possible.
      
      Reviewed by: Vladislav Lesin
      89ec4b53