1. 05 Oct, 2018 1 commit
    • Sergey Vojtovich's avatar
      MDEV-17200 - pthread_detach called for already detached threads · 1655053a
      Sergey Vojtovich authored
      pthread_detach_this_thread() was intended to be defined to something
      meaningful only on some ancient unixes, which don't have
      pthread_attr_setdetachstate() defined. Otherwise, on normal unixes,
      threads are created detached in the first place.
      
      This was broken in 0f01bf26 so that
      we started calling pthread_detach() for already detached threads.
      Intention was to detach aria checkpoint thread.
      
      However in 87007dc2 aria service threads
      were made joinable with appropriate handling, which makes breaking
      revision unneccessary.
      
      Revert remnants of 0f01bf26, so that
      pthread_detach_this_thread() is meaningful only on some ancient unixes
      again.
      1655053a
  2. 04 Oct, 2018 5 commits
  3. 01 Oct, 2018 3 commits
  4. 23 Sep, 2018 4 commits
  5. 22 Sep, 2018 2 commits
  6. 21 Sep, 2018 8 commits
  7. 20 Sep, 2018 3 commits
  8. 19 Sep, 2018 4 commits
  9. 18 Sep, 2018 1 commit
    • Sergey Vojtovich's avatar
      MDEV-14410 - Assertion `table->pos_in_locked_tables == __null || · 327b2717
      Sergey Vojtovich authored
                   table->pos_in_locked_tables->table == table'
                   failed in mark_used_tables_as_free_for_reuse
      
      Assertion failure can be triggered by some DDL executed under LOCK TABLES
      that holds lock for DDL target table multiple times (either explicitly or
      implcitly).
      
      When closing all table instances for given table (e.g. when preparing for
      table removal during CREATE OR REPLACE), only one instance was removed
      from m_locked_tables list.
      
      Later we attempt to re-insert one of the instances in mysql_create_table()/
      add_back_last_deleted_lock(), which wasn't actually removed. This leads
      to m_locks_tables corruption, specifically loss of all following elements.
      
      Then UNLOCK TABLE won't reset some table instances properly (specifically
      pos_in_locked_tables), since they're not present in m_locked_tables.
      
      Eventually such table instance gets released to table cache and then
      re-used by subsequent statement, which triggers this assertion failure.
      327b2717
  10. 17 Sep, 2018 4 commits
  11. 14 Sep, 2018 3 commits
  12. 13 Sep, 2018 2 commits
    • Jacob Mathew's avatar
      MDEV-16912: Spider Order By column[datatime] limit 5 returns 3 rows · 6c47c1c4
      Jacob Mathew authored
      The problem occurs in 10.2 and earlier releases of MariaDB Server because the
      Partition Engine was not pushing the engine conditions to the underlying
      storage engine of each partition.  This caused Spider to return the first 5
      rows in the table with the data provided by the customer.  2 of the 5 rows
      did not qualify the WHERE clause, so they were removed from the result set by
      the server.
      
      To fix the problem, I have back-ported support for engine condition pushdown
      in the Partition Engine from MariaDB Server 10.3.
      
      Author:
        Jacob Mathew.
      
      Reviewer:
        Kentoku Shiba.
      
      Cherry-Picked:
        Commit eb2ca3d4 on branch bb-10.2-MDEV-16912
      6c47c1c4
    • Oleksandr Byelkin's avatar
      try to fix version detection · c9d6728c
      Oleksandr Byelkin authored
      c9d6728c