1. 27 Jun, 2007 1 commit
  2. 25 Jun, 2007 12 commits
  3. 24 Jun, 2007 4 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 362852ba
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/item.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      mysql-test/r/rpl_change_master.result:
        Merge with 5.1.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.1.
      sql/sql_acl.cc:
        Merge with 5.1.
      362852ba
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · f30db309
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25602
      
      
      sql/sql_select.cc:
        Auto merged
      f30db309
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · fec835f1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/log_event.cc:
        Auto merged
      fec835f1
    • unknown's avatar
      Fixed bug #25602. A query with DISTINCT in the select list to which · e009b764
      unknown authored
      the loose scan optimization for grouping queries was applied returned 
      a wrong result set when the query was used with the SQL_BIG_RESULT
      option.
      
      The SQL_BIG_RESULT option forces to use sorting algorithm for grouping
      queries instead of employing a suitable index. The current loose scan
      optimization is applied only for one table queries when the suitable
      index is covering. It does not make sense to use sort algorithm in this
      case. However the create_sort_index function does not take into account
      the possible choice of the loose scan to implement the DISTINCT operator
      which makes sorting unnecessary. Moreover the current implementation of
      the loose scan for queries with distinct assumes that sorting will
      never happen. Thus in this case create_sort_index should not call
      the function filesort.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for bug #25602.
      mysql-test/t/group_min_max.test:
        Added a test case for bug #25602.
      e009b764
  4. 23 Jun, 2007 6 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 1ba9b0a9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      1ba9b0a9
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · b462e06e
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      b462e06e
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 26b526dc
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      libmysql/libmysql.c:
        Merge with 5.0-opt.
      mysql-test/r/insert_select.result:
        Merge with 5.0-opt.
      mysql-test/r/mysqlbinlog.result:
        Merge with 5.0-opt.
      mysql-test/r/rpl_change_master.result:
        Merge with 5.0-opt.
      mysql-test/r/view.result:
        Merge with 5.0-opt.
      mysql-test/t/insert_select.test:
        Merge with 5.0-opt.
      mysql-test/t/mysqlbinlog.test:
        Merge with 5.0-opt.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.0-opt.
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/item.cc:
        Merge with 5.0-opt.
      sql/item.h:
        Merge with 5.0-opt.
      sql/log_event.cc:
        Merge with 5.0-opt.
      sql/sql_select.cc:
        Merge with 5.0-opt.
      26b526dc
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29095 · d37471b4
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      d37471b4
    • unknown's avatar
      Fixed bug #29095. · 1bab1ddc
      unknown authored
      INSERT into table from SELECT from the same table
      with ORDER BY and LIMIT was inserting other data
      than sole SELECT ... ORDER BY ... LIMIT returns.
      
      One part of the patch for bug #9676 improperly pushed
      LIMIT to temporary table in the presence of the ORDER BY
      clause.
      That part has been removed.
      
      
      sql/sql_select.cc:
        Fixed bug #29095.
        One part of the patch for bug #9676 improperly pushed
        LIMIT to temporary table in the presence of the ORDER BY
        clause.
        That part has been removed.
      mysql-test/t/insert_select.test:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      mysql-test/r/insert_select.result:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      1bab1ddc
    • unknown's avatar
      Fix for BUG#29318 "Statements prepared with PREPARE and with one · ba7e22db
      unknown authored
      parameter don't use query cache"
      Thanks to the fix of BUG#26842, statements prepared with SQL PREPARE
      and having parameters can now use the query cache.
      
      
      mysql-test/include/query_cache_sql_prepare.inc:
        now, statements prepared with SQL PREPARE use the query cache even
        when they have parameters.
      mysql-test/r/query_cache_ps_no_prot.result:
        updated result: we see caching happened.
      mysql-test/r/query_cache_ps_ps_prot.result:
        updated result: we see caching happened
      sql/sql_prepare.cc:
        query expansion does not insert user variables' references anymore,
        it now inserts parameters' values (BUG#26842's fix did this);
        so we can use the query cache.
      ba7e22db
  5. 22 Jun, 2007 17 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · e34641b3
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      e34641b3
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · c57535e0
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      c57535e0
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 8541b56c
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      8541b56c
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 957d0156
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      Makefile.am:
        Manual merge.
      957d0156
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/50 · 81d32154
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      81d32154
    • unknown's avatar
      Add the "nist" suite to the "test-bt" target, · 054201f4
      unknown authored
      to be run only if it is available on the machine.
      
      
      054201f4
    • unknown's avatar
      Fix broken automatic dependency tracking of Automake in sql/: · a50a88e2
      unknown authored
      The embedded library is still broken, but there the situation
      with dependencies is even more broken.
      
      
      sql/Makefile.am:
        Fix broken automatic dependency tracking of Automake in sql/:
        use a convenience library to specify additional includes that
        are required to compile files ha_ndbcluster_*, and then
        add this convenience library to the main project.
        The embedded library is still broken, but there the situation
        with dependencies is even more broken.
      a50a88e2
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846 · 40315b49
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      40315b49
    • unknown's avatar
      Bug #28846 Use of undocumented Prepared Statements crashes server · 1eee6b13
      unknown authored
      - Manual merge patch.
      
      
      sql/sql_yacc.yy:
        Corrected merge error. ALTER VIEW rules has been split in two and both
        rules need to be checked for SP-context.
      1eee6b13
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my50-bug28846 · a348b369
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846
      
      
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/r/sp-dynamic.result:
        Auto merged
      mysql-test/r/sp-error.result:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge 5.0->5.1
      a348b369
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f3940eba
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28400-5.0-opt
      
      
      f3940eba
    • unknown's avatar
      Bug #27383: Crash in test "mysql_client_test" · fe036d98
      unknown authored
      The C optimizer may decide that data access operations
      through pointer of different type are not related to 
      the original data (strict aliasing).
      This is what happens in fetch_long_with_conversion(),
      when called as part of mysql_stmt_fetch() : it tries 
      to check for truncation errors by first storing float
      (and other types of data) into a char * buffer and then 
      accesses them through a float pointer.
      This is done to prevent the effects of excess precision
      when using FPU registers.
      However the doublestore() macro converts a double pointer
      to an union pointer. This violates the strict aliasing rule.
      Fixed by making the intermediary variables volatile (
      to not re-introduce the excess precision bug) and using
      the intermediary value instead of the char * buffer.
      Note that there can be loss of precision for both signed
      and unsigned 64 bit integers converted to double and back,
      so the check must stay there (even for compatibility 
      reasons).
      Based on the excellent analysis in bug 28400.
      
      
      libmysql/libmysql.c:
        Bug #27383: avoid pointer aliasing problems while 
        not re-violating the Intel FPU gcc bug.
      fe036d98
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · d4c41aeb
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      d4c41aeb
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · b741a789
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      b741a789
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · bdc32139
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      bdc32139
    • unknown's avatar
      Bug#28846 Use of undocumented Prepared Statements crashes server · 099be801
      unknown authored
      ALTER VIEW is currently not supported as a prepared statement
      and should be disabled as such as they otherwise could cause server crashes.
      
      ALTER VIEW is currently not supported when called from stored
      procedures or functions for related reasons and should also be disabled.
      
      This patch disables these DDL statements and adjusts the appropriate test
      cases accordingly.
      
      Additional tests has been added to reflect on the fact that we do support
      CREATE/ALTER/DROP TABLE for Prepared Statements (PS), Stored Procedures (SP)
      and PS within SP.
      
      
      mysql-test/r/ps_1general.result:
        - Updated test to reflect on the new policy to disallow ALTER VIEW within SP.
      mysql-test/r/sp-dynamic.result:
        - Added PS ALTER TABLE test from within SP-context to demonstrate that CREATE/ALTER/DROP
        TABLE statements is working.
        - Added PS CREATE/ALTER/DROP VIEW tests from within SP-context to show that
        ALTER VIEW is not supported, CREATE VIEW/DROP VIEW are supported.
      mysql-test/r/sp-error.result:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/ps_1general.test:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/sp-dynamic.test:
        - Add PS ALTER TABLE test from within SP to demonstrate that CREATE/ALTER/DROP
        TABLE statements are supported.
      mysql-test/t/sp-error.test:
        - Updated test to reflect on the new policy to disallow ALTER VIEW
        within SP-context.
        - Changed error code 1314 to the more abstract ER_SP_BADSTATEMENT.
      sql/sql_class.h:
        - Added comment for clarity
      sql/sql_parse.cc:
        - Added comment for clarity
      sql/sql_prepare.cc:
        - Disallow ALTER VIEW as prepared statements until they are
          properly supported. Note that SQLCOM_CREATE_VIEW also handles ALTER VIEW
          statements.
      sql/sql_view.cc:
        - converted to doxygen comments
        - Added comment for clarity
      sql/sql_yacc.yy:
        - Disallow ALTER VIEW statements within a SP.
        If the parser is operating within the SP context, this is shown
        on the sp->sphead pointer. If this flag is set for view DDL operations
        we stop parsing with the error 'ER_SP_BAD_STATEMENT'.
      099be801
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · dc0ba2ef
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      dc0ba2ef