1. 24 Feb, 2009 1 commit
  2. 23 Feb, 2009 5 commits
    • Anurag Shekhar's avatar
      merging with changes in bugteam branch. · e91a9167
      Anurag Shekhar authored
      e91a9167
    • Leonard Zhou's avatar
      merge · 8c7b34d1
      Leonard Zhou authored
      8c7b34d1
    • Leonard Zhou's avatar
      merge · fc0c1cca
      Leonard Zhou authored
      fc0c1cca
    • Davi Arnaut's avatar
      Post-merge fix: test depends on feature not available under embedded. · 19cb8641
      Davi Arnaut authored
      mysql-test/t/query_cache_28249.test:
        Test depends on process state (not updated under embedded)
      19cb8641
    • Leonard Zhou's avatar
      Bug#40013 mixed replication: row based format could lead to stale tmp tables on the · ab369861
      Leonard Zhou authored
      slave.
      
      In mixed mode, if we create a temporary table and do some update which switch to ROW format,
      the format will keep in ROW format until the session ends or the table is dropped explicitly. 
      When the session ends, the temp table is dropped automaticly at cleanup time.
      but it checks only current binlog format and so skip insertion of DROP TABLE instructions into binlog.
      So the temp table can't be dropped correctly at slave.
      
      Our solution is that when closing temp tables at cleanup time we check both binlog format and binlog mode,
      and we could write DROP TABLE instructions into binlog if current binlog format is ROW but in MIX mode.
      
      mysql-test/suite/rpl/r/rpl_temp_table_mix_row.result:
        Test result file.
      mysql-test/suite/rpl/t/rpl_temp_table_mix_row.test:
        Test file.
      sql/sql_base.cc:
        Didn't do binloging when both current format and default format are ROW.
      ab369861
  3. 22 Feb, 2009 1 commit
  4. 21 Feb, 2009 1 commit
    • Alfranio Correia's avatar
      BUG#38174 secure-file-priv breaks LOAD DATA INFILE replication in statement mode · 98502312
      Alfranio Correia authored
                        
      If secure-file-priv was set on slave, it became unable to execute
      LOAD DATA INFILE statements sent from master using mixed or
      statement-based replication.
                        
      This patch fixes the issue by ignoring this security restriction
      and checking if the files are created and read by the slave in the
      --slave-load-tmpdir while executing the SQL Thread.
      98502312
  5. 20 Feb, 2009 10 commits
  6. 19 Feb, 2009 20 commits
    • Patrick Crews's avatar
      merge 5.0 -> 5.1 · 51a1eaf2
      Patrick Crews authored
      These are only 5.0's fixes being merged.
      5.1 and 6.0 Unix-removals will occur in different patches.
      51a1eaf2
    • Patrick Crews's avatar
      Bug#38831: 11 test cases fail on Windows due to missing commands · decee3cb
      Patrick Crews authored
      Re-enabling mysqlbinlog.test on Windows - removed the use of grep/sed
      decee3cb
    • Davi Arnaut's avatar
      Bug#41098: Query Cache returns wrong result with concurrent insert · 021b9a51
      Davi Arnaut authored
      The problem is that select queries executed concurrently with
      a concurrent insert on a MyISAM table could be cached if the
      select started after the query cache invalidation but before
      the unlock of tables performed by the concurrent insert. This
      race could happen because the concurrent insert was failing
      to prevent cache of select queries happening at the same time.
      
      The solution is to add a 'uncacheable' status flag to signal
      that a concurrent insert is being performed on the table and
      that queries executing at the same time shouldn't cache the
      results.
      
      mysql-test/r/query_cache_debug.result:
        Add test case result for Bug#41098
      mysql-test/t/disabled.def:
        Re-enable test case.
      mysql-test/t/query_cache_debug.test:
        Add test case for Bug#41098
      sql/sql_cache.cc:
        Debug sync point for regression testing purposes.
      sql/sql_insert.cc:
        Remove meaningless query cache invalidate. There is already
        a preceding invalidate for queries that started before the
        concurrent insert.
      storage/myisam/ha_myisam.cc:
        Check for a active concurrent insert.
      storage/myisam/mi_locking.c:
        Signal the start of a concurrent insert. Flag is zeroed once
        the state is updated back.
      storage/myisam/myisamdef.h:
        Add flag to signal a active concurrent insert.
      021b9a51
    • Serge Kozlov's avatar
      merge 5.1 · 23739d51
      Serge Kozlov authored
      23739d51
    • Patrick Crews's avatar
      Bug#38831: 11 test cases fail on Windows due to missing commands · c2e92617
      Patrick Crews authored
      Replaced Unix calls with mysql-test-run's built-in functions / SQL manipulation where possible.
      Replaced error codes with error names as well.
      Disabled two tests on Windows due to more complex Unix command usage
      See Bug#41307, Bug#41308
      c2e92617
    • Serge Kozlov's avatar
      Bug#41423. · 9fdfe2de
      Serge Kozlov authored
      1. Constant values of binlog positions replaced by seeking them in binlog/relay log.
      2. Updated result file
      9fdfe2de
    • Georgi Kodinov's avatar
      merged 5.0-bugteam -> 5.1-bugteam · 0a3baee1
      Georgi Kodinov authored
      0a3baee1
    • Tatiana A. Nurnberg's avatar
      manual merge · 54d72da4
      Tatiana A. Nurnberg authored
      54d72da4
    • Tatiana A. Nurnberg's avatar
      Bug#33550: mysqldump 4.0 compatibility broken · 1c5c2a45
      Tatiana A. Nurnberg authored
      mysqldump included character_set_client magic
      that is unknown before 4.1 even when asked for
      an appropriate compatibility mode.
      
      In compatibility (3.23, 4.0) mode, we do not
      output charset statements (not even in a
      "comment conditional"), nor do we do magic on
      the server, even if the server is sufficient
      new (4.1+). Table-names will be output converted
      to the charset requested by mysqldump; if such
      a conversion is not possible (Ivrit -> Latin),
      mysqldump will fail.
      1c5c2a45
    • Georgi Kodinov's avatar
      merged bug 42419 to 5.0-bugteam · 5e19d075
      Georgi Kodinov authored
      5e19d075
    • Georgi Kodinov's avatar
      Bug #42419: Server crash with "Pure virtual method called" on two concurrent · 7c0b3153
      Georgi Kodinov authored
      connections
      The problem is that tables can enter open table cache for a thread without 
      being properly cleaned up. This can happen if make_join_statistics() fails 
      to read a const table because of e.g. a deadlock. It does set a member of 
      TABLE structure to a value it allocates, but doesn't clean-up this setting 
      on error nor does it set the rest of the members in JOIN to allow for 
      automatic cleanup.
      As a result when such an error occurs and the next statement depends re-uses 
      the table from the open tables cache it will get it with this 
      TABLE::reginfo.join_tab pointing to a memory area that's freed.
      Fixed by making sure make_join_statistics() cleans up TABLE::reginfo.join_tab 
      on error.
      
      mysql-test/r/innodb_mysql.result:
        Bug #42419: test case
      mysql-test/t/innodb_mysql-master.opt:
        Bug #42419: increase the timeout so it covers te conservative 
        sleep 3 in the test
      mysql-test/t/innodb_mysql.test:
        Bug #42419: test case
      sql/sql_select.cc:
        Bug #42419: clean up the members of TABLE on failure in 
                make_join_statisitcs()
      7c0b3153
    • Sergey Glukhov's avatar
      automerge · da9b873b
      Sergey Glukhov authored
      da9b873b
    • Sergey Glukhov's avatar
      5.0-bugteam->5.1-bugteam merge · 7af856a8
      Sergey Glukhov authored
      7af856a8
    • Sergey Glukhov's avatar
      Bug#37601 Cast Is Not Done On Row Comparison · b68e5b66
      Sergey Glukhov authored
      In case of ROW item each compared pair does not
      check if argumet collations can be aggregated and
      thus appropiriate item conversion does not happen.
      The fix is to add the check and convertion for ROW
      pairs.
      
      
      mysql-test/r/row.result:
        test result
      mysql-test/t/row.test:
        test case
      sql/item.cc:
        added agg_item_set_converter() function which was a part of
        agg_item_charsets() func. The only difference is that
        agg_item_set_converter() checks and converts items 
        using already known collation.
      sql/item.h:
        added agg_item_set_converter() function
      sql/item_cmpfunc.cc:
        In case of ROW item each compared pair does not
        check if argumet collations can be aggregated and
        thus appropiriate item conversion does not happen.
        The fix is to add the check and convertion for ROW
        pairs.
      b68e5b66
    • Staale Smedseng's avatar
      Bug#31506 detection of function's availability is wrong in · 5a44f2e3
      Staale Smedseng authored
      configure.in
      
      Replacing AC_CHECK_FUNC+AC_CHECK_LIB combination with
      AC_SEARCH_LIBS.
      5a44f2e3
    • Alexey Kopytov's avatar
      ebfca91c
    • Alexey Kopytov's avatar
      Automerge. · 169fb823
      Alexey Kopytov authored
      169fb823
    • Alexey Kopytov's avatar
      Automerge. · 9da1816e
      Alexey Kopytov authored
      9da1816e
    • Alexey Kopytov's avatar
      Automerge. · 84985951
      Alexey Kopytov authored
      84985951
    • Alexey Kopytov's avatar
      Fix for bug #41078: With CURSOR_TYPE_READ_ONLY mysql_stmt_fetch() · 074b4bad
      Alexey Kopytov authored
      returns short string value. 
       
      Multibyte character sets were not taken into account when 
      calculating max_length in Item_param::convert_str_value(). As a 
      result, string parameters of a prepared statement could be 
      truncated later when calculating string length in characters by 
      dividing length in bytes by the charset's mbmaxlen value (e.g. in 
      Field_varstring::store()). 
       
      Fixed by taking charset's mbmaxlen into account when calculating 
      max_length in Item_param::convert_str_value().
      
      
      sql/item.cc:
        Multiply string's length in characters by charset's mbmaxlen when 
        calculating max_length.
      tests/mysql_client_test.c:
        Added a test case for bug #41078.
      074b4bad
  7. 18 Feb, 2009 2 commits
    • Mattias Jonsson's avatar
      Backport of test results for Bug#38719 from 6.0 to 5.1 · 39840287
      Mattias Jonsson authored
      post push fix, Bug#38719, additional test cases updated
      39840287
    • Mattias Jonsson's avatar
      Backport of bug#38719 from 6.0 to 5.1 · 571c66e3
      Mattias Jonsson authored
      handler::get_dup_key used the called handler for the
      info call, but used table->file handler for errkey.
      Fixed by using table->file->info instead.
      
      mysql-test/r/partition_error.result:
        Bug#38719: Partitioning returns a different error code for
        a duplicate key error
        
        Added test for verification
      mysql-test/t/partition_error.test:
        Bug#38719: Partitioning returns a different error code for
        a duplicate key error
        
        Added test for verification
      571c66e3