1. 18 Apr, 2006 3 commits
    • unknown's avatar
      Fixed BUG#18344: DROP DATABASE does not drop associated routines · 176cd143
      unknown authored
        We must use the db key length in sp_drop_db_routines (and not the
        number of characters), or long db names will be truncated in the key.
      
      
      mysql-test/r/sp.result:
        Updated results for new test case (BUG#18344)
      mysql-test/t/sp.test:
        Added new test case for BUG#18344.
      sql/sp.cc:
        In sp_drop_db_routines(), give the key field's ("db") key length
        instead of the number of characters to index_read(), or the key
        packing will truncate long db names.
      176cd143
    • unknown's avatar
      Merge mysql.com:/extern/mysql/bk/mysql-5.0-runtime · 750bc269
      unknown authored
      into  mysql.com:/extern/mysql/5.0/bug18787/mysql-5.0-runtime
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      750bc269
    • unknown's avatar
      Post-review fix for BUG#18787. Renamed a local variable in · d9142f99
      unknown authored
      Item_func_sp::tmp_table_field() to something more descriptive.
      
      
      sql/item_func.cc:
        Renamed local variable 'res' to 'field' in Item_func_sp::tmp_table_field(),
        because it is.
      d9142f99
  2. 13 Apr, 2006 8 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 70695997
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime-merge
      
      
      sql/sql_yacc.yy:
        Auto merged
      70695997
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-5.0-root · 30bd4983
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime-merge
      
      
      sql/item.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/mysqld.cc:
        SCCS merged
      30bd4983
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 68f7928f
      unknown authored
      into  dl145j.mysql.com:/tmp/andrei/5.0-bug18715_drop_view_slave
      
      
      68f7928f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 8077c693
      unknown authored
      into  mysql.com:/home/MySQL/5.0-Bug-17248a
      
      
      8077c693
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · 93409ee7
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.0-csc9139
      
      
      93409ee7
    • unknown's avatar
      BUG#19021, Crash in ROR-index_merge optimizer: · c89555ed
      unknown authored
      get_best_covering_ror_intersect() was copying ror_scans starting from the 
      end of the array and not from its beginning.
      
      
      mysql-test/r/index_merge_innodb.result:
        Testcase for BUG#19021
      mysql-test/t/index_merge_innodb.test:
        Testcase for BUG#19021
      sql/opt_range.cc:
        BUG#19021: In get_best_covering_ror_intersect(), the array of pointers to
        scans to be used is [tree->ror_scans, ror_scan_mark), and not
        [ror_scan_mark, ...)
      c89555ed
    • unknown's avatar
      foo2 · 365f6f6f
      unknown authored
      
      sql/ha_innodb.cc:
        Import patch foo2
      sql/ha_innodb.h:
        Import patch foo2
      sql/handler.cc:
        Import patch foo2
      sql/handler.h:
        Import patch foo2
      sql/mysqld.cc:
        Import patch foo2
      sql/set_var.cc:
        Import patch foo2
      sql/sql_class.h:
        Import patch foo2
      sql/sql_repl.cc:
        Import patch foo2
      365f6f6f
    • unknown's avatar
      foo1 · ce335550
      unknown authored
      
      sql/ha_innodb.cc:
        Import patch foo1
      sql/ha_innodb.h:
        Import patch foo1
      sql/handler.cc:
        Import patch foo1
      sql/handler.h:
        Import patch foo1
      sql/mysqld.cc:
        Import patch foo1
      sql/set_var.cc:
        Import patch foo1
      sql/sql_class.h:
        Import patch foo1
      sql/sql_repl.cc:
        Import patch foo1
      ce335550
  3. 12 Apr, 2006 9 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · c16b9dfc
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      c16b9dfc
    • unknown's avatar
      Post-merge fixes. Add a new error message for max_prepared_stmt_count · c5ed5c4b
      unknown authored
      limit.
      
      
      mysql-test/r/ps.result:
        Post-merge fixes.
      mysql-test/t/ps.test:
        Post-merge fixes.
      sql/share/errmsg.txt:
        Add a new error message for max_prepared_stmt_count limit,
        we can do it in 5.0
      sql/sql_class.cc:
        Post-merge fixes.
      sql/sql_class.h:
        Post-merge fixes.
      sql/sql_prepare.cc:
        Post-merge fixes.
      c5ed5c4b
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · aadfa648
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15933
      
      
      aadfa648
    • unknown's avatar
      Bug#16461: connection_id() does not work properly inside trigger · 886a35bd
      unknown authored
      CONNECTION_ID() was implemented as a constant Item, i.e. an instance of
      Item_static_int_func class holding value computed at creation time.
      Since Items are created on parsing, and trigger statements are parsed
      on table open, the first connection to open a particular table would
      effectively set its own CONNECTION_ID() inside trigger statements for
      that table.
      
      Re-implement CONNECTION_ID() as a class derived from Item_int_func, and
      compute connection_id on every call to fix_fields().
      
      
      mysql-test/r/trigger.result:
        Add result for bug#16461.
      mysql-test/t/trigger.test:
        Add test case for bug#16461.
      sql/item.cc:
        Remove now unused class Item_static_int_func.
      sql/item.h:
        Remove now unused class Item_static_int_func.
      sql/item_create.cc:
        Use new implementation of CONNECTION_ID().
      sql/item_func.cc:
        Re-implement CONNECTION_ID() as Item_func_connection_id
        (was Item_static_int_func).  Set max_length to 10, as it was before.
        Compute connection_id dynamically on every call to fix_fields().
      sql/item_func.h:
        Re-implement CONNECTION_ID() as Item_func_connection_id
        (was Item_static_int_func).
      886a35bd
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-16365 · e46a193b
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-merge
      
      
      sql/set_var.cc:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      sql/item_row.cc:
        Manual merge.
      sql/item_row.h:
        Manual merge.
      sql/mysql_priv.h:
        Manual merge.
      sql/mysqld.cc:
        Manual merge.
      sql/set_var.h:
        Manual merge.
      sql/sql_class.cc:
        Manual merge.
      sql/sql_class.h:
        Manual merge.
      sql/sql_prepare.cc:
        Manual merge.
      e46a193b
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · 1dc282ae
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15933
      
      
      1dc282ae
    • unknown's avatar
      In test for bug#15933 we have to wait for all disconnects to finish to avoid · 51a3d366
      unknown authored
      a race between updating and checking Max_used_connections.  This is done in
      a loop until either disconnect finished or timeout expired.  In a latter case
      the test will fail.
      
      
      mysql-test/r/status.result:
        Update result to match changes in test case.
      mysql-test/t/status.test:
        Close extra conections in previous test.
        In test for bug#15933 we have to wait for all disconnects to finish to avoid
        a race between updating and checking Max_used_connections.  This is done in
        a loop until either disconnect finished or timeout expired.  In a latter case
        the test will fail.
        Use con1, con2, con3 instead of con3, con4, con5.
      51a3d366
    • unknown's avatar
      #BUG18715 create view with replicate*ignore-table · 0e19aa9e
      unknown authored
      Fixed in parser. rpl_view gained no changes but rpl_view-slave.opt.
      
      
      sql/sql_yacc.yy:
        UPDATING option for create/alter view is added for tables_ok to finds the view's
        TABLE_LIST.updating as true. FIXME: Regarding to UPDATING option `create view' should not have
        any difference from `create table'.
      mysql-test/t/rpl_view-slave.opt:
        The option is needed to force slave executes tables_ok which must return OK in conditions of this tests (no table foo is used.
      0e19aa9e
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 10633fd8
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      10633fd8
  4. 11 Apr, 2006 13 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 53e47e3b
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/mysql-5.0__ready
      
      
      53e47e3b
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · b54cb499
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      b54cb499
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c97aa492
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b14360
      
      
      c97aa492
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8907bf0a
      unknown authored
      into  mysql.com:/home/alexi/bugs/mysql-5.0-merge
      
      
      sql/sql_insert.cc:
        Auto merged
      8907bf0a
    • unknown's avatar
      Bug#18474 Unlistable directories yield no info from information_schema, part2 · c3d37c2b
      unknown authored
       - Improved solution by adding an else stetment so that do find next is avoided if erorr occurs, but we still return zero files found instaed of an error
      
      
      mysys/my_lib.c:
        Add else statment so that if a directory can't be read because of access denied it will be skipped and zero files returned.
        Use strnmov instead of strmov to avoid writing after end of buffer
      c3d37c2b
    • unknown's avatar
      Fixed bug #18618. · 981bbaef
      unknown authored
      If the second or the third argument of a BETWEEN predicate was
      a constant expression, like '2005.09.01' - INTERVAL 6 MONTH,
      while the other two arguments were fields then the predicate 
      was evaluated incorrectly and the query returned a wrong
      result set.
      The bug was introduced in 5.0.17 when in the fix for 12612.
      
      
      mysql-test/r/func_time.result:
        Added a test case for bug #18618.
      mysql-test/t/func_time.test:
        Added a test case for bug #18618.
      981bbaef
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 961725aa
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b14360
      
      
      961725aa
    • unknown's avatar
      Fix for bug #14360: Date Between Interval Broken. · 1ef73963
      unknown authored
                                         
      
      
      mysql-test/r/innodb.result:
        Fix for bug #14360: Date Between Interval Broken.                               
          - test case.
      mysql-test/t/innodb.test:
        Fix for bug #14360: Date Between Interval Broken.                               
          - test case.
      sql/item_timefunc.cc:
        Fix for bug #14360: Date Between Interval Broken.                               
          - Item_date_add_interval::eq() introduced.
      sql/item_timefunc.h:
        Fix for bug #14360: Date Between Interval Broken.                               
          - Item_date_add_interval::eq() introduced.
      1ef73963
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 3d860b13
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug5390
      
      
      3d860b13
    • unknown's avatar
      Fixed BUG#18787: Server crashed when calling a stored procedure containing · 9381c8a0
      unknown authored
                       a misnamed function
        ... in the presence of a continue handler. The problem was that with a
        handler, it continued to execute as if function existed and had set a
        useful return value (which it hadn't).
        The fix is to set a null return value and do an error return when a function
        wasn't found.
      
      
      mysql-test/r/sp.result:
        Updated results for a new test case (BUG#18787).
      mysql-test/t/sp.test:
        New testcase for BUG#18787.
      sql/item_func.cc:
        Don't set "out of resources" error in Item_func_sp::execute() if no
        result field is returned, it's simply wrong, it can be sometthing else,
        like a function not found. Instead set null_value and return error.
        Also, set "out of resources" when field creation fails in
        Item_func_sp::sp_result_field() and Item_func_sp::tmp_table_field().
      9381c8a0
    • unknown's avatar
      Add surrounding braces, move invalidate dictionary_cace to after declaration... · 3b1a0c87
      unknown authored
      Add surrounding braces, move invalidate dictionary_cace to after declaration of variable "table_list"
      
      
      
      3b1a0c87
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 3c392808
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      3c392808
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 4c46f306
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug5390
      
      
      4c46f306
  5. 10 Apr, 2006 7 commits